From: Mukesh Ojha <quic_mojha@quicinc.com>
To: Yu Zhe <yuzhe@nfschina.com>, <agross@kernel.org>,
<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
<mathieu.poirier@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<liqiong@nfschina.com>
Subject: Re: [PATCH] remoteproc: qcom_q6v5_mss: remove unnecessary (void*) conversions
Date: Thu, 16 Mar 2023 16:04:58 +0530 [thread overview]
Message-ID: <2c5f63ac-470e-51fa-4330-c9603eb9efcf@quicinc.com> (raw)
In-Reply-To: <20230316091902.20765-1-yuzhe@nfschina.com>
On 3/16/2023 2:49 PM, Yu Zhe wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
> drivers/remoteproc/qcom_q6v5_mss.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index ab053084f7a2..e7a67c8c16a0 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -1562,7 +1562,7 @@ static void qcom_q6v5_dump_segment(struct rproc *rproc,
>
> static int q6v5_start(struct rproc *rproc)
> {
> - struct q6v5 *qproc = (struct q6v5 *)rproc->priv;
> + struct q6v5 *qproc = rproc->priv;
> int xfermemop_ret;
> int ret;
>
> @@ -1604,7 +1604,7 @@ static int q6v5_start(struct rproc *rproc)
>
> static int q6v5_stop(struct rproc *rproc)
> {
> - struct q6v5 *qproc = (struct q6v5 *)rproc->priv;
> + struct q6v5 *qproc = rproc->priv;
> int ret;
>
> ret = qcom_q6v5_request_stop(&qproc->q6v5, qproc->sysmon);
> @@ -1662,7 +1662,7 @@ static int qcom_q6v5_register_dump_segments(struct rproc *rproc,
>
> static unsigned long q6v5_panic(struct rproc *rproc)
> {
> - struct q6v5 *qproc = (struct q6v5 *)rproc->priv;
> + struct q6v5 *qproc = rproc->priv;
>
> return qcom_q6v5_panic(&qproc->q6v5);
> }
> @@ -1977,7 +1977,7 @@ static int q6v5_probe(struct platform_device *pdev)
> rproc->auto_boot = false;
> rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_NONE);
>
> - qproc = (struct q6v5 *)rproc->priv;
> + qproc = rproc->priv;
> qproc->dev = &pdev->dev;
> qproc->rproc = rproc;
> qproc->hexagon_mdt_image = "modem.mdt";
Well, there is quite a few files under driver/remoteproc/ which has this
kind of assignation.
Do you intend to do this for all ?
Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>
-- Mukesh
next prev parent reply other threads:[~2023-03-16 10:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 9:19 Yu Zhe
2023-03-16 10:34 ` Mukesh Ojha [this message]
2023-03-20 6:11 ` [PATCH v2] remoteproc: " Yu Zhe
2023-03-20 11:51 ` kernel test robot
2023-03-26 11:14 ` kernel test robot
2023-03-27 14:46 ` kernel test robot
2023-03-28 1:57 ` [PATCH v3] " Yu Zhe
2023-03-28 2:49 ` [PATCH v4] " Yu Zhe
2023-03-28 7:42 ` Dan Carpenter
2023-03-29 17:46 ` Mathieu Poirier
2023-03-28 7:40 ` [PATCH v3] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c5f63ac-470e-51fa-4330-c9603eb9efcf@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=mathieu.poirier@linaro.org \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®