From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A96945A0E4 for ; Wed, 17 Apr 2024 12:42:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713357740; cv=none; b=Rs4EVZoM0Ov5vMz0/gwc/0laME7GLCES1LiNxCe/QZrXZh4NvhWUX+kR8jvjN3BEQRskv73CBCkX58DZN19EnATRasByGTLYHSRfO1OK46tb9CyAFx9qA6dDmTL+rvMiDsqpC9VQXn/Bk6m+MmzgVkJXRtyTe0IyXSoB51uLO3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713357740; c=relaxed/simple; bh=AwKyjiWJRzagWC2MbqX3hFlf49pQyQ5paXVC/+7FW6w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dAFbShLwf7QYYdwv7hbM+MJN2BbJkOVQ4FBLDv1khG1IhtvO1WUoTN6NqfCmSwaCA+tNXyb8JweazOIJUDYf6e86wwjUJJV8woTP/ZBszHv50SU4/4r82dBF6GETgsT56Wz9aMbeFOCebt662ZDzklZnjaBrLxho9i5LL7gKIas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tORP0eiw; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tORP0eiw" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-56c5d05128dso6088100a12.0 for ; Wed, 17 Apr 2024 05:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713357736; x=1713962536; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hGxJr1eT1juIaCt0B8kVSHBgvMQ9mE5owuvsY4aMzkc=; b=tORP0eiwqw+a1r6TOse4RmmZ/RQ4NSz2P6C0H73xLpyIuqI8C4jppxyWdmFBB7L2sZ yhzgWAChJ29NdffoMaORYRKud2OHlWSPwv/4GoZ/IGgac1FfSzbT84UK4+7YEdMkQ4cR yZfKTCXCOZMAJB9gSulLQNDpTpYlRp4h5yhJSsksUn47qvC3c7F94rkEWibkNECp5SWD RboL9a4MJFOKfNjxv5liqS7gkuwHdaA0l3S/NKj8Y+NJ+BHm1mc97TspML3RivLRhn1p F1hU0f1261tHfSuhVZEnoN/NqsZVuNt0ldTvoz2pnPtSndCxMJvEixdESpfsM5DG90qD rH/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713357736; x=1713962536; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hGxJr1eT1juIaCt0B8kVSHBgvMQ9mE5owuvsY4aMzkc=; b=qlM7hvmP2xbTNtSmi4EdNjVthdVWh5z97Dyhqn6RfLiMxHD8MV9XhmygJFDsrkLjnm FIgjZXIkvBE61CXl2AUIFGBOe1dKH7Q77h1Lva7ZB41vgMadAnULLBUcghn2tGHLnJTs Bhhv2oFqbn2C4B4BG4yiAiZo2Vl6nV01ochMTz5BHI2lmRFFJ4BjIAWLKATQvmvgSZEL Q5yG0CrZWEQnWbKQSw9595SfU7N1VVyfJQFcDdEZlxGyJ+ykuSAqZYSyuuKzJSPA348X RQbLghE2iyVu9rnCvUd4w+BD46cdQFFvYE2Y0SUhS3kl9Cr0+fD3T8JsZNBGL4wZYUdw X6cg== X-Forwarded-Encrypted: i=1; AJvYcCXVb07EXm7vATYHkEYZGNvOwcxy9665hLEDVr7Kp6I/52zDw/Qt5itAN1pw+A2fv+WbzYmcYcgPpn1fbXHfrvoOZnfju5MfBpmlfR/W X-Gm-Message-State: AOJu0YzRRSiau2i7DpCdHPDeYtxKxiKVW8TxqHvRGP3WZUMuyOB/PeGT Y2LB3KonCPTO9oo5oc5u0P7vsH/ZyaTzqFdPiPDC3rl6OPEWqts+V+6VNMPjF+w= X-Google-Smtp-Source: AGHT+IE7pfXIfIVm1oVxaQaBU9J4TOarr6VsYEeyJ2uNUE4J8Yrala0tsc/J6hnG5NT5hKmDzgbjdQ== X-Received: by 2002:a50:d75b:0:b0:56e:2ab1:c803 with SMTP id i27-20020a50d75b000000b0056e2ab1c803mr11948542edj.0.1713357735666; Wed, 17 Apr 2024 05:42:15 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id en8-20020a056402528800b0056e2432d10bsm7248586edb.70.2024.04.17.05.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 05:42:15 -0700 (PDT) Date: Wed, 17 Apr 2024 15:42:11 +0300 From: Dan Carpenter To: Peng Fan Cc: "Peng Fan (OSS)" , Cristian Marussi , Linus Walleij , Sudeep Holla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dhruva Gole , Andy Shevchenko , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Oleksii Moisieiev Subject: Re: [PATCH v10 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-ID: <2c608b57-fe0b-40dd-a1f8-8f0808605ae3@moroto.mountain> References: <20240415-pinctrl-scmi-v10-0-59c6e7a586ee@nxp.com> <6c652af8-151e-4d8b-9587-8eae1254a4fe@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 17, 2024 at 12:15:57PM +0000, Peng Fan wrote: > Hi Dan, > > > Subject: Re: [PATCH v10 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol > > protocol basic support > > > > I'm trying to re-base AKASHI Takahiro's gpio driver on top of your scmi pinctrl > > driver. > > https://lore.ke/ > > rnel.org%2Fall%2F20231005025843.508689-1- > > takahiro.akashi%40linaro.org%2F&data=05%7C02%7Cpeng.fan%40nxp.com% > > 7C342dd6eb0463456d0d6608dc5e41de1c%7C686ea1d3bc2b4c6fa92cd99c5 > > c301635%7C0%7C0%7C638488884186606528%7CUnknown%7CTWFpbGZs > > b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn > > 0%3D%7C0%7C%7C%7C&sdata=DMJZ2uwuJigkEnEcY7JdBw6DMPjHxcUvvh7 > > 2fsaep50%3D&reserved=0 > > I need to do something like this below to save the gpio information. > > > > So now, great, I have the information but I'm not sure how to export it from > > the scmi pinctrl driver to the gpio driver... (This is a probably a stupid > > question but I am real newbie with regards to gpio). > > > > The other thing is that the SCMI spec says: > > > > 4.11.2.7 > > PINCTRL_SETTINGS_GET > > > > This command can be used by an agent to get the pin or group > > configuration, and the function selected to be enabled. It can also > > be used to read the value of a pin when it is set to GPIO mode. > > > > What does that mean? Is that right, or is it something left over from a > > previous revision of the spec. > > > > regards, > > dan carpenter > > > > diff --git a/drivers/firmware/arm_scmi/pinctrl.c > > b/drivers/firmware/arm_scmi/pinctrl.c > > Just a short question, you will make this a standalone > patch part of your gpio pinctrl patchset, right? > > Or you wanna include this change in my v11 patch? > > I hope v11 + imx oem patches could land in 6.10, > so I would not expect big changes to v11. Yeah. Let's get your patches merged. I don't think there is anything in mine which conflict with yours. It's just addon. regards, dan carpenter