From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1B0F3DD507 for ; Thu, 25 Jun 2026 11:45:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782387958; cv=none; b=LSaVf7ovpyd1vPI0ZJYNM16JLny9d7iDLb2/sgmfN7AIEWWi1nMWE4u78UXN+XD9eUK4y+0WW+oQ/xXIW6x4Gj8p90KAqZnGdrz8/UV7DMDU1alHW+7RKCort14CjSfVUhkVrZFgBCbBfElIU/PYTGsIsJ062lCvgPudyh3xMQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782387958; c=relaxed/simple; bh=eDu7KO5wVpXqlpuFQGtibVoKwA9rv9uNhIjqKkHb9+o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tL+schMJkdTdWI+9ZqhmEeus28iyLnLGjE6ydt6+zkqmE7eq+ftW5kY9R0V8Te84GFa5l4tNM/oGE5+bqFWatU/F8tM8ihbessbWyE3RWmGamsQW0//s37lJz8d0RTWwjy921IqyXkdfkxXSvEYicT9r5gfROf/i1erHm5AS0kE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aKCnrjMK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eFmchs4d; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aKCnrjMK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eFmchs4d" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65P9k0fb1398023 for ; Thu, 25 Jun 2026 11:45:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4BAcSRl1VLBvY+rm1E0QENVPruUvSrRzM9gP5scU+pQ=; b=aKCnrjMKVZdK5yIX bETBOhO6H1ZDfQzhCKPjHdfCoAFlqLsHSSXBQn8CC6bl0jSB262dKBMcbQMrvwDl jk3lPY4Uufcusa9MPsP6vMSRyDYHRUHz74XUMOFK2pUOIEAg2HYab0B6IRV2SjBm u8hm1JrHB9Pw7W3tMKQ+rOUOmPY9ZmE8n/pLDd6oa1l/XwMjbBo75LB4mymzjsg/ pL7rb3l39mN4Tf0qJgJE/tD7iyWs4AkRTiSun0YIkLt08hKm6nod450jDWbwgSjX xSILhatTr3kZA/LHC7DOgshb+asq+zMtsSIk4msLDGfURca5+h4faYr1YhhFi5az Y9cohw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0uudhxcn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 11:45:56 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51a15cef334so2449221cf.3 for ; Thu, 25 Jun 2026 04:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782387955; x=1782992755; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4BAcSRl1VLBvY+rm1E0QENVPruUvSrRzM9gP5scU+pQ=; b=eFmchs4dDiLN05SAltXK4VnaG6utoEN6wFa5mnhLVzKJEZlhBaHNtJEf5hys6eC95N i1SQRMRmipqMNbCLUiJWmOZ1SUEBFs2tXjauhIbK3s/Lcun45dYiGVedJu5Pgjv+rwKw womgwcHi2NhxC9BRtnTB4TUJsLtx2sO/U6dq4PfcV5PHXFUVy8atKIfFn19T4pHiwjYB 2rJBcsEWMtAKWebNf50SwaqwavT9GB+BMdqrp0XdpQ9BqBjTbqMwHal+UoCYlrgG2zUS yUSoJHQK5xe0O463Zt8phsOAyXU6TawC37YSc0icvPaBk8/R4sxdRLWIWdAoyA5nyoXr lkUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782387955; x=1782992755; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4BAcSRl1VLBvY+rm1E0QENVPruUvSrRzM9gP5scU+pQ=; b=cU6ImiYRxvdU/c5nVl+5lMb1573BcWmLN2MyGHK9eZgmZWCTSGDjBdFLYwmJ2tedFj yQJlaM0H+hpULpES5ymyPB8cXeo11tVaoSCLcS9PGhElvJm0S1DbES1DGi2ddZsttuXk CSPGHvDHwFBh6Fsapk2WVe8rHtXlNly62d4Az41EA/aWNe+1wNG8nPQjL6rcVf+8bvFc SQGt+u0vPP32J57/7xafb6kQZQJYDBbBynPaB47QqQxI79c0sSxO415kI26qXTtvOuEH twL4ZlY20ZiohItn6mjSMuxrx6Gb8HbRSpowHbMGFKgMKeZV0a8NWA94LoHQgqAhoCcm SqFQ== X-Forwarded-Encrypted: i=1; AFNElJ9w8AJRYcp2vOumMhz0dKnC+dSeNWyb4pkhq6v/OTbp+md6WeglkESNYsuPtiTYvqsmtDRznbdAxVGTwCM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzva6UiU2L1qf1wJM6y96X+UJcTP0FoSv+DjvDT846+fVNVPPDY kikE8Toe1i1jccyPm5Ix9Uxl0KVQZ+HaH7w32wzukRrznmNccvcNF48zhbQH1081G+m4G0nX7a8 SQl7JVc6oAT4Qe7PeGOTI4PKl4pBz+oSS76swgDhPbdV/CrjJ2+2wCqv3xfe1+kIRcms= X-Gm-Gg: AfdE7ckk2/4iRKUCiFjchlSDEUzOcdo6WA2t/k/sTMtSvGgYLyiVs0AGXZQn3XI9KjN gfP+pmGYWMPCnaV3V6KX70RCA4Il4TLRlOE2e8yTxhEzb65knms2IDPs+QmGWzrU/mNFRFhs0bf Nb267wlyMBPth5RpXhPRpQBZNy4E/f2LGT9N+P9yvdNrWeWuD2rwcaMObrmGLVroqWhZxGD6kHO 8otnOmz5OSND6MrAb74ONzbmLNd80v0h+nYzD1PDxVuJgeA12nLzPmACZtcqdbWUTKqV00Ge0q9 2sgJg+g7wbdq5LUa5WyBuzJDIOcxytV5x8aymUjBjSQGlnE6it5F3LT9QiY3hblE7nNuBQHw/IH Lq5/rxOt3nZE7cgEgXDYzwSDpe36oxRROu3s= X-Received: by 2002:a05:622a:58e:b0:517:5af6:77f9 with SMTP id d75a77b69052e-51a7279f2d0mr15663411cf.3.1782387954998; Thu, 25 Jun 2026 04:45:54 -0700 (PDT) X-Received: by 2002:a05:622a:58e:b0:517:5af6:77f9 with SMTP id d75a77b69052e-51a7279f2d0mr15663121cf.3.1782387954346; Thu, 25 Jun 2026 04:45:54 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c11fbe6220esm165472966b.45.2026.06.25.04.45.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 04:45:53 -0700 (PDT) Message-ID: <2c615e8f-674c-4def-b789-6e9c445a2241@oss.qualcomm.com> Date: Thu, 25 Jun 2026 13:45:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/8] arm64: dts: qcom: shikra: Add soundwire and macro nodes To: Mohammad Rafi Shaik , Srinivas Kandagatla , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260616201315.2565115-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260616201315.2565115-5-mohammad.rafi.shaik@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260616201315.2565115-5-mohammad.rafi.shaik@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDEwMCBTYWx0ZWRfX5xVPvsUhiwdR ho0zzGfhiOlLIbtRc+KJbpd+LapRz8e82dxWIkGYwKzVHMnsJjeWdHrXRTw+9wp46SVaU8Y69L6 Kyo7eF5a2SOpPyochGe0aNHQXwtafco= X-Proofpoint-ORIG-GUID: WK0KvVINjMyuUzaQig5iWVkN-tQSciNO X-Proofpoint-GUID: WK0KvVINjMyuUzaQig5iWVkN-tQSciNO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDEwMCBTYWx0ZWRfX66oORk+rlX0E BlngMFSa8aXGH9B+LieLZHfh4Fl4JfDvOzdmwXysrLbwD0FPUo4jl2t/zCgNzSxUokaIUs8DRxN tJ1VFypTbpaftnLoPjThA6++WDu6jMBbeVKI7Ko6KNAfWOvck6FiE3OENvSyFfKocktp1HfDGIy pFmwKQgMm27qyGxI73+HEpYG6lhQSflZcr5yL6wrj9uQJq3PQe5gtL8D7qxscxlOiUP9p/ZrNhu LtPzWiBuPXkuIujgS5Xc6p6UgWcKWUJnj6LkgLOzrfarzyO2L6PWpLgRisXYXa9dXiU/AUnd5k0 L6Zik2+9zKHi98YtoQBo/IAUgCVAEsy1TYD8F/LZGSAmyeZJgqfAu59VhfLxmmAJN3DaLl3TC0P 0Aa6ShyWIYZ8N5Di6KJhrffWQUZct0efwsC+LTAFwdRkIC4ToRnXwCN3S4UN8GRXmSyLgWfzY/e o9v+iW2LVdV1x1Ol3Lg== X-Authority-Analysis: v=2.4 cv=HdckiCE8 c=1 sm=1 tr=0 ts=6a3d14f4 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=jzc4C1M-m5MPkDtnTmwA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250100 On 6/16/26 10:13 PM, Mohammad Rafi Shaik wrote: > Add SoC-level SoundWire masters and LPASS RX/VA macro nodes, along with > DMIC and SWR pinctrl states required by the audio data path. > > Keep these nodes disabled in shikra.dtsi so board dts files can selectively > enable and configure them. > > Signed-off-by: Mohammad Rafi Shaik > --- Just a couple style nits: [...] > + rxmacro: codec@a040000 { > + compatible = "qcom,shikra-lpass-rx-macro"; > + reg = <0x0 0x0a040000 0x0 0x1000>; > + > + pinctrl-0 = <&rx_swr_active>; > + pinctrl-names = "default"; Let's move this down.. maybe above all the #cells > + > + clocks = <&audiocorecc AUDIO_CORE_CC_RX_MCLK_CLK>, > + <&audiocorecc AUDIO_CORE_CC_RX_MCLK_2X_CLK>, Please align all + <&vamacro>; > + clock-names = "mclk", > + "npl", > + "fsgen"; > + > + #clock-cells = <0>; > + clock-output-names = "mclk"; > + #sound-dai-cells = <1>; > + status = "disabled"; Let's keep a \n before 'status', everywhere Konrad