From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28CDD23098F for ; Wed, 15 Jan 2025 08:08:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736928518; cv=none; b=Qz4yfqZtLN7dEeRhKyPnd63CxhO5+A5LaLmySe8LY1+h3c8OLUxxDCjacQiWV5ATXCeVq9C6qr4pgLnUjo3i/I7TspJNdW3aH9vBhcPu9EmLfTQwLuNE2K3V9hl4X53BbVx/nWLpq87A2Go2+FXYt7boBX+7bWespZz4lY1DXVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736928518; c=relaxed/simple; bh=FKuuD5eu0mDOAMgJm88pAIaDgVcu13hR66eVnBswqoQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mOPqDFh0Plrg2fvrBisCwn/zivnA4iZFW2Dv0mQGlH8t6B5LhG7JqHVXt0gM+RSEW7yeogbcdU5jNqIKkKLOkP22YXEWjaL5Khgt9wvA2AhxG6pMyNuK59/0EHz4S+tfw4t3z2ThGIGTPj5dUjddOgV6APQTILwr7l+TJ5Ybd3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net; spf=none smtp.mailfrom=ursulin.net; dkim=pass (2048-bit key) header.d=ursulin-net.20230601.gappssmtp.com header.i=@ursulin-net.20230601.gappssmtp.com header.b=VVub65Q1; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ursulin.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ursulin-net.20230601.gappssmtp.com header.i=@ursulin-net.20230601.gappssmtp.com header.b="VVub65Q1" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4361dc6322fso44915705e9.3 for ; Wed, 15 Jan 2025 00:08:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ursulin-net.20230601.gappssmtp.com; s=20230601; t=1736928513; x=1737533313; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5TKs6VTiYoGGpokppBC12jXWmchUx26icqsF8+IlZzI=; b=VVub65Q1BE1bAHQqTEZb7sSikZdJ8bbR0qNH2HoAHh25e9W3FnppXnoz6HA9CAhj00 hXtuy152tcXD8CwKMXLCIEpbGGxa7t3ukmCPAWyyxVmkjomt+GfDVAV/V0YqktIdnwt7 Qly4cwWBQKXvgeWu5VHWWZpbVz/wKZk03EJRhfio8thTISHhMuCDN0yhzHkVjhnvbJIi nuDR4OL49T0v+qWebtfG8t+oDUtP3GIWj6vVxUulA9xBjI3pRvbjeVuiNkw7yjJ6JBrh WxAQ8u0S5kwkAm5LbaIrfpAaqNQQeCswGpPBPPtIGqxsEsjyFnB4bhGzzWiwKl6DhPPv sBSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736928513; x=1737533313; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5TKs6VTiYoGGpokppBC12jXWmchUx26icqsF8+IlZzI=; b=OpepVFTk3Zy5gJ1QqUXhV4LXgJI4rAHqeqdrOt7zZXNR0DY63m7vYchugTFkiVoo08 20q/ttTeJIl7qnfd2t9Ob3FOT2qHqAPbBGG75IcujD+AJMXTas/C7ppXLMNOwatD2nnZ jEi6o7jn9Ns8YeloKT2x5LLabAVwIG5KLzEehIeyzWxWNCr7eBnRY5OqwhAe/dGi3sDw i3n2E0F0+H1L2sSGoOsNsAuoqNCrTJ0ejQ/sKPfLdmLJiUVWoBkYkOm//xwEGGKCFRjZ da9680mU2LyeFea7uoiHI/sI/jajNch6RcP43TeBEkh4cBZMcTrJD5GgYmTOFJuyf+DT ocgA== X-Forwarded-Encrypted: i=1; AJvYcCWaexdpVHGPD4UvhKYHnpW7krxtOVQ0R2LXUkl9PmFc6SmDPMCthAis3bFrJdY7kghy10lQf2KyXQxcWsw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx63OAX52mD2OvzCfqYIY8dNceoTjnZbSXuQkCKNaMQoe9o8V5a 2LNoMXH1kuss9lF7xFyWMBbfX8CJBt1X00HzJoPZ2oTY7cFQo81N8wao2bqGJKc= X-Gm-Gg: ASbGncu1VPR9b3dUhsmwRs+TW074erhUAyh9rFDHeBMHLqZl1OmViQ171uRsMelL1ag 5pFZnDBruUs+bqjGJH9HWM0oJ4yKjgwy2XG2ny+nZoc+o1pPCkQV8WSxviyr6V58yrCXhaCUdsE zX6rcAbEgNc6uKniUnAVXJGjIadETEvCLuRqSu0zAIB7pscxo7j7eZKBclXdlKabak3n28TfDMF mS0kjvk+GtGUBAlsIAhyUc/fcCl/TOhmE/eXd5yskqRze+4sp8Np2P++J2Petjo1/xRW4Tz X-Google-Smtp-Source: AGHT+IGw5gYLx2t/yCDqQg7Q14Y8RhIh6+teFkP1OnWysoAZUxt7UwGTks5/Pp48T2Eg8MlJgQe0JA== X-Received: by 2002:a05:600c:3b86:b0:434:fe4b:be18 with SMTP id 5b1f17b1804b1-436e26bde73mr278911525e9.18.1736928513174; Wed, 15 Jan 2025 00:08:33 -0800 (PST) Received: from [192.168.0.101] ([90.241.98.187]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74c5bb5sm14382305e9.22.2025.01.15.00.08.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2025 00:08:32 -0800 (PST) Message-ID: <2c62137a-70d5-421e-ae8d-e3bb7c86d0b2@ursulin.net> Date: Wed, 15 Jan 2025 08:08:31 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/4] drm/file: Add fdinfo helper for printing regions with prefix To: =?UTF-8?Q?Adri=C3=A1n_Larumbe?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet Cc: kernel@collabora.com, Tvrtko Ursulin , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250114173406.3060248-1-adrian.larumbe@collabora.com> <20250114173406.3060248-3-adrian.larumbe@collabora.com> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <20250114173406.3060248-3-adrian.larumbe@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/01/2025 17:34, Adrián Larumbe wrote: > This is motivated by the desire of some drivers (eg. Panthor) to print the > size of internal memory regions with a prefix that reflects the driver > name, as suggested in the previous documentation commit. > > That means adding a new argument to print_size and making it available for > DRM users. > > Signed-off-by: Adrián Larumbe > Cc: Tvrtko Ursulin > --- > drivers/gpu/drm/drm_file.c | 27 +++++++++++++++++++-------- > include/drm/drm_file.h | 5 +++++ > 2 files changed, 24 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c > index cb5f22f5bbb6..f584abcd13cb 100644 > --- a/drivers/gpu/drm/drm_file.c > +++ b/drivers/gpu/drm/drm_file.c > @@ -830,8 +830,12 @@ void drm_send_event(struct drm_device *dev, struct drm_pending_event *e) > } > EXPORT_SYMBOL(drm_send_event); > > -static void print_size(struct drm_printer *p, const char *stat, > - const char *region, u64 sz) > + > +void drm_fdinfo_print_size(struct drm_printer *p, > + const char *prefix, > + const char *stat, > + const char *region, > + u64 sz) > { > const char *units[] = {"", " KiB", " MiB"}; > unsigned u; > @@ -842,8 +846,10 @@ static void print_size(struct drm_printer *p, const char *stat, > sz = div_u64(sz, SZ_1K); > } > > - drm_printf(p, "drm-%s-%s:\t%llu%s\n", stat, region, sz, units[u]); > + drm_printf(p, "%s-%s-%s:\t%llu%s\n", > + prefix, stat, region, sz, units[u]); > } > +EXPORT_SYMBOL(drm_fdinfo_print_size); > > /** > * drm_print_memory_stats - A helper to print memory stats > @@ -858,15 +864,20 @@ void drm_print_memory_stats(struct drm_printer *p, > enum drm_gem_object_status supported_status, > const char *region) > { > - print_size(p, "total", region, stats->private + stats->shared); > - print_size(p, "shared", region, stats->shared); > - print_size(p, "active", region, stats->active); > + const char *prefix = "drm"; > + > + drm_fdinfo_print_size(p, prefix, "total", region, > + stats->private + stats->shared); > + drm_fdinfo_print_size(p, prefix, "shared", region, stats->shared); > + drm_fdinfo_print_size(p, prefix, "active", region, stats->active); > > if (supported_status & DRM_GEM_OBJECT_RESIDENT) > - print_size(p, "resident", region, stats->resident); > + drm_fdinfo_print_size(p, prefix, "resident", region, > + stats->resident); > > if (supported_status & DRM_GEM_OBJECT_PURGEABLE) > - print_size(p, "purgeable", region, stats->purgeable); > + drm_fdinfo_print_size(p, prefix, "purgeable", region, > + stats->purgeable); > } > EXPORT_SYMBOL(drm_print_memory_stats); > > diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h > index f0ef32e9fa5e..001ae553e8c3 100644 > --- a/include/drm/drm_file.h > +++ b/include/drm/drm_file.h > @@ -494,6 +494,11 @@ struct drm_memory_stats { > > enum drm_gem_object_status; > > +void drm_fdinfo_print_size(struct drm_printer *p, > + const char *prefix, > + const char *stat, > + const char *region, > + u64 sz); > void drm_print_memory_stats(struct drm_printer *p, > const struct drm_memory_stats *stats, > enum drm_gem_object_status supported_status, If I can get away with a sneaky: Reviewed-by: Tvrtko Ursulin Regards, Tvrtko