mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
	andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, richardcochran@gmail.com,
	o.rempel@pengutronix.de
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/4] net: phy: micrel: Add support for lan8842
Date: Sat, 26 Jul 2025 17:23:18 +0530	[thread overview]
Message-ID: <2c681a15-71b0-4514-b0ce-ce6d28c74971@oracle.com> (raw)
In-Reply-To: <20250724200826.2662658-5-horatiu.vultur@microchip.com>



On 7/25/2025 1:38 AM, Horatiu Vultur wrote:
> +static void lan8842_get_phy_stats(struct phy_device *phydev,
> +				  struct ethtool_eth_phy_stats *eth_stats,
> +				  struct ethtool_phy_stats *stats)
> +{
> +	struct lan8842_priv *priv = phydev->priv;
> +
> +	stats->rx_packets = priv->phy_stats.rx_packets;
> +	stats->rx_errors = priv->phy_stats.rx_errors;
> +	stats->tx_packets = priv->phy_stats.tx_packets;
> +	stats->tx_errors = priv->phy_stats.rx_errors;

looks like a copy-paste mistake
stats->tx_errors = priv->phy_stats.tx_errors;

> +}
> +


Thanks,
Alok

  reply	other threads:[~2025-07-26 11:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24 20:08 [PATCH net-next v2 0/4] " Horatiu Vultur
2025-07-24 20:08 ` [PATCH net-next v2 1/4] net: phy: micrel: Start using PHY_ID_MATCH_MODEL Horatiu Vultur
2025-07-24 20:08 ` [PATCH net-next v2 2/4] net: phy: micrel: Introduce lanphy_modify_page_reg Horatiu Vultur
2025-07-24 20:41   ` Russell King (Oracle)
2025-07-25  6:43     ` Horatiu Vultur
2025-07-24 20:08 ` [PATCH net-next v2 3/4] net: phy: micrel: Replace hardcoded pages with defines Horatiu Vultur
2025-07-24 20:45   ` Russell King (Oracle)
2025-07-25  6:48     ` Horatiu Vultur
2025-07-26  6:21       ` Oleksij Rempel
2025-07-28  6:56         ` Horatiu Vultur
2025-07-24 20:08 ` [PATCH net-next v2 4/4] net: phy: micrel: Add support for lan8842 Horatiu Vultur
2025-07-26 11:53   ` ALOK TIWARI [this message]
2025-07-28  6:48     ` Horatiu Vultur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c681a15-71b0-4514-b0ce-ce6d28c74971@oracle.com \
    --to=alok.a.tiwari@oracle.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®