From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753044AbeA0PDR (ORCPT ); Sat, 27 Jan 2018 10:03:17 -0500 Received: from mail.kapsi.fi ([91.232.154.25]:47345 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752996AbeA0PDP (ORCPT ); Sat, 27 Jan 2018 10:03:15 -0500 Subject: Re: [PATCH] firmware: tegra: adjust tested variable To: Julia Lawall , Thierry Reding Cc: kernel-janitors@vger.kernel.org, Jonathan Hunter , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <1517063308-16679-1-git-send-email-Julia.Lawall@lip6.fr> From: Mikko Perttunen Message-ID: <2c6c4a51-93d4-04b6-db53-5ef582db97c8@kapsi.fi> Date: Sat, 27 Jan 2018 17:03:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1517063308-16679-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 84.248.219.42 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Mikko Perttunen On 01/27/2018 04:28 PM, Julia Lawall wrote: > Check the variable that was most recently initialized. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x, y, f, g, e, m; > statement S1,S2,S3,S4; > @@ > > x = f(...); > if (\(<+...x...+>\&e\)) S1 else S2 > ( > x = g(...); > | > m = g(...,&x,...); > | > y = g(...); > *if (e) > S3 else S4 > ) > // > > Signed-off-by: Julia Lawall > > --- > drivers/firmware/tegra/bpmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c > index a7f461f..96362b5 100644 > --- a/drivers/firmware/tegra/bpmp.c > +++ b/drivers/firmware/tegra/bpmp.c > @@ -732,7 +732,7 @@ static int tegra_bpmp_probe(struct platform_device *pdev) > } > > bpmp->rx.virt = gen_pool_dma_alloc(bpmp->rx.pool, 4096, &bpmp->rx.phys); > - if (!bpmp->rx.pool) { > + if (!bpmp->rx.virt) { > dev_err(&pdev->dev, "failed to allocate from RX pool\n"); > err = -ENOMEM; > goto free_tx; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >