From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934737AbdBQQOs (ORCPT ); Fri, 17 Feb 2017 11:14:48 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:33698 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934233AbdBQQOq (ORCPT ); Fri, 17 Feb 2017 11:14:46 -0500 Subject: Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/ To: Geert Uytterhoeven , Jiri Kosina References: <1487345799-1638-1-git-send-email-geert+renesas@glider.be> <1487345799-1638-2-git-send-email-geert+renesas@glider.be> Cc: linux-kernel@vger.kernel.org, Chaoming Li , netdev@vger.kernel.org From: Larry Finger Message-ID: <2c7a3011-3418-35a5-ca2e-88c0188baccf@lwfinger.net> Date: Fri, 17 Feb 2017 10:14:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1487345799-1638-2-git-send-email-geert+renesas@glider.be> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote: > As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky > register acronym, but a simple misspelling of "write". > > Signed-off-by: Geert Uytterhoeven > Cc: Larry Finger > Cc: Chaoming Li > Cc: netdev@vger.kernel.org I'm not sure that it is possible to have a typo in a variable name. That seems to be within an author's prerogative. Nonetheless, the patch is OK other than it was sent to the wrong destination. Patches for this driver should go through linux-wireless@vger.kernel.org. Kalle Valo is the wireless maintainer, but it is not necessary to send to him directly as he usually picks up the patches from Patchwork. Larry > --- > drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c > index 4f83eee1ff75bc81..546f085afb8f42fa 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c > @@ -1135,13 +1135,13 @@ static u8 _rtl8821ae_dbi_read(struct rtl_priv *rtlpriv, u16 addr) > static void _rtl8821ae_dbi_write(struct rtl_priv *rtlpriv, u16 addr, u8 data) > { > u8 tmp = 0, count = 0; > - u16 wrtie_addr, remainder = addr % 4; > + u16 write_addr, remainder = addr % 4; > > - wrtie_addr = REG_DBI_WDATA + remainder; > - rtl_write_byte(rtlpriv, wrtie_addr, data); > + write_addr = REG_DBI_WDATA + remainder; > + rtl_write_byte(rtlpriv, write_addr, data); > > - wrtie_addr = (addr & 0xfffc) | (BIT(0) << (remainder + 12)); > - rtl_write_word(rtlpriv, REG_DBI_ADDR, wrtie_addr); > + write_addr = (addr & 0xfffc) | (BIT(0) << (remainder + 12)); > + rtl_write_word(rtlpriv, REG_DBI_ADDR, write_addr); > > rtl_write_byte(rtlpriv, REG_DBI_FLAG, 0x1); > >