mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Hyun-Uk Son <hyunuk.son@irondevice.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Ki-Seok Jo <kiseok.jo@irondevice.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] ASoC: codecs: Add driver for Iron Device MA5311
Date: Thu, 12 Nov 2026 19:37:40 +0000	[thread overview]
Message-ID: <2c7d503c-935b-4408-a5b6-bfdf5ba86933@sirena.org.uk> (raw)
In-Reply-To: <SE2P216MB24238E5F5EEA95FCEABCDAF4FF702@SE2P216MB2423.KORP216.PROD.OUTLOOK.COM>

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

On Thu, Nov 12, 2026 at 12:40:57AM +0000, Hyun-Uk Son wrote:

> > They rarely are, but they tend to be safe and what is suitable for
> > practical use will vary depending on the system.  A gain that makes sense
> > for a line output will be unsuitable for headphones, and vice versa.
> > There are a few things, like zero cross for example, which are pretty much
> > universally sensible and we do change those but for things that are likely
> > to vary with use case we just go with what's in the hardware since that
> > gives us consistency without us making decisions that might favour some
> > users over others.

> I'd like to provide some additional context regarding the rationale behind
> the initialization values defined in reg_defaults.

> The purpose of this initialization is to configure the data path and output 
> format for practical use, rather than to change sensitive parameters such as
> speaker volume, ADC gain, or PGA gain.

The trouble is that these parameters tend to be both sensitive and
platform specific - they'll depend on plastics, or the components in a
given system.

> The values of these parameters in reg_defaults match the hardware factory defaults.

Right, those are what the driver should nromally use.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-11-12 19:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27  9:32 [PATCH v2 0/2] ASoC: Add Iron Device MA5311 support Hyunuk Son
2026-10-27  9:32 ` [PATCH v2 1/2] ASoC: dt-bindings: Add Iron Device MA5311 Hyunuk Son
2026-10-28 12:26   ` Krzysztof Kozlowski
2026-10-27  9:32 ` [PATCH v2 2/2] ASoC: codecs: Add driver for " Hyunuk Son
2026-10-28 11:25   ` Mark Brown
2026-11-10  8:41     ` Hyun-Uk Son
2026-11-10 13:50       ` Mark Brown
2026-11-12  0:40         ` Hyun-Uk Son
2026-11-12 19:37           ` Mark Brown [this message]
2026-11-16  4:57             ` Hyun-Uk Son
2026-11-16 20:44               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c7d503c-935b-4408-a5b6-bfdf5ba86933@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hyunuk.son@irondevice.com \
    --cc=kiseok.jo@irondevice.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®