From: Michael Straube <straube.linux@gmail.com>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH 0/7] staging: r8188eu: odm cleanups
Date: Fri, 15 Oct 2021 20:19:45 +0200 [thread overview]
Message-ID: <2c826db6-dab1-2135-14b1-d9fda25951d9@gmail.com> (raw)
In-Reply-To: <YWnDVkwcnVEEoxm4@equinox>
On 10/15/21 20:07, Phillip Potter wrote:
> On Fri, Oct 15, 2021 at 06:35:00PM +0200, Michael Straube wrote:
>> This series removes:
>> - empty / unused functions from odm.c
>> - two never set / unused fields from odm_dm_struct
>> - the function ODM_CmnInfoPtrArrayHook()
>>
>> Tested on x86_64 with Inter-Tech DMG-02.
>>
>> Michael Straube (7):
>> staging: r8188eu: remove empty functions from odm.c
>> staging: r8188eu: remove ODM_SingleDualAntennaDefaultSetting()
>> staging: r8188eu: remove GetPSDData()
>> staging: r8188eu: remove ODM_AntselStatistics_88C()
>> staging: r8188eu: pBandType is never set
>> staging: r8188eu: pMacPhyMode is not used
>> staging: r8188eu: remove ODM_CmnInfoPtrArrayHook()
>>
>> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +-
>> drivers/staging/r8188eu/hal/odm.c | 144 ------------------
>> drivers/staging/r8188eu/hal/odm_HWConfig.c | 7 +-
>> drivers/staging/r8188eu/hal/odm_interface.c | 5 -
>> drivers/staging/r8188eu/hal/rtl8188e_dm.c | 2 +-
>> .../staging/r8188eu/hal/rtl8188e_hal_init.c | 5 +-
>> drivers/staging/r8188eu/include/odm.h | 38 -----
>> .../staging/r8188eu/include/odm_interface.h | 2 -
>> drivers/staging/r8188eu/include/odm_precomp.h | 2 -
>> 9 files changed, 6 insertions(+), 201 deletions(-)
>>
>> --
>> 2.33.0
>>
>
> Dear Michael,
>
> Looks good to me. Built and tested on my USB-N10 Nano, works well. Many
> thanks.
>
> For whole series:
> Acked-by: Phillip Potter <phil@philpotter.co.uk>
>
> Regards,
> Phil
>
Thank you for testing and your ack Phillip.
Regards,
Michael
prev parent reply other threads:[~2021-10-15 18:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 16:35 Michael Straube
2021-10-15 16:35 ` [PATCH 1/7] staging: r8188eu: remove empty functions from odm.c Michael Straube
2021-10-16 9:29 ` Martin Kaiser
2021-10-16 10:08 ` Michael Straube
2021-10-15 16:35 ` [PATCH 2/7] staging: r8188eu: remove ODM_SingleDualAntennaDefaultSetting() Michael Straube
2021-10-16 9:32 ` Martin Kaiser
2021-10-15 16:35 ` [PATCH 3/7] staging: r8188eu: remove GetPSDData() Michael Straube
2021-10-16 9:36 ` Martin Kaiser
2021-10-15 16:35 ` [PATCH 4/7] staging: r8188eu: remove ODM_AntselStatistics_88C() Michael Straube
2021-10-16 9:43 ` Martin Kaiser
2021-10-15 16:35 ` [PATCH 5/7] staging: r8188eu: pBandType is never set Michael Straube
2021-10-16 9:44 ` Martin Kaiser
2021-10-15 16:35 ` [PATCH 6/7] staging: r8188eu: pMacPhyMode is not used Michael Straube
2021-10-16 9:45 ` Martin Kaiser
2021-10-15 16:35 ` [PATCH 7/7] staging: r8188eu: remove ODM_CmnInfoPtrArrayHook() Michael Straube
2021-10-16 9:56 ` Martin Kaiser
2021-10-15 18:07 ` [PATCH 0/7] staging: r8188eu: odm cleanups Phillip Potter
2021-10-15 18:19 ` Michael Straube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c826db6-dab1-2135-14b1-d9fda25951d9@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®