From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14EE9C43217 for ; Tue, 18 Oct 2022 07:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbiJRHbE (ORCPT ); Tue, 18 Oct 2022 03:31:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbiJRHbA (ORCPT ); Tue, 18 Oct 2022 03:31:00 -0400 Received: from mail.3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 798F03C8CE; Tue, 18 Oct 2022 00:30:58 -0700 (PDT) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 722261D23; Tue, 18 Oct 2022 09:30:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1666078255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WzMYkZQlDVdQITrjYiTqieDryDU5cl4+R2pxvS45MzU=; b=F7I4Sfccmz6nIRGL9Kq3UnF88c8QEloNI2fTBYVEv+6xzZPBw7/NAnkNk7mD7b3AJRXiym cnr5RYGD6F6pH+BbgONYeNraclMyg6kOOQvW9d6zr4vHTmXAM9ZLPFUOvjnvxBdx//kxky sYu+gCiqQtDqRhfVu2PEkw8HiaYn1Jckmp8uSpS6QQWZXnFSCuVj2mv5rDa/XZsLtvsEmX KfpwEYMmdwEv7Di4fDSeOSjGugFJ+zLDwsMdowAw2nV/3v7bU/ramcxqgw2di0aFTL0UNm DiV9sZfoU+YTQbcn3sO6+w2dtpVP15m9p9cF0H5elZBGiL9HNzEMhygXc4zkVQ== MIME-Version: 1.0 Date: Tue, 18 Oct 2022 09:30:55 +0200 From: Michael Walle To: Horatiu Vultur Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, andy.shevchenko@gmail.com, UNGLinuxDriver@microchip.com Subject: Re: [PATCH] pinctrl: ocelot: Fix incorrect trigger of the interrupt. In-Reply-To: <20221018070959.1322606-1-horatiu.vultur@microchip.com> References: <20221018070959.1322606-1-horatiu.vultur@microchip.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <2c88f0a4955202091bbdf6c5db4f18cf@walle.cc> X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-10-18 09:09, schrieb Horatiu Vultur: > The interrupt controller can detect only link changes. So in case an > external device generated a level based interrupt, then the interrupt > controller detected correctly the first edge. But the problem was that > the interrupt controller was detecting also the edge when the interrupt > was cleared. So it would generate another interrupt. > The fix for this is to clear the second interrupt but still check the > interrupt line status. > > Fixes: c297561bc98a ("pinctrl: ocelot: Fix interrupt controller") > Signed-off-by: Horatiu Vultur Tested-by: Michael Walle -michael