From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C8ABC7EE22 for ; Mon, 15 May 2023 14:57:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241364AbjEOO46 (ORCPT ); Mon, 15 May 2023 10:56:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238199AbjEOO4w (ORCPT ); Mon, 15 May 2023 10:56:52 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B73DB2128 for ; Mon, 15 May 2023 07:56:28 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f41dceb9d4so97352385e9.1 for ; Mon, 15 May 2023 07:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684162587; x=1686754587; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UKdQljelele47fGhlCDtFyRrYOqvsvKHSxZYQmiGNRs=; b=Hn29fxuNMyby+YmQYnHiOhftbcHGmxehKzHtB7YzQD7v/sceIbhluaRt8wSdlJJJWW rYxh0eyDlDa3kfYLGhU0UbUOBzmTKnmuDJaUeb6gs8Cg3XSI32vksTKtxZ/DPf+Wv/jz 6g7f33Af+mM8iEK5njYrtDiH+fb///gfth7NgjgLVYobaoY6p/ugrq3V+8CUQOLiJ4jm o0ej63/zA/PuxrUudmBd2t5GWqb5iX2lr2pfM36Mm3DYvZXLV+XD6oeihMT07MIw1tct 7ztFaxRSccEK503l2NlgWVizWJ0tgN66uJnr011LOYo/QivoD2AH9G9y2QVT+33V7JP2 /vzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684162587; x=1686754587; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UKdQljelele47fGhlCDtFyRrYOqvsvKHSxZYQmiGNRs=; b=adKhLkSmpKVpBxgQQWP6lEHJVLkswnz6L1kyxGT8ZedvzyE+UWrmSnJmiftVgmnX0j b3UAt8oEFFH097iQToFeSbn8SdekwtUjSBDKeTN59/XalbTjhPMxRqLVBkEUUi/xNfNL al7QGmjKfL151MW9RYCq+RhPVfrhbkNtYNBebZw2HYzwgGZyxj9Iyr+DdKaX4dGlOS0g TXXceu1C4lBAc7lmbG92giluNubuaX4gUA2/CywlXGMi9L0jAGSBKkILU8lbfv/4w8xU e4q6iendzP8QljMofTCWrqSQTZx76bMUY7g2w0teFJlnqx4DqXPQYEhtkkGRDXShQxB8 w55w== X-Gm-Message-State: AC+VfDwmG0xAFuWUAh9OF73LJSdfE2Ro9vmRzsbxRh5gKox0l4Omme7N r9mm4/wNm1XS6mMlL9qrJD+I4g== X-Google-Smtp-Source: ACHHUZ6GgrO8jcM5d3saW4J4IAVcPfC4QhJI1fiDa7hJz6KmjkRa3o1EhVVQMxnA/Z2etk4iReXBIQ== X-Received: by 2002:a5d:6086:0:b0:306:2671:7cad with SMTP id w6-20020a5d6086000000b0030626717cadmr27241216wrt.55.1684162587152; Mon, 15 May 2023 07:56:27 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id j17-20020a5d6051000000b002e5ff05765esm32745232wrt.73.2023.05.15.07.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 07:56:25 -0700 (PDT) Date: Mon, 15 May 2023 17:56:21 +0300 From: Dan Carpenter To: wuych Cc: dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] net: liquidio: lio_core: Remove unnecessary (void*) conversions Message-ID: <2c8a5e3f-965e-422a-b347-741bcc7d33ce@kili.mountain> References: <20230515084906.61491-1-yunchuan@nfschina.com> <61522ef5-7c7a-4bee-bcf6-6905a3290e76@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61522ef5-7c7a-4bee-bcf6-6905a3290e76@kili.mountain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote: > On Mon, May 15, 2023 at 04:49:06PM +0800, wuych wrote: > > Pointer variables of void * type do not require type cast. > > > > Signed-off-by: wuych > > --- > > drivers/net/ethernet/cavium/liquidio/lio_core.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c > > index 882b2be06ea0..10d9dab26c92 100644 > > --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c > > +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c > > @@ -904,8 +904,7 @@ static > > int liquidio_schedule_msix_droq_pkt_handler(struct octeon_droq *droq, u64 ret) > > { > > struct octeon_device *oct = droq->oct_dev; > > - struct octeon_device_priv *oct_priv = > > - (struct octeon_device_priv *)oct->priv; > > + struct octeon_device_priv *oct_priv = oct->priv; > > > > Networking code needs to be in Reverse Christmas Tree order. Longest > lines first. This code wasn't really in Reverse Christmas Tree order > to begine with but now it's more obvious. Oh, duh. This obviously can't be reversed because it depends on the first declaration. Sorry for the noise. regards, dan carpenter