From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Zhenhua Huang <quic_zhenhuah@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com,
quic_tingweiz@quicinc.com
Subject: Re: [PATCH v1 3/5] soc: qcom: memory_dump: Add memory dump driver
Date: Mon, 23 Oct 2023 14:53:48 +0200 [thread overview]
Message-ID: <2c8cc463-84dd-4f28-812d-f5eea922daef@linaro.org> (raw)
In-Reply-To: <1a5b2381-8987-2f92-d018-29fdbc23b826@quicinc.com>
On 23/10/2023 14:19, Zhenhua Huang wrote:
>
>
> On 2023/10/23 19:46, Krzysztof Kozlowski wrote:
>> On 23/10/2023 13:43, Zhenhua Huang wrote:
>>>>> +
>>>>> + mem_dump_apply_offset(&dump_vaddr, &phys_addr,
>>>>> + size + QCOM_DUMP_DATA_SIZE);
>>>>> + if (phys_addr > phys_end_addr) {
>>>>> + dev_err_probe(dev, -ENOMEM, "Exceeding allocated region\n");
>>>>
>>>> ENOMEM? Does not look right then.
>>>
>>> ENOMEM means the memory allocated not enough? any suggestion? Thanks.
>>
>> The error code is okay, but we rarely need to print error messages for
>> memory allocation failures. Core prints it already.
>
> It's not same as below case. Allocation is successful here, while the
> driver used more than allocated size.
$ man errno
ENOMEM means: Not enough space/cannot allocate memory
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-23 12:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 9:20 [PATCH v1 0/5] soc/arm64: qcom: add initial version of memory dump Zhenhua Huang
2023-10-23 9:20 ` [PATCH v1 1/5] dt-bindings: soc: qcom: Add memory_dump driver bindings Zhenhua Huang
2023-10-23 9:27 ` Krzysztof Kozlowski
2023-10-23 11:54 ` Zhenhua Huang
2023-10-23 12:52 ` Krzysztof Kozlowski
2023-10-24 10:57 ` Zhenhua Huang
2023-10-24 13:55 ` Krzysztof Kozlowski
2023-10-26 21:01 ` Elliot Berman
2023-10-23 17:40 ` Rob Herring
2023-10-23 9:20 ` [PATCH v1 2/5] dt-bindings: sram: qcom,imem: document sm8250 Zhenhua Huang
2023-10-23 9:27 ` Krzysztof Kozlowski
2023-10-23 17:40 ` Rob Herring
2023-10-24 11:07 ` Zhenhua Huang
2023-10-23 9:20 ` [PATCH v1 3/5] soc: qcom: memory_dump: Add memory dump driver Zhenhua Huang
2023-10-23 9:31 ` Krzysztof Kozlowski
2023-10-23 11:43 ` Zhenhua Huang
2023-10-23 11:46 ` Krzysztof Kozlowski
2023-10-23 12:19 ` Zhenhua Huang
2023-10-23 12:53 ` Krzysztof Kozlowski [this message]
2023-10-24 10:57 ` Zhenhua Huang
2023-10-24 13:58 ` Krzysztof Kozlowski
2023-10-23 13:56 ` Konrad Dybcio
2023-10-24 7:36 ` Zhenhua Huang
2023-10-26 18:58 ` kernel test robot
2023-10-23 9:20 ` [PATCH v1 4/5] arm64: defconfig: enable Qcom Memory Dump driver Zhenhua Huang
2023-10-23 9:32 ` Krzysztof Kozlowski
2023-10-23 11:43 ` Zhenhua Huang
2023-10-23 11:47 ` Krzysztof Kozlowski
2023-10-23 12:19 ` Zhenhua Huang
2023-10-23 9:20 ` [PATCH v1 5/5] arm64: dts: qcom: sm8250: Add memory dump node Zhenhua Huang
2023-10-23 9:33 ` Krzysztof Kozlowski
2023-10-23 9:25 ` [PATCH v1 0/5] soc/arm64: qcom: add initial version of memory dump Krzysztof Kozlowski
2023-10-23 12:18 ` Zhenhua Huang
2023-10-23 12:54 ` Krzysztof Kozlowski
2023-10-23 13:50 ` Konrad Dybcio
2023-10-24 10:10 ` Zhenhua Huang
2023-10-24 14:25 ` Jeff Johnson
2023-10-23 14:31 ` Caleb Connolly
2023-10-24 9:53 ` Zhenhua Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c8cc463-84dd-4f28-812d-f5eea922daef@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_zhenhuah@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®