mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Subject: [PATCHv3] fat: don't use custom hex_to_bin()
Date: Thu, 29 Sep 2011 16:15:40 +0300	[thread overview]
Message-ID: <2c8e77b881028c0a11f3cfef4ebb231c3236d60c.1317302092.git.andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <87bou5inkk.fsf@devron.myhome.or.jp>

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
 fs/fat/namei_vfat.c |   37 +++++++++++++++----------------------
 1 files changed, 15 insertions(+), 22 deletions(-)

diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
index bb3f29c..7deb604 100644
--- a/fs/fat/namei_vfat.c
+++ b/fs/fat/namei_vfat.c
@@ -21,6 +21,8 @@
 #include <linux/slab.h>
 #include <linux/buffer_head.h>
 #include <linux/namei.h>
+#include <linux/kernel.h>
+
 #include "fat.h"
 
 /*
@@ -505,10 +507,8 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname,
 	     struct nls_table *nls)
 {
 	const unsigned char *ip;
-	unsigned char nc;
 	unsigned char *op;
-	unsigned int ec;
-	int i, k, fill;
+	int i, rc, fill;
 	int charlen;
 
 	if (utf8) {
@@ -528,26 +528,19 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname,
 				if (escape && (*ip == ':')) {
 					if (i > len - 5)
 						return -EINVAL;
-					ec = 0;
-					for (k = 1; k < 5; k++) {
-						nc = ip[k];
-						ec <<= 4;
-						if (nc >= '0' && nc <= '9') {
-							ec |= nc - '0';
-							continue;
-						}
-						if (nc >= 'a' && nc <= 'f') {
-							ec |= nc - ('a' - 10);
-							continue;
-						}
-						if (nc >= 'A' && nc <= 'F') {
-							ec |= nc - ('A' - 10);
-							continue;
-						}
+
+					/* The ip contains 2 bytes in little
+					 * endian format. We need to get them
+					 * in native endian. */
+
+					rc = hex2bin(op++, ip + 3, 1);
+					if (rc < 0)
+						return -EINVAL;
+
+					rc = hex2bin(op++, ip + 1, 1);
+					if (rc < 0)
 						return -EINVAL;
-					}
-					*op++ = ec & 0xFF;
-					*op++ = ec >> 8;
+
 					ip += 5;
 					i += 5;
 				} else {
-- 
1.7.6.3


  parent reply	other threads:[~2011-09-29 13:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 11:32 [PATCH] alsa: 6fire: " Andy Shevchenko
2011-09-23 11:32 ` [PATCH] fat: " Andy Shevchenko
2011-09-23 12:05   ` Denys Vlasenko
2011-09-23 12:11     ` Andy Shevchenko
2011-09-27 11:48     ` [PATCHv2] " Andy Shevchenko
2011-09-27 17:19       ` OGAWA Hirofumi
2011-09-27 17:52         ` Andy Shevchenko
2011-09-27 18:06         ` Andy Shevchenko
2011-09-27 23:15           ` OGAWA Hirofumi
2011-09-29 13:07             ` Andy Shevchenko
2011-09-29 14:43               ` OGAWA Hirofumi
2011-09-29 14:54                 ` Andy Shevchenko
2011-09-29 15:19                   ` OGAWA Hirofumi
2011-09-29 15:10                 ` [PATCHv4] " Andy Shevchenko
2011-09-29 15:37                   ` Joe Perches
2011-09-29 18:27                     ` OGAWA Hirofumi
2011-09-29 18:41                       ` Joe Perches
2011-09-29 19:35                         ` OGAWA Hirofumi
2011-09-29 13:15             ` Andy Shevchenko [this message]
2011-09-29 14:51               ` [PATCHv3] " OGAWA Hirofumi
2011-09-23 13:22 ` [PATCH] alsa: 6fire: " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c8e77b881028c0a11f3cfef4ebb231c3236d60c.1317302092.git.andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome