From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BABA113ACC for ; Fri, 1 Mar 2024 06:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709275766; cv=none; b=qsFkWZQZ0LFJk2YPxvdv143grMjifv9nlAQlVvE8wJouPMQ3wqRBua9YvCFypW4b2nAknIalE2y+OxDKUino9+RviXEFzHJjOhrTyGfTBMKM9igK5nlVQW+E90slSlWT9dQsw5ds/MABtcK+VfTmK9fW2sEijuR9OAkYXcN14Uw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709275766; c=relaxed/simple; bh=k/kS463kjbnO2EiOqnRWTGCiGgnNsrPfzZb0hyDuUGc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cQ7gyKcIOGKHw1o1FA4qPovwB3R7SDb81dPZcx/RKhEcCzLjplq9GoR7s4dWxfwIJ1ZvfMtUnmDKcPmGkj1oDd2VraNDNRxN1xmF5lgtkqKAVn9g+4HFVHHGOZJ4ybiG9aXvFNTeoSZrh2XqHVRpU8XDz/MSZpNQ5NErJS3PXYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ht0hyN+D; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ht0hyN+D" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a44665605f3so140928066b.2 for ; Thu, 29 Feb 2024 22:49:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709275763; x=1709880563; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e9yQxgEwA+V3hfeUspmNH6wxUAFH4Nw5gJjNuDJi1E8=; b=Ht0hyN+DK6DnZBgBUr248u3B1Ctrw/o8tffPHqS/tJJJC3yD4IlXq7GBVSs5LfZhMi 9dKKW0FfwVo8XfyCtaMdrHiiEGDP8s4CEJpqfDNmFCmPMW7sEXcPsJwSsMEQ8e6+SLqn 0HLrPyisxVfcLJWwGbN/OHPjrE1b5VGM8X5pZ41ysS2Br/f2ufg6hkS2nePxku6SbYK2 vef7N0/MYv5D0cfgAm8t6QP+40V5OO+NgmaEjoinNwE6DVfmR20NwbvQJiKMj+9qkXxV z8l0eQzDbuxQvHPgYrlY/uUWbhIgrYH1RPoKRXAGDAdzaoqg27Vz8i9fBIHtCBvxVhx8 5Mug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709275763; x=1709880563; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e9yQxgEwA+V3hfeUspmNH6wxUAFH4Nw5gJjNuDJi1E8=; b=cQhAhOHbRFJHWIfYc5fDVmU4/5Wls2otzT0Qi+fDH1+EqkhrynYzvDhAlti5QsMLmZ IcaZv8Psya08rT0fmjMnSHGe15iIwEy2zTXtHk412o1vXANgjfYa3jaZV6x3qj30XXlF vEQlTbKE89L1uphuI2S0DM37CM5XGGZBn2qoMI33Lzh0wrjh7tQymKuGHX394aHflKFJ YI+/mZ/n5yeE5S6eLdG0koiFBtdINmYELwFjNt8dduDVurIBVPdxPf/wj+b8SQZnEL9Y YhYw4qTt62X+5R8FcVCfVDjW56NpMMqlYmwhNJdbn1a4/13+FPT4boF6Kfc3Xyb9PtIW 5erQ== X-Forwarded-Encrypted: i=1; AJvYcCXwPrbqnbvxWPzvQA7NBoiaDWw64qZvG6sLYra5cukQTRezrtxUhVmb8kspdVDlTHuaiBaibFrvmSRpc8bf2UQHN8lmxZ9hjQLm155g X-Gm-Message-State: AOJu0YxdMY0XmaH5oRSzGg6TiMH8fkZH6xrzl83gi3ykRR9l5Hg4diJ+ VCjmW0hl4oF1mlfisTs/c7Xp1ZICDtYccs/B8SL0ENGoOBNVjUJEtr9KsSu1+Zg= X-Google-Smtp-Source: AGHT+IEsiEo1/lXUDhzncXqx01aE4KwhtuUJQeEFtE8Z8ZrWHZ0A67cTFstZPQLvc+CFLC1ZYyi6Uw== X-Received: by 2002:a17:907:367:b0:a43:f020:57ed with SMTP id rs7-20020a170907036700b00a43f02057edmr518134ejb.73.1709275763099; Thu, 29 Feb 2024 22:49:23 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id bq20-20020a170906d0d400b00a3cfe376116sm1399456ejb.57.2024.02.29.22.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 22:49:22 -0800 (PST) Message-ID: <2c90731b-709a-4baa-963a-fbd35372fb3b@linaro.org> Date: Fri, 1 Mar 2024 07:49:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 4/9] dt-bindings: net: convert hisi-femac.txt to YAML Content-Language: en-US To: forbidden405@outlook.com, Yisen Zhuang , Salil Mehta , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20240301-net-v7-0-45823597d4d4@outlook.com> <20240301-net-v7-4-45823597d4d4@outlook.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240301-net-v7-4-45823597d4d4@outlook.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01/03/2024 04:35, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen > > Convert the old text binding to new YAML. > > While at it, make some changes to the binding: > - The version numbers are not documented publicly. The version also does > not change programming interface. Remove it until it's really needed. > - A few clocks are missing in old binding file. Add them to match the real > hardware. > > Signed-off-by: Yang Xiwen > --- > .../bindings/net/hisilicon,hisi-femac.yaml | 89 ++++++++++++++++++++++ > .../devicetree/bindings/net/hisilicon-femac.txt | 41 ---------- > 2 files changed, 89 insertions(+), 41 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml > new file mode 100644 > index 000000000000..ba207f2c9ae4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/hisilicon,hisi-femac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Hisilicon Fast Ethernet MAC controller > + > +maintainers: > + - Yang Xiwen > + > +allOf: > + - $ref: ethernet-controller.yaml > + > +properties: > + compatible: > + items: > + - enum: > + - hisilicon,hi3516cv300-femac > + - const: hisilicon,hisi-femac This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof