From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <linus.walleij@linaro.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl
Date: Thu, 7 Dec 2023 15:55:04 +0800 [thread overview]
Message-ID: <2c91c34f-6ee9-4f34-863e-c26b0107f6d3@quicinc.com> (raw)
In-Reply-To: <006c3c39-5266-4177-ae7f-263af5f0821c@linaro.org>
在 12/6/2023 5:04 PM, Krzysztof Kozlowski 写道:
> On 06/12/2023 03:08, Tengfei Fan wrote:
>> Add device tree binding Documentation details for Qualcomm SM4450
>> TLMM device.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>> .../bindings/pinctrl/qcom,sm4450-tlmm.yaml | 151 ++++++++++++++++++
>> 1 file changed, 151 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>
>
> There was no reason to drop my review tag here. You did not explain why
> it had to be dropped and changing indentation on example is for sure not
> the case.
>
> Please read submitting-patches before posting new patches to mailing list.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
I read submitting-patches.rst today. Like you said that I shouldn't drop
your review tag due to change indentation. This is my fault.
Thank you again for your patient reviw and explanation.
submitting-patches.rst:
By offering my Reviewed-by: tag, I state that:
(c) While there may be things that could be improved with this
submission, I believe that it is, at this time, (1) a
worthwhile modification to the kernel, and (2) free of known
issues which would argue against its inclusion.
--
Thx and BRs,
Tengfei Fan
next prev parent reply other threads:[~2023-12-07 7:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 2:08 [PATCH v6 0/2] pinctl: qcom: sm4450: Add SM4450 pinctrl driver Tengfei Fan
2023-12-06 2:08 ` [PATCH v6 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl Tengfei Fan
2023-12-06 9:04 ` Krzysztof Kozlowski
2023-12-07 7:55 ` Tengfei Fan [this message]
2023-12-23 3:06 ` Bjorn Andersson
2023-12-25 6:50 ` Tengfei Fan
2023-12-25 9:37 ` Krzysztof Kozlowski
2023-12-06 2:08 ` [PATCH v6 2/2] pinctrl: qcom: sm4450: dd SM4450 pinctrl driver Tengfei Fan
2023-12-23 2:57 ` Bjorn Andersson
2023-12-06 8:59 ` [PATCH v6 0/2] pinctl: qcom: sm4450: Add " Krzysztof Kozlowski
2023-12-07 7:59 ` Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c91c34f-6ee9-4f34-863e-c26b0107f6d3@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®