From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbdHCACC (ORCPT ); Wed, 2 Aug 2017 20:02:02 -0400 Received: from resqmta-po-07v.sys.comcast.net ([96.114.154.166]:55992 "EHLO resqmta-po-07v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbdHCACA (ORCPT ); Wed, 2 Aug 2017 20:02:00 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH 1/5] test_kmod: make selftest executable To: Andrew Morton , "Luis R. Rodriguez" Cc: Dmitry Torokhov , Kees Cook , Jessica Yu , Rusty Russell , Michal Marek , Petr Mladek , Miroslav Benes , Josh Poimboeuf , "Eric W. Biederman" , Dan Carpenter , Colin Ian King , dcb314@hotmail.com, linux-kselftest@vger.kernel.org, "linux-kernel@vger.kernel.org" , Shuah Khan References: <20170802211450.27928-1-mcgrof@kernel.org> <20170802211450.27928-2-mcgrof@kernel.org> <20170802154349.a4221b87ebb083a83353c270@linux-foundation.org> <20170802164250.6c34cc3128bcd715fe583de3@linux-foundation.org> From: Shuah Khan Message-ID: <2c926769-7e09-f3a8-7b62-8c26f65792a4@kernel.org> Date: Wed, 2 Aug 2017 18:01:57 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170802164250.6c34cc3128bcd715fe583de3@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfEhhmYlftm/Wgj+KvS4jywticEa6yaylkT7JOAakM4BNzNMNvLybow7CjWtlBCe5XL9USVk16s1DhmEKhvLuZK5T4vOjRap88FRLtQDucnqkSUzEAdlg QsmTnc0nwwEJ0VfVQjhNg2c1Co+d6U7haSI2PzhPVtH3ZWzfE3BFKrlFREKGLwFOVQgwEeNx6PqMIcdC1nmmGbH2aEh6MWmImFFOObwQIchR9gmTrAlCnINL V10yj9CXdu2vZc/8Jv1UBgUW0HVusvM/1ZyAsBWZTeqr6EAJO/5O6ni1L+7XTWYYbLWjf0JbodC8ltBoUa2RZlM6ppsXFz2MYdU3O96jp4hJdtpIFohXinRM Y3OC04tf5PmRf0v/VOejC4nTApVll9KM081laO3VvGlLwnH1smnDhPOX+OxRc7JEhxbYq/iMm8ZGJFPfoGlG27YaYreusVX6jZa0AeMiU3P6Z7TfUIqtd0q/ DyIy2WIV4sYnfJ8ZS9qpKco2mwWGB/etnwei7VAubobE2/Ah0r67SE/k7e7H0WvjvTA78f5xeOtsWVyNEyuR7xyjKV2PSwfhkHODs7UdreYf/iwedvmtb17g T8uqoWFcp6WtAH2BHtvrXFGZxyAfWlZwLL0XAX/67GPVRFCEDUDEltD5RhZ06TiqLq3PYqojBsUfR1B+gy/WOLtnid9HqhBjz/233zh8SAqdkg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/2017 05:42 PM, Andrew Morton wrote: > On Wed, 2 Aug 2017 15:55:50 -0700 "Luis R. Rodriguez" wrote: > >> On Wed, Aug 2, 2017 at 3:43 PM, Andrew Morton wrote: >>> On Wed, 2 Aug 2017 14:14:46 -0700 "Luis R. Rodriguez" wrote: >>> >>>> We had just forgotten to do this. >>>> >>>> Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader") >>>> Signed-off-by: Luis R. Rodriguez >>>> --- >>>> tools/testing/selftests/kmod/kmod.sh | 0 >>>> 1 file changed, 0 insertions(+), 0 deletions(-) >>>> mode change 100644 => 100755 tools/testing/selftests/kmod/kmod.sh >>>> >>>> diff --git a/tools/testing/selftests/kmod/kmod.sh b/tools/testing/selftests/kmod/kmod.sh >>>> old mode 100644 >>>> new mode 100755 >>> >>> This is pretty fragile - I'm not sure that patch/diff are capable of >>> communicating a bare chmod. If someone does a "patch -p1 < patch-4.14" >>> or whatever, this change is likely to get lost. >> >> True if using regular diff, if using git, it will catch it though. > > Yeah. I don't think this change will make it through my > maze-of-scripts. Perhaps Shuah can pick it up. Thanks Andrew. I will pick this up. > > Also... > > # find tools/testing/selftests -name "*.sh" -a ! -executable > tools/testing/selftests/rcutorture/configs/rcuperf/ver_functions.sh > tools/testing/selftests/rcutorture/configs/lock/ver_functions.sh > tools/testing/selftests/rcutorture/configs/rcu/ver_functions.sh > tools/testing/selftests/rcutorture/bin/functions.sh > tools/testing/selftests/locking/ww_mutex.sh The above aren't an issue. They aren't included in the selftests/Makefile > tools/testing/selftests/kmod/kmod.sh > tools/testing/selftests/sysctl/sysctl.sh Yeah. sysctl needs to be fixed. Thanks for pointing this out. thanks, -- Shuah