mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jerome Neanne <jneanne@baylibre.com>
To: andy.shevchenko@gmail.com
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Tony Lindgren <tony@atomide.com>, Lee Jones <lee@kernel.org>,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-omap@vger.kernel.org,
	Jonathan Cormier <jcormier@criticallink.com>
Subject: Re: [PATCH v3 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC
Date: Mon, 29 May 2023 17:21:00 +0200	[thread overview]
Message-ID: <2c970ea3-e927-4ea1-f378-a600e834cc9d@baylibre.com> (raw)
In-Reply-To: <ZHD3VtFDYUyy_Std@surfacebook>



On 26/05/2023 20:15, andy.shevchenko@gmail.com wrote:
> ...
> 
> Missing bits.h
> 
>> +#include <linux/gpio/driver.h>
>> +#include <linux/mfd/tps65219.h>
>> +#include <linux/module.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/regmap.h>
>

Thanks for your review.Just to be sure on this particular point:
Your recommendation here it to include explicitly bits.h.

I can see BIT_MASK(n) defined in linux/bits.h
BIT(n) is defined in vdso/bits.h
 From what I can see, BIT(n) is broadly used across kernel but 
BIT_MASK(n) sounds to be the Linux strict way...

In current version I'm using BIT(n) macro not BIT_MASK(n).
Do you recommend to replace every BIT(n) currently used with BIT_MASK(n)?
Sorry for asking dumb questions. Just trying to make sure I 
correctly/fully understand your feedback... And do it all right for the 
next iteration.

Regards,
Jerome.

  reply	other threads:[~2023-05-29 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26 15:06 [PATCH v3 0/2] Add support for TI TPS65219 PMIC GPIO interface Jerome Neanne
2023-05-26 15:06 ` [PATCH v3 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC Jerome Neanne
2023-05-26 18:15   ` andy.shevchenko
2023-05-29 15:21     ` jerome Neanne [this message]
2023-05-29 18:17       ` Andy Shevchenko
2023-05-26 15:06 ` [PATCH v3 2/2] mfd: tps65219: Add gpio cell instance Jerome Neanne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c970ea3-e927-4ea1-f378-a600e834cc9d@baylibre.com \
    --to=jneanne@baylibre.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=jcormier@criticallink.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®