From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
John Cox <john.cox@raspberrypi.com>,
Dom Cobley <dom@raspberrypi.com>,
review list <kernel-list@raspberrypi.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: John Cox <jc@kynesim.co.uk>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/5] arm: dts: bcm2711-rpi: Add HEVC decoder node
Date: Fri, 25 Apr 2025 09:56:42 +0200 [thread overview]
Message-ID: <2c97884c-7a29-4250-a05f-0860ebef49f6@kernel.org> (raw)
In-Reply-To: <20250423-media-rpi-hevc-dec-v3-5-8fd3fad1d6fb@raspberrypi.com>
On 23/04/2025 19:20, Dave Stevenson wrote:
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711.dtsi b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> index c06d9f5e53c8..bdb80f3611ca 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> @@ -617,6 +617,15 @@ xhci: usb@7e9c0000 {
> status = "disabled";
> };
>
> + hevc_dec: codec@7eb10000 {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.
> + compatible = "brcm,bcm2711-hevc-dec", "raspberrypi,hevc-dec";
> + reg = <0x0 0x7eb00000 0x10000>, /* HEVC */
> + <0x0 0x7eb10000 0x1000>; /* INTC */
Best regards,
Krzysztof
prev parent reply other threads:[~2025-04-25 7:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 17:20 [PATCH v3 0/5] Raspberry Pi HEVC decoder driver Dave Stevenson
2025-04-23 17:20 ` [PATCH v3 1/5] docs: uapi: media: Document Raspberry Pi NV12 column format Dave Stevenson
2025-05-24 0:30 ` Nicolas Dufresne
2025-04-23 17:20 ` [PATCH v3 2/5] media: ioctl: Add pixel formats NV12MT_COL128 and NV12MT_10_COL128 Dave Stevenson
2025-04-23 17:20 ` [PATCH v3 3/5] media: dt-bindings: media: Add binding for the Raspberry Pi HEVC decoder Dave Stevenson
2025-04-25 7:53 ` Krzysztof Kozlowski
2025-04-28 10:03 ` Dave Stevenson
2025-04-28 17:56 ` Krzysztof Kozlowski
2025-06-23 17:54 ` Dave Stevenson
2025-06-24 6:01 ` Krzysztof Kozlowski
2025-04-25 7:54 ` Krzysztof Kozlowski
2025-04-23 17:20 ` [PATCH v3 4/5] media: platform: Add Raspberry Pi HEVC decoder driver Dave Stevenson
2025-05-24 2:16 ` Nicolas Dufresne
2025-05-27 12:51 ` John Cox
2025-05-30 14:16 ` Nicolas Dufresne
2025-04-23 17:20 ` [PATCH v3 5/5] arm: dts: bcm2711-rpi: Add HEVC decoder node Dave Stevenson
2025-04-25 7:56 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c97884c-7a29-4250-a05f-0860ebef49f6@kernel.org \
--to=krzk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dom@raspberrypi.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=florian.fainelli@broadcom.com \
--cc=jc@kynesim.co.uk \
--cc=john.cox@raspberrypi.com \
--cc=kernel-list@raspberrypi.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®