From: Helge Deller <deller@gmx.de>
To: "Rahman Mahmutović" <mahmutovicrahman5@gmail.com>,
linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: sunxvr2500: replace printk with device-aware logging functions
Date: Tue, 19 May 2026 09:40:14 +0200 [thread overview]
Message-ID: <2ca734dc-5318-4aa2-8436-217dcdd8cc61@gmx.de> (raw)
In-Reply-To: <20260509135759.1391-1-mahmutovicrahman5@gmail.com>
On 5/9/26 15:57, Rahman Mahmutović wrote:
> Replace all printk() calls with appropriate device-aware logging
> functions to properly associate log messages with the PCI device.
>
> - Use pci_err() for errors where struct pci_dev is available
> - Use pci_info() for info messages where struct pci_dev is available
> - Use dev_err() for errors where only struct fb_info is available
>
> Remove redundant 's3d:' prefix and pci_name() calls as device-aware
> functions include device identification automatically.
>
> Assisted-by: Claude:claude-sonnet-4-6
> Signed-off-by: Rahman Mahmutović <mahmutovicrahman5@gmail.com>
> ---
> drivers/video/fbdev/sunxvr2500.c | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
applied.
Thanks!
Helge
prev parent reply other threads:[~2026-05-19 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 13:57 Rahman Mahmutović
2026-05-18 16:15 ` Rahman Mahmutović
2026-05-19 7:40 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ca734dc-5318-4aa2-8436-217dcdd8cc61@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahmutovicrahman5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®