mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tanhuazhong <tanhuazhong@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
	<linuxarm@huawei.com>, <shenjian15@huawei.com>
Subject: Re: [PATCH net] net: hns3: add rmb() for rx description
Date: Tue, 5 Mar 2019 09:04:07 +0800	[thread overview]
Message-ID: <2ca7e5e9-2d6a-4a76-8a33-eab28679a957@huawei.com> (raw)
In-Reply-To: <20190303.211518.1265133811120263144.davem@davemloft.net>



On 2019/3/4 13:15, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@huawei.com>
> Date: Sat, 2 Mar 2019 16:49:30 +0800
> 
>> From: Jian Shen <shenjian15@huawei.com>
>>
>> HW can not guarantee complete write desc->rx.size, even though
>> HNS3_RXD_VLD_B has been set. Driver needs to add rmb() instruction
>> to make sure desc->rx.size is always valid.
>>
>> Fixes: e55970950556 ("net: hns3: Add handling of GRO Pkts not fully RX'ed in NAPI poll")
>> Signed-off-by: Jian Shen <shenjian15@huawei.com>
>> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
> 
> dma_rmb() is more appropriate here and more efficient.
> 

Thanks, will send V2  to fix it.

> .
> 


      reply	other threads:[~2019-03-05  1:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-02  8:49 Huazhong Tan
2019-03-04  5:15 ` David Miller
2019-03-05  1:04   ` tanhuazhong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ca7e5e9-2d6a-4a76-8a33-eab28679a957@huawei.com \
    --to=tanhuazhong@huawei.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=shenjian15@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®