From: Shivam Kalra <shivamkalra98@zohomail.in>
To: "Alex Hung" <alex.hung@amd.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <siqueira@igalia.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Hamza Mahfooz" <hamzamahfooz@linux.microsoft.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
David Weber <weber.aulendorf@gmail.com>,
Wayne Lin <Wayne.Lin@amd.com>
Subject: Re: [PATCH] drm/amd/display: use atomic commit for panel power savings
Date: Tue, 10 Nov 2026 01:45:35 +0530 [thread overview]
Message-ID: <2caf9f85-8d5d-482a-8479-dd682cbf96fa@zohomail.in> (raw)
In-Reply-To: <7aec0ed4-1a4d-446b-8971-580770e3de09@amd.com>
On 06/11/26 03:15, Alex Hung wrote:
>
>
> On 10/30/26 15:58, Shivam Kalra via B4 Relay wrote:
>
> Hi Shivam,
>
> Thanks for the patch. Moving this to an atomic commit is the right direction, but as it stands every write still ends in a full modeset.
>
> In amdgpu_dm_atomic_check(), any abm_level difference between the old and new connector state sets new_crtc_state->connectors_changed = true. That makes drm_atomic_crtc_needs_modeset() true, and commit_tail skips the abm_changed / stream_update.abm_level fast path. Users would see a blank/flicker on the eDP panel on every power-profile change.
>
> Could you try keeping drm_atomic_get_crtc_state() and setting connectors_changed only for scaling? ABM would then go through the existing stream update with no modeset, like David's [PATCH 2/2] drm/amd/display: Avoid modeset for ABM changes - https://lore.kernel.org/amd-gfx/20260813112634.11455-3-weber.aulendorf@gmail.com/
>
> Please run IGT amd_abm, including abm_gradual, before v2.
>
> Also see inline comments.
>
Thanks for review! I will send out v2 shortly.
prev parent reply other threads:[~2026-11-09 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 21:58 Shivam Kalra via B4 Relay
2026-11-05 21:45 ` Alex Hung
2026-11-09 20:15 ` Shivam Kalra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2caf9f85-8d5d-482a-8479-dd682cbf96fa@zohomail.in \
--to=shivamkalra98@zohomail.in \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamzamahfooz@linux.microsoft.com \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=weber.aulendorf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®