From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E04EB64D7 for ; Mon, 26 Jun 2023 13:56:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbjFZN4b (ORCPT ); Mon, 26 Jun 2023 09:56:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230203AbjFZN4V (ORCPT ); Mon, 26 Jun 2023 09:56:21 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F168C10F3 for ; Mon, 26 Jun 2023 06:56:14 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3fb10fd9ad3so5473715e9.0 for ; Mon, 26 Jun 2023 06:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares.net; s=google; t=1687787773; x=1690379773; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FvwNRNrF8mI3P6llYM5gd3K4KnP8OJjmIVJOWMH6Qwk=; b=udTCrsmRCn5UUJQwqNUZMWZGz0xksESGqOF3Q0FF4x2DROSdW0N27AXj4wxaYq7CIk UMKkgKy0SW7FIudsGAGzQvOIQgsKGjBAkI9KjgoMBtyldJkSU82QOO2d2X1ERca36FKz atL0SafhyuOcgOwf86/SmJDu9dy/NtvGrLJMUViOmiBSuL9HSzw1YpiFKZRp4BlvmJyO c6kxkXVG50R2xhXYHTvhUoZ9c3rMC6uFPgLMq/llDL+T7I4mt9WfM1qZy+qKHLGOtq9+ YZnTrUOauH81tdJ536nibfiQTns/LrMVykgtuwv1aRO/iELPkvMcQ0gm5678QcXH3iq2 Onrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687787773; x=1690379773; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FvwNRNrF8mI3P6llYM5gd3K4KnP8OJjmIVJOWMH6Qwk=; b=Z0Eh667kFnK603BDk5sElzZ/9JP9lKDMiRqiYUxFpbUFNPmFr0s2DG+BrlqXQ5bypi r3Iy88d/423HxNucWuSXJBNvhf9V2XKSdz4GfWWLAYQQ6x7f+aZmNBz2ZV//sjPBdglp X0EouWWO2bAM5pGZBy6hufRqfyG+Q9iydUpzGH4chTCadZ/k/IBpOGH5t/A7P06+KjVu m209mAxjfXyLSqNR4o10wXZUjL+uoip9O8/Fl26gF274A8zWlmr4FnNtUaACXUQhPZ1c 3nwLP9bfYQ/Z9xsw4gz1OIwB7HUjc18CbXWbotmFXTLdDHJLm8SzMSoLPIs4QZ0USn+z XQsA== X-Gm-Message-State: AC+VfDx9/eOkM7Dhejk92CkR9+gkVWgKVsWC1Nu61HctsllicmhIooB1 N+SaMBG61fkKEHmLzcGhJsrsNA== X-Google-Smtp-Source: ACHHUZ77dDFzSYL/4C41Q5EjhUboMu666xiajF8k2wkBMpzw4Zj+zteK2QyE8a3CbzCPcE6wR0A3uA== X-Received: by 2002:a7b:ca55:0:b0:3fa:7515:544 with SMTP id m21-20020a7bca55000000b003fa75150544mr9208279wml.34.1687787773275; Mon, 26 Jun 2023 06:56:13 -0700 (PDT) Received: from [10.44.2.5] ([81.246.10.41]) by smtp.gmail.com with ESMTPSA id c21-20020a7bc855000000b003f8fac0ad4bsm7735241wml.17.2023.06.26.06.56.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jun 2023 06:56:12 -0700 (PDT) Message-ID: <2cb3b411-9010-a44b-ebee-1914e7fd7b9c@tessares.net> Date: Mon, 26 Jun 2023 15:56:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH net-next] tools: Fix MSG_SPLICE_PAGES build error in trace tools Content-Language: en-GB To: David Howells Cc: netdev@vger.kernel.org, Arnaldo Carvalho de Melo , David Miller , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jens Axboe , Matthew Wilcox , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org References: <5791ec06-7174-9ae5-4fe4-6969ed110165@tessares.net> <3065880.1687785614@warthog.procyon.org.uk> <3067876.1687787456@warthog.procyon.org.uk> From: Matthieu Baerts In-Reply-To: <3067876.1687787456@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/06/2023 15:50, David Howells wrote: > Matthieu Baerts wrote: > >> So another issue. When checking the differences between the two files, I >> see there are still also other modifications to import, e.g. it looks >> like you also added MSG_INTERNAL_SENDMSG_FLAGS macro in socket.h. Do you >> plan to fix that too? > > That's just a list of other flags that we need to prevent userspace passing > in - it's not a flag in its own right. I agree. This file is not even used by C files, only by scripts parsing it if I'm not mistaken. But if there are differences with include/linux/socket.h, the warning I mentioned will be visible when compiling Perf. Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net