From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 380F7CCA47C for ; Fri, 15 Jul 2022 02:12:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241279AbiGOCMm (ORCPT ); Thu, 14 Jul 2022 22:12:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbiGOCMj (ORCPT ); Thu, 14 Jul 2022 22:12:39 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D75C2CEA; Thu, 14 Jul 2022 19:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657851156; x=1689387156; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=bfHonNeGs4RhEmPSSJB/P0QaiSxZOdOYo3VBTAEL068=; b=ax+k0Ai6R18vgjiX3QcoYLJAVoXPDXYPngRDv+g8mNIaFvchpdGcUCTi ZqU1UEWS6Sr0xw4h9XxdYVK8akKDoEcgJ97gFKniJvw1y/QU2rU2OvlLH gODhr9EZcu2dKwh3l0UrMngg4OYdYOzU0pgmidKPqmVoH2nsZW2HR+Qjf Q=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 14 Jul 2022 19:12:36 -0700 X-QCInternal: smtphost Received: from unknown (HELO nasanex01a.na.qualcomm.com) ([10.52.223.231]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2022 19:12:36 -0700 Received: from [10.253.39.163] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 14 Jul 2022 19:12:33 -0700 Message-ID: <2cb4f711-5e7c-6fc7-263f-0ed6437f0edb@quicinc.com> Date: Fri, 15 Jul 2022 10:12:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1] Bluetooth: hci_sync: Remove redundant func definition Content-Language: en-US To: Luiz Augusto von Dentz CC: Marcel Holtmann , Johan Hedberg , David Miller , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Luiz Augusto Von Dentz , Linux Kernel Mailing List , "linux-bluetooth@vger.kernel.org" , , "open list:NETWORKING [GENERAL]" References: <1657774452-4497-1-git-send-email-quic_zijuhu@quicinc.com> From: quic_zijuhu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/15/2022 4:52 AM, Luiz Augusto von Dentz wrote: > Hi Zijun, > > On Wed, Jul 13, 2022 at 9:54 PM Zijun Hu wrote: >> >> both hci_request.c and hci_sync.c have the same definition >> for disconnected_accept_list_entries(), so remove a redundant >> copy. >> >> Signed-off-by: Zijun Hu >> --- >> net/bluetooth/hci_request.c | 2 +- >> net/bluetooth/hci_request.h | 2 ++ >> net/bluetooth/hci_sync.c | 18 ------------------ >> 3 files changed, 3 insertions(+), 19 deletions(-) > > We are actually deprecating hci_request functions in favor of hci_sync > ones so this is going in the opposite direction. > should remove disconnected_accept_list_entries() definition within hci_request.c instead of hci_sync.c, right? >> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c >> index 635cc5fb451e..38e6c66a3327 100644 >> --- a/net/bluetooth/hci_request.c >> +++ b/net/bluetooth/hci_request.c >> @@ -1784,7 +1784,7 @@ int hci_update_random_address(struct hci_request *req, bool require_privacy, >> return 0; >> } >> >> -static bool disconnected_accept_list_entries(struct hci_dev *hdev) >> +bool disconnected_accept_list_entries(struct hci_dev *hdev) >> { >> struct bdaddr_list *b; >> >> diff --git a/net/bluetooth/hci_request.h b/net/bluetooth/hci_request.h >> index 7f8df258e295..e80b500878d9 100644 >> --- a/net/bluetooth/hci_request.h >> +++ b/net/bluetooth/hci_request.h >> @@ -120,6 +120,8 @@ void __hci_req_update_scan(struct hci_request *req); >> int hci_update_random_address(struct hci_request *req, bool require_privacy, >> bool use_rpa, u8 *own_addr_type); >> >> +bool disconnected_accept_list_entries(struct hci_dev *hdev); >> + >> int hci_abort_conn(struct hci_conn *conn, u8 reason); >> void __hci_abort_conn(struct hci_request *req, struct hci_conn *conn, >> u8 reason); >> diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c >> index 212b0cdb25f5..99ffac6c5e8c 100644 >> --- a/net/bluetooth/hci_sync.c >> +++ b/net/bluetooth/hci_sync.c >> @@ -2419,24 +2419,6 @@ int hci_write_fast_connectable_sync(struct hci_dev *hdev, bool enable) >> return err; >> } >> >> -static bool disconnected_accept_list_entries(struct hci_dev *hdev) >> -{ >> - struct bdaddr_list *b; >> - >> - list_for_each_entry(b, &hdev->accept_list, list) { >> - struct hci_conn *conn; >> - >> - conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, &b->bdaddr); >> - if (!conn) >> - return true; >> - >> - if (conn->state != BT_CONNECTED && conn->state != BT_CONFIG) >> - return true; >> - } >> - >> - return false; >> -} >> - >> static int hci_write_scan_enable_sync(struct hci_dev *hdev, u8 val) >> { >> return __hci_cmd_sync_status(hdev, HCI_OP_WRITE_SCAN_ENABLE, >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project >> > >