From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D5C73D3D11 for ; Tue, 9 Jun 2026 06:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780986251; cv=none; b=mqQ8FTrJWFCZrYwU1SNhbh57HEpl89kR4iPsWmpIAnxH8rWuZcSo46w6sp7akb8mVISNyYI0f8eb/PC5FkFsMMNxvInx1NEYKoglQsx9BH6IA9yGU5TJ/VxoVzWXsNgVTdeuw85Il8A0dLGI0jbyeFR9I8d9DGBETB/u7EUeU08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780986251; c=relaxed/simple; bh=WI1agJF/teXocr4B5URHwywqiMGEjj8CNnx9ZfsdybM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t1G8stn48EdIAQ0iC/z9gAByoNU/wGiGdG4hhDxgqicjLBpn7PKKaqMz4UmInwltSGlwtiAcCvPGLyB1/Q5WLckrBD5J1psSMlu3lqC0M1WZlXPoiXwopIQiLHYDh8p7AbSWHnou2+nRQFFQxxRE3lPlM1I3UhWQ7AHAv5AOU0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=bp/VExPX; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="bp/VExPX" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C91E2681; Mon, 8 Jun 2026 23:24:03 -0700 (PDT) Received: from [10.164.19.15] (unknown [10.164.19.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 84F203FE49; Mon, 8 Jun 2026 23:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1780986248; bh=WI1agJF/teXocr4B5URHwywqiMGEjj8CNnx9ZfsdybM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bp/VExPX/M1qIM7wGLdluxnKwB/YC/xUZUj0DqvPv2zi8A4mdjRy92b1+zbQAMRav Mw7+ooj/Sxwhy44NBfOdCIc427QCgxUIOfOB7/7YzI0HssLcBwFx37zPACdRgkw9gi jbV0UvlaCmSwtnsfksLCVYvB+hBEU2r6RnCtb2Yk= Message-ID: <2cb76a09-6ceb-4e16-95ac-e6a63007cc20@arm.com> Date: Tue, 9 Jun 2026 11:53:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] mm/migrate: rename PAGE_ migration flags to FOLIO_ To: "Garg, Shivank" , akpm@linux-foundation.org, david@kernel.org Cc: kinseyho@google.com, weixugc@google.com, ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, willy@infradead.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, apopple@nvidia.com, dave@stgolabs.net, Jonathan.Cameron@huawei.com, rkodsara@amd.com, vkoul@kernel.org, bharata@amd.com, sj@kernel.org, rientjes@google.com, xuezhengchu@huawei.com, yiannis@zptcorp.com, dave.hansen@intel.com, hannes@cmpxchg.org, jhubbard@nvidia.com, peterx@redhat.com, riel@surriel.com, shakeel.butt@linux.dev, stalexan@redhat.com, tj@kernel.org, nifan.cxl@gmail.com, jic23@kernel.org, aneesh.kumar@kernel.org, nathan.lynch@amd.com, Frank.li@nxp.com, djbw@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Baolin Wang , Lance Yang References: <20260428155043.39251-2-shivankg@amd.com> <20260428155043.39251-4-shivankg@amd.com> <996a1f61-3b59-40ef-9508-ef339cc0c931@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/06/26 11:47 am, Garg, Shivank wrote: > > > On 6/9/2026 11:04 AM, Dev Jain wrote: >> >> >> On 28/04/26 9:20 pm, Shivank Garg wrote: >>> These flags only track folio-specific state during migration and are >>> not used for movable_ops pages. Rename the enum values and the >>> old_page_state variable to match. >>> >>> No functional change. >>> >>> Suggested-by: David Hildenbrand >>> Acked-by: David Hildenbrand (Arm) >>> Reviewed-by: Zi Yan >>> Reviewed-by: Baolin Wang >>> Reviewed-by: Lance Yang >>> Signed-off-by: Shivank Garg >>> --- >> >> migrate_folio_undo_src() has a parameter "page_was_mapped", change that >> too? >> >> > > Thanks, Dev. Right. > > This patch is already in mm-stable tree and it's fairly late in this cycle. > So, not sure if the last minute changes are okay for this? Oh I didn't realize this is already in. No worries then, it can be sent later too. > > Given this, I'll leave the timing to the maintainers: > I can fold this and resend now, or send it early next cycle? > > Best Regards, > Shivank > --- > mm/migrate.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 0c6a0ab6ecce..fd524f9e6fae 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1157,13 +1157,10 @@ static void __migrate_folio_extract(struct folio *dst, > } > > /* Restore the source folio to the original state upon failure */ > -static void migrate_folio_undo_src(struct folio *src, > - int page_was_mapped, > - struct anon_vma *anon_vma, > - bool locked, > - struct list_head *ret) > +static void migrate_folio_undo_src(struct folio *src, int folio_was_mapped, > + struct anon_vma *anon_vma, bool locked, struct list_head *ret) > { > - if (page_was_mapped) > + if (folio_was_mapped) > remove_migration_ptes(src, src, 0); > /* Drop an anon_vma reference if we took one */ > if (anon_vma)