From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A53FD3B8D7F for ; Sun, 14 Dec 2025 00:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765670974; cv=none; b=bDnGgYFa4UmK40MztDi28LtXVv2tdXCKl4FYx0Sao47LuR2W4vpYIuKdbxL5X0Dxaki0Ozl3gxTfmZkU5UPSycdTFA02jytwALni0N60fUEu4hVSci+80+WDDKmP9H0IHtKvr3N8BQHSZBj5S2Kkcmp83xvq6lU6jXhZ/Ft+Uz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765670974; c=relaxed/simple; bh=sgNSVyUVIlQGl+4yq6gFL7+dAkwlztttag9JjuKcAB8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qi7TtDZyxiHqTdhkNR4nqdgOm4wuSSzj5JjYnaQZWs7L7XjAN/vTbLvoU99AG1D8WKtpGdCkXspLHGEaHZpM8hw/Wf9Vzs6hST8ccgeX2SqzuGopzSaxmhlJs28ID5hzmpAEPYeVPKF5PLZ7q8Og5iiUdFOQZ18mmiTJM55478k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N+GfDfPZ; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N+GfDfPZ" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-598ed017e4cso319637e87.0 for ; Sat, 13 Dec 2025 16:09:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765670971; x=1766275771; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=YLbZpeVWxhUiA9xdv2yvpF5kwmnyurNX54Ve7q/okuU=; b=N+GfDfPZ87JYzoR59zM/+8WfSjy6WI1X/m+CBQAkxW4lS8KmXuwjgzu/fYI26l7zuX jBbdwEIqsNeqL/WR5gBE8iPXBG1vATlGosqrrorghFnDk0grJo3Apn4UTA/yasAtlhZc tZ823kTOA7XjwITOE8/TacFEp+Jnkyu/BSRPR7C64cPc2zTBzHGnj9ZzvWJuJqH2EHY+ wcHZrbGluVeoIMLrknyj4XhVa+Gj7E3K+RVIhjgWkMgW2VuELUm2iP9P2bCdktgCYeml dXX+q9zYbNDJbRdrItlmjlE22mp/z9dPEUEvOyvLvyN+vUGius4u7Fxw9aus2xx92VQz yILg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765670971; x=1766275771; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YLbZpeVWxhUiA9xdv2yvpF5kwmnyurNX54Ve7q/okuU=; b=g6kWgbQ0tzrmPqkXGlJ7TAipSJwAog/NZPyBRSABRjLblKQobZY0+mlBBqJs6pBE9/ YVRdF/UgSM4mBFrQpE4+TZzqulCQuU7EDhxmeD/ROYDUVfJNcrPyBQXMqW0nh5K5UFsx /BR0TQ04Xu2ucGlRgyz1I7KEV8yKpktvcZcd02VYAg/UKIrcozJr07TI50PHMqPzqb7S Unvp+9J3nMd2aen+dTOmUraGeL5DdwohLBBzyUaBAZd3eGA4Xhf+rd1IM3e2zoqabPir rW7wWQotmUEhwWR1x4jFvzCe/RREW2lUtX8QzUFhzooquhRUlIWXqU/gAyMX4+HX1Afx C1Dg== X-Forwarded-Encrypted: i=1; AJvYcCXg2xnJT9OZ74P3Ol5SvsK4OCU9HCv1BNITdkRfsYz2t2qSqvpZf1qHXFQv2TvxpCdp6EkthkO7cuk0oQc=@vger.kernel.org X-Gm-Message-State: AOJu0YyZY94Ix9BHtjDyqc7/WfSInGjMLHMSvQ5cEqWdGSPXm7i7ZcUd y4L0SU14BIKNaMYcIxqb88Rmn1QyDPZnmUhOzSkDcivFAUMqcH/DlNgV+aqHyC6dgmg= X-Gm-Gg: AY/fxX5WTcGW9x6iSLuhJolX6qyZC8fBCxUmrzWZdBW4wFr37izoe1Ae7FhpSELdKTr 7oiMuzFZgMmXUbyQCLdk3a9O65A4pxIRcqpBuSnCqIGt2e8QpkcH9KGS2lZIUjLrXlerIQpAVKb 2nI704Pc2VpNyppRpa4xwnyTjkdxIY+tVawK2KXYso9OSiYjz1Gl22id5EA5nGt+c+pEAX8Yhbk W7zF0wic5eHqV435kXqsH0FECCCmta+RN+uRzg+O/vsHZc8KrH7RrzCWz0o/scVNkoscgLKhEfl n3qDWSrRU2IA7nXXc1pQZoDrOPszxkeFVXTY5lIW8oSpJkXMOZ49vqA4HwaBQCQj+T0OLWY60iV s2waiFMqdlcBM2NBrsY9nAAYg3xF4DaD1yYaWn/xHvFMIPwX2jD4RoNUZ0WhAKShFtct0mPZpto rATa98th1n876n/lS7TYHk4htRE4yyU+5nFmoPSYvrYAH5eM/SqgOxdmZqL1GnnbOyrQ== X-Google-Smtp-Source: AGHT+IGa33buz/rmba0bIG4qV9RX3OHMcGRTnZkr8Mbi7xgjdbVEw2xZ+1nY7hVGxnE3RNPMJLjOOg== X-Received: by 2002:a05:6512:3d1b:b0:597:d7d6:398d with SMTP id 2adb3069b0e04-598faa01850mr1324255e87.2.1765670970598; Sat, 13 Dec 2025 16:09:30 -0800 (PST) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-598f3194dbcsm3464122e87.78.2025.12.13.16.09.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Dec 2025 16:09:28 -0800 (PST) Message-ID: <2cb8c5ce-ea80-4cb6-9bef-f526eb433d96@linaro.org> Date: Sun, 14 Dec 2025 02:09:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl To: david@ixit.cz, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251213-sdm845-mclk-v1-0-197bc947d4c6@ixit.cz> <20251213-sdm845-mclk-v1-1-197bc947d4c6@ixit.cz> From: Vladimir Zapolskiy In-Reply-To: <20251213-sdm845-mclk-v1-1-197bc947d4c6@ixit.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/13/25 14:00, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > There are shared for the whole architecture, so let's define these in > proper place. > > Signed-off-by: David Heidelberg > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 43 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index bf2f9c04adba7..97bd9513b011b 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -2805,6 +2805,49 @@ tlmm: pinctrl@3400000 { > gpio-ranges = <&tlmm 0 0 151>; > wakeup-parent = <&pdc_intc>; > > + cam_mclk0_default: cam-mclk0-default-state { > + pins = "gpio13"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cam_mclk0_sleep: cam-mclk0-sleep-state { > + pins = "gpio13"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > + cam_mclk1_default: cam-mclk1-default-state { > + pins = "gpio14"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cam_mclk1_sleep: cam-mclk1-sleep-state { > + pins = "gpio14"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > + cam_mclk2_default: cam-mclk2-default-state { > + pins = "gpio15"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cam_mclk2_sleep: cam-mclk2-sleep-state { > + pins = "gpio15"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > + Please remove an excessive blank line. > cci0_default: cci0-default-state { > /* SDA, SCL */ > pins = "gpio17", "gpio18"; > Please add mclk3 to the list, it's one of the gpio16 pad functions. After adding that Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir