From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D7D2C433DB for ; Tue, 9 Feb 2021 01:50:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 234AC64EBA for ; Tue, 9 Feb 2021 01:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbhBIBuc (ORCPT ); Mon, 8 Feb 2021 20:50:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229721AbhBIBuU (ORCPT ); Mon, 8 Feb 2021 20:50:20 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7CD2C061786 for ; Mon, 8 Feb 2021 17:49:40 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id q72so668337pjq.2 for ; Mon, 08 Feb 2021 17:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=8sv6X8syVHw1MIFVnsFs4iqBtg0ahotEAO2Dby5NCpU=; b=iYuo4Ld9rJKpnWlst5Klip3cA0uIYA463UoQfUlm/ElZXIEuJ9xOYyWIQPmO05T52D lsdTx4V2qLKSR6bZWN1CqWototlMMdjJ7LRHfAg45/+FgGaCKErnR6JUzNOTe7K5GlY8 oWCx4rAEEpbyUCqcc+dOclWiENK6Fjg4dxZ0rXZY9Tbipsy4umONf/gn0LSrRR3gSh2c 8S1k1JrOc4bGdIhSFHduHa0rGtFeNA0LPy+Mmqu6DGzoCKrdGDmy7ZzIdhSr9VK4y9o7 p1pbEp3aovV2Kq+OF58bEq1L5V/DeZPzQg06pGN5fcf3Rgspbow0oH6i3QfOp0AgRPwJ EXcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=8sv6X8syVHw1MIFVnsFs4iqBtg0ahotEAO2Dby5NCpU=; b=H4a3JRfsLx2I0GwE94yU/Shb2U8beEDA2Ec09HiBn7K+xylGSjlJCG2XtUmSYQkmKV 7RNDmoz098rIVOQ/io/5auw/UtSE+bdYZFIOgDSaHVMVl7kS7MYwjbazlY1frv6ycOMh 685r8bfuMk+QkdQDcU3hy9zg061v1oZTR5oxGXsOWmrNXFIGJnV5gy+R30jYcRbtHOYJ uAhft31b2Vn0dTn5RtYPMiVXyC6o4Fwir+MT4WWhyMm83ft9nV2GjsNx/NSs9wndpbVB JAyDWO50qY1P2M2SiUJe4qtxQGMSyGpSfLB1SyXbw5J5yBW3o8UH2oHzTcM/z2kiuIDy XeLw== X-Gm-Message-State: AOAM530qki/3rBet90JcSJ37qvCF5LFjgRb4x554bwJ7t6NZiG92pURX gJVGkWzwywo9K16YZEKKGj8vGg== X-Google-Smtp-Source: ABdhPJzZWidT5PIEFpUI7hEhLGLVBjo5gbdYu1UlNuQmIRIftrCd/yOqL2Ex2XHz8iGxZg85N4LdFQ== X-Received: by 2002:a17:90a:c789:: with SMTP id gn9mr1662640pjb.101.1612835380312; Mon, 08 Feb 2021 17:49:40 -0800 (PST) Received: from [10.255.96.22] ([139.177.225.229]) by smtp.gmail.com with ESMTPSA id y2sm488470pjw.36.2021.02.08.17.49.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 17:49:39 -0800 (PST) Subject: Re: [External] Re: [PATCH] psi: Add PSI_CPU_FULL state To: Johannes Weiner Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org, songmuchun@bytedance.com References: <20210207072402.67532-1-zhouchengming@bytedance.com> From: Chengming Zhou Message-ID: <2cb984f3-fb8b-df26-31a2-8a091213d87e@bytedance.com> Date: Tue, 9 Feb 2021 09:49:34 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/2/9 上午2:18, Johannes Weiner 写道: > On Sun, Feb 07, 2021 at 03:24:02PM +0800, Chengming Zhou wrote: >> The FULL state doesn't exist for the CPU resource at the system level, >> but exist at the cgroup level, means all non-idle tasks in a cgroup are >> delayed on the CPU resource which used by others outside of the cgroup. >> >> Co-developed-by: Muchun Song >> Signed-off-by: Muchun Song >> Signed-off-by: Chengming Zhou > Acked-by: Johannes Weiner > > That metric's come up in our production environment recently as well, > it makes a lot of sense. > > In addition to outside competition, this also applies to downtimes > enforced by cpu.max - another cgroup usecase that is worth mentioning > in the changelog & code comment. Thank you, I will add this and send patch-v2. > Thanks