From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13721C4320A for ; Sun, 15 Aug 2021 14:08:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6CB46103A for ; Sun, 15 Aug 2021 14:08:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238451AbhHOOIu (ORCPT ); Sun, 15 Aug 2021 10:08:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57067 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236447AbhHOOIt (ORCPT ); Sun, 15 Aug 2021 10:08:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629036498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qfa93i2ZK7DbW0IUEkpbw8qs/9PpSQu7yX+YS2BAR6k=; b=cpeyaVCGpChe3wL8vlxfkz/d2SRBLrl/z6UM6XodIl4rTk7YwUv3l51TrTdGRq07mHeMHE XS9MyHO370kw1KQQqlPdCoPY8nYz9sy36G/Qr4CiE3Mk/GcnbOluBF6KrMm5L7HBkLHa9u j3Rq2WGGFA58sYVtKO9ai64uE65m18Y= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-592-4t3dy6yCPJm-DA64R7820Q-1; Sun, 15 Aug 2021 10:08:17 -0400 X-MC-Unique: 4t3dy6yCPJm-DA64R7820Q-1 Received: by mail-ed1-f70.google.com with SMTP id y22-20020a0564023596b02903bd9452ad5cso7395217edc.20 for ; Sun, 15 Aug 2021 07:08:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Qfa93i2ZK7DbW0IUEkpbw8qs/9PpSQu7yX+YS2BAR6k=; b=rLPYGf+Vu4ynkwqqzG4mPUHGd9hLwdi1fdA95Rm0LF4d7583GqzawzYchEKbjFl14O IVnSRstv8U+fcL6lue2deTLmtHwiPLDXfYaTHXlTMC3H6qG+L7TuUyVxmGi99VHA9jsB u4zvdwl+fJDIO3w1Xi3KJSD16Y658UdKVjQ53027mLy/GXWyHZg0L8WpLzTM4t87Q98p i4mVNTzFrUyHGDkFKaD6SOOe0Zir3yKu0zWcmEd8aBLSux2H/siFH0NbVKaRxBwD4JjD NECleZ00QwlcPmceD7zrRUczGHAr1UnkEDjGszPNig+Ubwpqxk4VoKsXU/f1SmDEwDTW awNg== X-Gm-Message-State: AOAM533F+iUBDZxJhTr5qEyD98OTHdEug2wza+uRYU/gH7uoXQmIjdgv LknDSS0vXfVMoa6L7wZlfAK8pYis+OesqVw7Sd+9E+qJzv2SadU6rmchR8CRRgeT22Vfjc5lvZe cIEaAuDKwtUP7LSg3szRE2q+t X-Received: by 2002:a17:906:4c8c:: with SMTP id q12mr11800027eju.254.1629036496478; Sun, 15 Aug 2021 07:08:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmOXMQdn/lV07UFN4n3lH5B9FmUnKjIwhknB/xOrcr8kwmEjwwGHrsKwX4X29feraB4eRNZA== X-Received: by 2002:a17:906:4c8c:: with SMTP id q12mr11800012eju.254.1629036496234; Sun, 15 Aug 2021 07:08:16 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id i26sm2720381ejh.4.2021.08.15.07.08.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Aug 2021 07:08:15 -0700 (PDT) Subject: Re: [PATCH 18/20] Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability. To: Daniel Lezcano , Kate Hsuan , Mark Gross , Alex Hung , Sujith Thomas , Rajneesh Bhardwaj , David E Box , Zha Qipeng , Mika Westerberg , Srinivas Pandruvada , AceLan Kao , Jithu Joseph , Maurice Ma , Andy Shevchenko , Dan Carpenter , Daniel Scally , linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com Cc: platform-driver-x86@vger.kernel.org References: <20210810095832.4234-1-hpa@redhat.com> <20210810095832.4234-19-hpa@redhat.com> <95801e67-f09e-64f3-abd6-f38a8f1f1d51@linaro.org> From: Hans de Goede Message-ID: <2cc45082-692d-1a0e-cb44-7e2393c95152@redhat.com> Date: Sun, 15 Aug 2021 16:08:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <95801e67-f09e-64f3-abd6-f38a8f1f1d51@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/14/21 12:39 PM, Daniel Lezcano wrote: > On 10/08/2021 11:58, Kate Hsuan wrote: > > > Why not move it into drivers/thermal/intel ? This cleanup is really something which Intel should have been doing itself, but they have not done that, so now Kate has stepped up to do this. Figuring out if there is a better home for each of these drivers really falls outside of the scope of this. If Intel and specifically Sujith Thomas, the maintainer for that driver who is in the Cc, believe that drivers/thermal/intel is a better place then they can submit a patch for this themselves. If Intel does that right away, then this patch can be dropped from Kate's patch-set. Otherwise this can be moved a second time once someone from Intel gets around to it. Regards, Hans > > >> Signed-off-by: Kate Hsuan >> --- >> drivers/platform/x86/Kconfig | 8 -------- >> drivers/platform/x86/Makefile | 2 +- >> drivers/platform/x86/intel/Kconfig | 1 + >> drivers/platform/x86/intel/Makefile | 2 ++ >> drivers/platform/x86/intel/menlow/Kconfig | 14 ++++++++++++++ >> drivers/platform/x86/intel/menlow/Makefile | 6 ++++++ >> .../platform/x86/{ => intel/menlow}/intel_menlow.c | 0 >> 7 files changed, 24 insertions(+), 9 deletions(-) >> create mode 100644 drivers/platform/x86/intel/menlow/Kconfig >> create mode 100644 drivers/platform/x86/intel/menlow/Makefile >> rename drivers/platform/x86/{ => intel/menlow}/intel_menlow.c (100%) >> >> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig >> index b9c0d2d97793..50ded236a841 100644 >> --- a/drivers/platform/x86/Kconfig >> +++ b/drivers/platform/x86/Kconfig >> @@ -632,15 +632,7 @@ config THINKPAD_LMI >> >> source "drivers/platform/x86/intel/Kconfig" >> >> -config INTEL_MENLOW >> - tristate "Thermal Management driver for Intel menlow platform" >> - depends on ACPI_THERMAL >> - select THERMAL >> - help >> - ACPI thermal management enhancement driver on >> - Intel Menlow platform. >> >> - If unsure, say N. >> >> config INTEL_OAKTRAIL >> tristate "Intel Oaktrail Platform Extras" >> diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile >> index f4c6ced59da1..ea5f5dd3f78a 100644 >> --- a/drivers/platform/x86/Makefile >> +++ b/drivers/platform/x86/Makefile >> @@ -67,7 +67,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o >> obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ >> >> >> -obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o >> + >> obj-$(CONFIG_INTEL_OAKTRAIL) += intel_oaktrail.o >> obj-$(CONFIG_INTEL_VBTN) += intel-vbtn.o >> >> diff --git a/drivers/platform/x86/intel/Kconfig b/drivers/platform/x86/intel/Kconfig >> index 4efb5ad3e3e1..59c9b602c784 100644 >> --- a/drivers/platform/x86/intel/Kconfig >> +++ b/drivers/platform/x86/intel/Kconfig >> @@ -36,6 +36,7 @@ source "drivers/platform/x86/intel/intel_speed_select_if/Kconfig" >> source "drivers/platform/x86/intel/turbo_max_3/Kconfig" >> source "drivers/platform/x86/intel/uncore_freq/Kconfig" >> source "drivers/platform/x86/intel/int0002/Kconfig" >> +source "drivers/platform/x86/intel/menlow/Kconfig" >> >> >> endif # X86_PLATFORM_DRIVERS_INTEL >> diff --git a/drivers/platform/x86/intel/Makefile b/drivers/platform/x86/intel/Makefile >> index fe5058c3af18..b2326554bd84 100644 >> --- a/drivers/platform/x86/intel/Makefile >> +++ b/drivers/platform/x86/intel/Makefile >> @@ -12,6 +12,7 @@ obj-$(CONFIG_INTEL_HID_EVENT) += hid/ >> obj-$(CONFIG_INTEL_WMI_SBL_FW_UPDATE) += wmi/ >> obj-$(CONFIG_INTEL_WMI_THUNDERBOLT) += wmi/ >> obj-$(CONFIG_INTEL_INT0002_VGPIO) += int0002/ >> +obj-$(CONFIG_INTEL_MENLOW) += menlow/ >> >> >> # Intel PMIC / PMC / P-Unit devices >> @@ -38,3 +39,4 @@ obj-$(CONFIG_INTEL_SPEED_SELECT_INTERFACE) += intel_speed_select_if/ >> obj-$(CONFIG_INTEL_TURBO_MAX_3) += turbo_max_3/ >> obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL) += uncore_freq/ >> >> + >> diff --git a/drivers/platform/x86/intel/menlow/Kconfig b/drivers/platform/x86/intel/menlow/Kconfig >> new file mode 100644 >> index 000000000000..b2920d259ff7 >> --- /dev/null >> +++ b/drivers/platform/x86/intel/menlow/Kconfig >> @@ -0,0 +1,14 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> +# >> +# Intel x86 Platform Specific Drivers >> +# >> + >> +config INTEL_MENLOW >> + tristate "Thermal Management driver for Intel menlow platform" >> + depends on ACPI_THERMAL >> + select THERMAL >> + help >> + ACPI thermal management enhancement driver on >> + Intel Menlow platform. >> + >> + If unsure, say N. >> diff --git a/drivers/platform/x86/intel/menlow/Makefile b/drivers/platform/x86/intel/menlow/Makefile >> new file mode 100644 >> index 000000000000..0e9fda9bff98 >> --- /dev/null >> +++ b/drivers/platform/x86/intel/menlow/Makefile >> @@ -0,0 +1,6 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> +# >> +# Intel x86 Platform Specific Drivers >> +# >> + >> +obj-$(CONFIG_INTEL_MENLOW) += intel_menlow.o >> diff --git a/drivers/platform/x86/intel_menlow.c b/drivers/platform/x86/intel/menlow/intel_menlow.c >> similarity index 100% >> rename from drivers/platform/x86/intel_menlow.c >> rename to drivers/platform/x86/intel/menlow/intel_menlow.c >> > >