From: Randy Dunlap <rdunlap@infradead.org>
To: Matthew Wilcox <willy@infradead.org>, Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] mm: Fix typos in comments
Date: Sun, 21 Mar 2021 20:52:53 -0700 [thread overview]
Message-ID: <2cc83cd7-6fd2-2b4f-b03a-5e1a384aa137@infradead.org> (raw)
In-Reply-To: <20210322034408.GD1719932@casper.infradead.org>
On 3/21/21 8:44 PM, Matthew Wilcox wrote:
> On Mon, Mar 22, 2021 at 03:51:52AM +0100, Ingo Molnar wrote:
>> +++ b/mm/huge_memory.c
>> @@ -1794,7 +1794,7 @@ bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr,
>> /*
>> * Returns
>> * - 0 if PMD could not be locked
>> - * - 1 if PMD was locked but protections unchange and TLB flush unnecessary
>> + * - 1 if PMD was locked but protections unchanged and TLB flush unnecessary
>> * - HPAGE_PMD_NR is protections changed and TLB flush necessary
>
> s/is/if/
>
>> @@ -5306,7 +5306,7 @@ void adjust_range_if_pmd_sharing_possible(struct vm_area_struct *vma,
>>
>> /*
>> * vma need span at least one aligned PUD size and the start,end range
>> - * must at least partialy within it.
>> + * must at least partially within it.
>
> * vma needs to span at least one aligned PUD size, and the range
> * must be at least partially within in.
>
>> /*
>> * swapon tell device that all the old swap contents can be discarded,
>> - * to allow the swap device to optimize its wear-levelling.
>> + * to allow the swap device to optimize its wear-leveling.
>> */
>
> Levelling is british english, leveling is american english. we don't
> usually "correct" one into the other.
How about "labelled" (from mm/kasan/shadow.c):
@@ -384,7 +384,7 @@ static int kasan_depopulate_vmalloc_pte(pte_t *ptep, unsigned long addr,
* How does this work?
* -------------------
*
- * We have a region that is page aligned, labelled as A.
+ * We have a region that is page aligned, labeled as A.
* That might not map onto the shadow in a way that is page-aligned:
--
~Randy
next prev parent reply other threads:[~2021-03-22 3:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 2:51 Ingo Molnar
2021-03-22 3:44 ` Matthew Wilcox
2021-03-22 3:52 ` Randy Dunlap [this message]
2021-03-22 3:58 ` Bhaskar Chowdhury
2021-03-22 20:52 ` [PATCH, -v2] " Ingo Molnar
2021-03-22 4:01 ` [PATCH] " Randy Dunlap
2021-03-22 20:50 ` Ingo Molnar
2021-03-22 21:02 ` Randy Dunlap
2021-03-22 21:26 ` [PATCH, -v3] " Ingo Molnar
2021-03-28 21:52 ` Andrew Morton
2021-05-09 6:26 [PATCH] mm: fix " Hyeonggon Yoo
2022-03-18 10:37 Julia Lawall
2022-03-18 11:07 ` Joe Perches
2022-03-18 11:15 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cc83cd7-6fd2-2b4f-b03a-5e1a384aa137@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®