From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753671AbdAZQbT (ORCPT ); Thu, 26 Jan 2017 11:31:19 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:33413 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752802AbdAZQbQ (ORCPT ); Thu, 26 Jan 2017 11:31:16 -0500 From: Sagi Grimberg Subject: Re: [PATCH] nvme: make nvmf_register_transport require a create_ctrl callback To: Johannes Thumshirn , Christoph Hellwig , Keith Busch References: <20170126152228.15330-1-jthumshirn@suse.de> Cc: Jens Axboe , Linux NVMe Mailinglist , Linux Kernel Mailinglist Message-ID: <2cc9ed5f-c9af-fd9d-2c90-04541ceebab6@grimberg.me> Date: Thu, 26 Jan 2017 18:30:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170126152228.15330-1-jthumshirn@suse.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static void __exit nvme_fc_exit_module(void) > diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c > index 557f29b..80f3695 100644 > --- a/drivers/nvme/host/rdma.c > +++ b/drivers/nvme/host/rdma.c > @@ -2063,8 +2063,7 @@ static int __init nvme_rdma_init_module(void) > return ret; > } > > - nvmf_register_transport(&nvme_rdma_transport); > - return 0; > + return = nvmf_register_transport(&nvme_rdma_transport); ??