From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCDE728727F for ; Tue, 2 Dec 2025 16:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764691698; cv=none; b=PD6+plJpfom6iEGE/DHCt+Kb/YtFD96D1oEafH1Zm9aEDTtmpq9K5ePEc9JHO3TNLkFtt9WyUOT+8vcBAIcuaAYEbgiTtAatPT8lEPXByjciEBRpzLMTRNByj+cTBJZeIxsjdau67ka9Jv5VN/6GrK1CsyTHgvwwhhFIaCaDP2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764691698; c=relaxed/simple; bh=g+P6WznOZVMRIKxm6yWTjkhYjM78AYVWkUJIRoCPcC0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=SO/kRkFA1gRB4xJx6Kv0WQSI8JBTrAftDBlksgxgPVjqR2gCqUKwbbGdY11szsVqJ/lScWs0ek6xLIYkFlt2xA4WyfoHoMuPPskhmnc8+BhIFQcinLjSdNdaPLcgj0C1//tyF4optOvf4pswTSWcng/NDBJJX3tzCC2wWd8RqTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IbmZ5G9F; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IbmZ5G9F" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-477a2ab455fso64685495e9.3 for ; Tue, 02 Dec 2025 08:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764691695; x=1765296495; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8taEGCmJMa0QdyAqmJiHyi9j2hnnWICf9uWNlE276Ag=; b=IbmZ5G9FfNxl2/BwbXzWr42hLowUspd+UojzRsZh2mYAMd0nRtFeAwJBv2p44ufVh+ tKd3V1/xgF8qQFBYwtLF0b2xeTQLThMRKHHRk6BQuN09IeQHgWpN2JVB1VSz94BGs/N0 Behry0u05+HAxKU7RKwTgVv/5ymSC7vN7VkzweKkICXzVO85aOmyNDY/LkCaWuqMEIcK cQzW6mgP9bj9QJOdN31hBbAq/celLpzFrb91FI/6jwYukhneWqZXHPg+aN2eQE2SWZ8j yDt2F1B4eL7jdis8dHVKWjNb6tY/n9oAeeVtt4P/ENI9C9gGGWBLCGgdYniVTjhIyuN+ QgoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764691695; x=1765296495; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8taEGCmJMa0QdyAqmJiHyi9j2hnnWICf9uWNlE276Ag=; b=ezKar5eXam8e4aV9biqmjvw/WKoq39SE38TfAqqPUemo4nEBklMGBsNcINoqCVEHW/ 2PXwrhoSUpWWQq3k/I1uIlG6hLmIY/i7tUNyv7Z7ul/iBP0W+TGpkeip9jijvlqshEEK 8sm/o40r0O9sow4yz1jYV7N6MAnDKL0WmcK00I1UYK1Joy1Ob0EkklGFcdMTYiOfwxd6 X5iWGm+q9VM57VBYH6TPlqj7pHxc20C0XityyaeYCc3difvw6fEColjGSHCtyydpqKcS J615TnlnMTT9FUR6yUHiDRrUa0+A5SZp7xL693Z9JENb87QJbbffmUZ4+J59YyfktrTR T8fA== X-Forwarded-Encrypted: i=1; AJvYcCUH5pdoumD/6cBTqPk8lB3XPVe0N9IpkwiMP11QFDyitNyanZEMHCkI2mdpAYZwve38HeoNHnebLfVXFww=@vger.kernel.org X-Gm-Message-State: AOJu0YzZziDfH/FAcbmG4X8BhdKX+aCf/Uj39eK9teCBYaR4R4ZyV2/9 ieOh51wrALAC3gswb31Cds2hZusuUbm3e7m1z98ha2vDrKQjZi8Kh3Vx X-Gm-Gg: ASbGncvZxfmzzoPNqni0e9loCQbL0krY/vsjcW8jS9MrZHqfKsdoB4yVIe2ZYdHBUNZ 9tJnDeI2pqFrHKbH5XOLrzva9ebtMGbBgAGL9ElnJfEjHsoIx6urIWwCUHC06oA9S8OT5iWvqaU XRc40HXwwsaP9LbF/2X/42+0HOL65ol/tAfQuFqNOx9s1f2K7jIqv54kyKhNl39OpJGzol1KzaR px3TQEv2aFU8vvp61GyKnH+S2OimhUT/AgSzUCoUD+lRNQysl3TIL02G3z81uxDrdci/BElD3I4 0nYswxufUdxpVJt2WuRZY/54hF5CloikBQO8OCccwaxk4QNQcweOIelL30zcEWtvVvpNElcYweN BxbV+GcJOXMqcmHQVQqY354Wsm9V/kyyDbghh7gL6HGS12O/VGUHqgivGkX/dgJYmxRGnhZDfiA nGNDd3TERjC9LAz3uNDfk= X-Google-Smtp-Source: AGHT+IHN8MLUgVqG1TZJOjfcwHO3vzVTApj51Da/zxDzFVWxbtRl2/o/4nKL8gjUmVEELWg/xEjhFQ== X-Received: by 2002:a05:600c:4f50:b0:477:ae31:1311 with SMTP id 5b1f17b1804b1-4792a47aadfmr1656855e9.13.1764691695014; Tue, 02 Dec 2025 08:08:15 -0800 (PST) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca4078csm32812818f8f.29.2025.12.02.08.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 08:08:14 -0800 (PST) Message-ID: <2ccd698bb58f36fc1d25c36c43e20a6b689cdf5c.camel@gmail.com> Subject: Re: [PATCH v2 2/2] iio: adc: ad9467: support write/read offset From: Nuno =?ISO-8859-1?Q?S=E1?= To: Tomas Melin , Andy Shevchenko Cc: Lars-Peter Clausen , Michael Hennerich , Nuno Sa , Jonathan Cameron , David Lechner , Andy Shevchenko , Alexandru Ardelean , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 02 Dec 2025 16:08:54 +0000 In-Reply-To: References: <20251202-ad9434-fixes-v2-0-fa73d4eabbea@vaisala.com> <20251202-ad9434-fixes-v2-2-fa73d4eabbea@vaisala.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-12-02 at 17:01 +0200, Tomas Melin wrote: >=20 >=20 > On 02/12/2025 16:11, Andy Shevchenko wrote: > > On Tue, Dec 02, 2025 at 12:53:09PM +0000, Tomas Melin wrote: > > > Support configuring output calibration value. Among the devices > > > currently supported by this driver, this setting is specific to > > > ad9434. The offset can be used to calibrate the output against > > > a known input. The register is called offset, but the procedure > > > is best mapped internally with calibbias operation. > >=20 > > ... > >=20 > > > =C2=A0static const struct iio_chan_spec ad9434_channels[] =3D { > > > - AD9467_CHAN(0, BIT(IIO_CHAN_INFO_SCALE), 0, 12, 's'), > > > + { > > > + .type =3D IIO_VOLTAGE, > > > + .indexed =3D 1, > > > + .channel =3D 0, > > > + .info_mask_shared_by_type =3D > > > + BIT(IIO_CHAN_INFO_SCALE) | > > > + BIT(IIO_CHAN_INFO_SAMP_FREQ) | > > > + BIT(IIO_CHAN_INFO_CALIBBIAS), > >=20 > > Wrong indentation. >=20 > Can you please provide example of your preferred indentation for this > particular case? This is used in several places around the code and > seemed like one of the more readable. >=20 > >=20 > > > + .info_mask_shared_by_type_available =3D > > > + BIT(IIO_CHAN_INFO_SCALE) | > > > + BIT(IIO_CHAN_INFO_CALIBBIAS), > >=20 > > Ditto. > >=20 > > > + .scan_index =3D 0, > > > + .scan_type =3D { > > > + .sign =3D 's', > > > + .realbits =3D 12, > > > + .storagebits =3D 16, > > > + }, > > > + }, > > > =C2=A0}; > >=20 > > I'm not sure about macro-less approach here, I think that we want more > > consistency and hence before doing this change probably we want to clea= n up > > the existing macro, then split it to two, and add another one here base= d on > > the low-level, which was split in the previous clean up. >=20 > As mentioned, this is only needed for a single channel, and since it is > different than the other, it needs to be separated. Do You think we > actually need another macro for this? >=20 > >=20 > > ... > >=20 > > > + return ad9467_spi_write(st, AN877_ADC_REG_TRANSFER, > > > + AN877_ADC_TRANSFER_SYNC); > >=20 > > I would make it one line, despite on being 85 characters long. > > But it's up to you and maintainers. > I would like to not fight against checkpatch here. >=20 > >=20 AFAIK, Jonathan policy is that 80 column limit is still the preferred limit= unless readability is hurt. So I would say the line break here is up to the IIO policy. - Nuno S=C3=A1