From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E29E6CCA479 for ; Mon, 18 Jul 2022 07:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233794AbiGRHTX (ORCPT ); Mon, 18 Jul 2022 03:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233801AbiGRHTV (ORCPT ); Mon, 18 Jul 2022 03:19:21 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A4D13CF7 for ; Mon, 18 Jul 2022 00:19:19 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id v16so15668734wrd.13 for ; Mon, 18 Jul 2022 00:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=SQ3SllmUgI/0gTSk6zeAGxNHKWL97JN2nZZc5fKOm5c=; b=N4DASKSLJdxXiMrG1KCns0eaYNhtD01q7nBkHfbQ5fuvMjJPcJxAOjHzaeHz1xxvVI FhNmPm/D/w62u1v6LqH9gZ/TQ39JMZJt/qP05zBXeUmF88upVMniVieTi/chSTmYfHS+ ElRG0OQTXkSjAdKAxCzxlSjM1CzKcK8EVSggpUk3cE4uhQpHfz0wdMRmE2dfU6aJMO/a fRdOck9cBpI+jrMbOy66rXv+ZeCv8k33gB/OnbCfJm/EkLbpEW5D0azB6teG12D+N7cp e/8MXlSvj/ymaqgSCzAMBmIymPL6US4hhLtCn9u7alc/lL0zC6PZ4c1VyRiGUFgOgawM cDRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SQ3SllmUgI/0gTSk6zeAGxNHKWL97JN2nZZc5fKOm5c=; b=mp7lN7OgogWvw3us6mX74dDZ59cRAF0qTAstAk2x3uQGOfrHpdYvlgXK+O6XBFpMZZ spFA7Byc2l6+cA7wfqA4tWFk4ieGnw5w6XAfsQoTBk64+10NwfvZfEGPgZ21M8kXNaGs 3/g2k/0eRD2GsphlJY5qEf1t1D4/0UkDVuRn1Eeef16ecNoSRgIVuW6z5RG1HcbzSKnA WzZfvtoX8eMMCAmsQRQCj7zRSmkyG0M8cAhbFrx0Sr9l11Ur4oBSOsDJniIewBoD9aIY rHHPamygfJKzWc2fYMjQ0coHeLjKgTtSgmpU0dskPJUHq50dF4RGPhD14SYQ+XKbfGFO YdrA== X-Gm-Message-State: AJIora/eI7qEG2nfYxAcf7IGwETdg7Sy7k3RVqe4GTfB8XiB6jXdNgx/ zKpaEwXkAZPpQx9Q5yOnQBjO+w== X-Google-Smtp-Source: AGRyM1u1ldPCMxt1zHXsh5Een4rWGOOpz/5xX/Em7Zo3s1lNKEmrnSdsnHECNarbUOs9uaChc5P9oA== X-Received: by 2002:a5d:5985:0:b0:21d:b6b6:4434 with SMTP id n5-20020a5d5985000000b0021db6b64434mr21236181wri.111.1658128757889; Mon, 18 Jul 2022 00:19:17 -0700 (PDT) Received: from [10.35.4.171] ([167.98.27.226]) by smtp.gmail.com with ESMTPSA id t4-20020a1c7704000000b003a308e9a192sm12037687wmi.30.2022.07.18.00.19.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jul 2022 00:19:17 -0700 (PDT) Message-ID: <2cd139dd-559e-7975-41a7-c813bc5851ea@sifive.com> Date: Mon, 18 Jul 2022 08:19:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/7] pwm: change &pci->dev to dev in probe Content-Language: en-GB To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Thierry Reding , Krzysztof Kozlowski , Greentime Hu , Jude Onyenegecha , Sudip Mukherjee , William Salmon , Adnan Chowdhury References: <20220712100113.569042-1-ben.dooks@sifive.com> <20220712100113.569042-2-ben.dooks@sifive.com> <20220713081633.5lsunbl5mfnngdrs@pengutronix.de> From: Ben Dooks In-Reply-To: <20220713081633.5lsunbl5mfnngdrs@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/07/2022 09:16, Uwe Kleine-König wrote: > On Tue, Jul 12, 2022 at 11:01:07AM +0100, Ben Dooks wrote: >> The dwc_pwm_probe() assignes dev to be &pci->dev but then uses >> &pci->dev throughout the function. Change these all to the be >> 'dev' variable to make lines shorter. > > Looks reasonable. > > Acked-by: Uwe Kleine-König ack for 1/7 or the series? I'll repost v2 this week once we've dealt with polarity. >