mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: KarimAllah Ahmed <karahmed@amazon.de>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org
Subject: Re: [PATCH] X86/VMX: Disable VMX preempition timer if MWAIT is not intercepted
Date: Tue, 10 Apr 2018 11:04:13 +0200	[thread overview]
Message-ID: <2cd149f0-6ebe-59fc-addb-8b4b05e07d80@redhat.com> (raw)
In-Reply-To: <1523350211-5747-1-git-send-email-karahmed@amazon.de>

On 10/04/2018 10:50, KarimAllah Ahmed wrote:
>  	WARN_ON(preemptible());
> -	if (!kvm_x86_ops->set_hv_timer)
> +	if (!kvm_x86_ops->has_hv_timer ||
> +	    !kvm_x86_ops->has_hv_timer(apic->vcpu))
>  		return false;
>  
>  	if (!apic_lvtt_period(apic) && atomic_read(&ktimer->pending))

Why not just return -ENOTSUP from vmx_set_hv_timer?

Thanks,

Paolo

  reply	other threads:[~2018-04-10  9:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10  8:50 KarimAllah Ahmed
2018-04-10  9:04 ` Paolo Bonzini [this message]
2018-04-10 10:09   ` Raslan, KarimAllah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cd149f0-6ebe-59fc-addb-8b4b05e07d80@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hpa@zytor.com \
    --cc=karahmed@amazon.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome