From: Coywolf Qi Hunt <coywolf@gmail.com>
To: Paul Jackson <pj@sgi.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Jeff Garzik <jgarzik@pobox.com>,
linux-kernel@vger.kernel.org,
"Randy.Dunlap" <rdunlap@xenotime.net>
Subject: Re: [PATCH] Document from line in patch format
Date: Sun, 2 Oct 2005 15:20:23 +0800 [thread overview]
Message-ID: <2cd57c900510020020i564d473fx95c608bcac93bea@mail.gmail.com> (raw)
In-Reply-To: <20051002062135.32334.32895.sendpatchset@jackhammer.engr.sgi.com>
On 10/2/05, Paul Jackson <pj@sgi.com> wrote:
> Document more details of patch format such as the "from" line
> used to specify the patch author, and provide more references
> for patch guidelines.
>
> Signed-off-by: Paul Jackson <pj@sgi.com>
>
> Index: 2.6.14-rc2-mm2/Documentation/SubmittingPatches
> ===================================================================
> --- 2.6.14-rc2-mm2.orig/Documentation/SubmittingPatches
> +++ 2.6.14-rc2-mm2/Documentation/SubmittingPatches
> @@ -301,8 +301,47 @@ now, but you can do this to mark interna
> point out some special detail about the sign-off.
>
>
> +12) The canonical patch format
>
> -12) More references for submitting patches
> +The canonical patch subject line is:
> +
> + Subject: [PATCH 001/123] [<area>:] <explanation>
> +
> +The canonical patch message body contains the following:
> +
> + The first line of the body contains a "from" line specifying
> + the author of the patch:
> +
> + From: Original Author <author@email.com>
> +
> + If the "from" line is missing, then the author of the patch will
> + be recorded in the source code revision history as whomever is
> + listed in the last "Signed-off-by:" line in the message when Linus
> + receives it.
> +
> + The "from" line is followed by an empty line and then the body
> + of the explanation.
> +
> + After the body of the explanation comes the "Signed-off-by:"
> + lines, and then a simple "---" line, and below that comes the
> + diffstat of the patch and then the patch itself. The "---" line
> + and diffstat are optional, but helpful to readers of non-trivial
> + patches.
> +
> +The Subject line format makes it very easy to sort the emails
> +alphabetically by subject line - pretty much any email reader will
> +support that - since because the sequence number is zero-padded,
> +the numerical and alphabetic sort is the same.
> +
> +See further details on how to phrase the "<explanation>" in
> +the "Subject:" line in Andrew Morton's "The perfect patch",
> +referenced below.
> +
> +See more details on the proper patch format in the following
> +references.
> +
> +
> +13) More references for submitting patches
>
> Andrew Morton, "The perfect patch" (tpp).
> <http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt>
> @@ -310,6 +349,14 @@ Andrew Morton, "The perfect patch" (tpp)
> Jeff Garzik, "Linux kernel patch submission format."
> <http://linux.yyz.us/patch-format.html>
>
> +Jeff Garzik, "How to piss off a kernel subsystem maintainer"
> + <http://www.kroah.com/log/2005/03/31/>
> +
> +Kernel Documentation/CodingStyle
> + <http://lxr.linux.no/source/Documentation/CodingStyle>
There's another one more updated at http://sosdg.org/~coywolf/lxr/source/
> +
> +Linus Torvald's mail on the canonical patch format:
> + <http://lkml.org/lkml/2005/4/7/183>
>
--
Coywolf Qi Hunt
next prev parent reply other threads:[~2005-10-02 7:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-02 6:21 Paul Jackson
2005-10-02 7:02 ` Antonino A. Daplas
2005-10-02 7:07 ` Paul Jackson
2005-10-02 15:33 ` Linus Torvalds
2005-10-02 16:28 ` Paul Jackson
2005-10-02 7:20 ` Coywolf Qi Hunt [this message]
2005-10-02 16:30 ` Paul Jackson
2005-10-02 15:49 ` Greg KH
2005-10-02 16:25 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd57c900510020020i564d473fx95c608bcac93bea@mail.gmail.com \
--to=coywolf@gmail.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=rdunlap@xenotime.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®