From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 524AEC43441 for ; Thu, 22 Nov 2018 11:21:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E853D208A3 for ; Thu, 22 Nov 2018 11:21:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E853D208A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394678AbeKVWAQ (ORCPT ); Thu, 22 Nov 2018 17:00:16 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:56443 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387962AbeKVWAQ (ORCPT ); Thu, 22 Nov 2018 17:00:16 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 591FFEF1A4E21; Thu, 22 Nov 2018 19:21:17 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.408.0; Thu, 22 Nov 2018 19:21:17 +0800 Subject: Re: [PATCH] f2fs: read page index before freeing To: Pan Bian , Jaegeuk Kim CC: , References: <1542884326-74903-1-git-send-email-bianpan2016@163.com> From: Chao Yu Message-ID: <2cd91c95-598d-fcc1-b1d6-6fddb224efcf@huawei.com> Date: Thu, 22 Nov 2018 19:21:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1542884326-74903-1-git-send-email-bianpan2016@163.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pan, On 2018/11/22 18:58, Pan Bian wrote: > The function truncate_node frees the page with f2fs_put_page. However, > the page index is read after that. So, the patch reads the index before > freeing the page. Good catch! It will be better to add: Fixes: bf39c00a9a7f ("f2fs: drop obsolete node page when it is truncated") Cc: > > Signed-off-by: Pan Bian Reviewed-by: Chao Yu Thanks,