From: Dan Carpenter <dan.carpenter@linaro.org>
To: Tree Davies <tdavies@darkphysics.net>
Cc: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com,
anjan@momi.ca, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Staging: rtl8192e: Remove variable bFirstSeg
Date: Mon, 11 Dec 2023 11:37:07 +0300 [thread overview]
Message-ID: <2cdb678d-b784-411e-8913-eb7666e08ccc@suswa.mountain> (raw)
In-Reply-To: <20231210193705.2131807-2-tdavies@darkphysics.net>
On Sun, Dec 10, 2023 at 11:37:02AM -0800, Tree Davies wrote:
> Remove variable bFirstSeg as it is defined but never used.
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> ---
> drivers/staging/rtl8192e/rtllib.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 0a8c44e497f5..c0a24826cd3b 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -103,7 +103,6 @@ struct cb_desc {
> /* Tx Desc Related flags (8-9) */
> u8 bLastIniPkt:1;
> u8 bCmdOrInit:1;
> - u8 bFirstSeg:1;
> u8 bLastSeg:1;
> u8 bEncrypt:1;
> u8 tx_dis_rate_fallback:1;
I don't think you can remove these. They're part of the protocol for
talking to the firmware.
regards,
dan carpenter
next prev parent reply other threads:[~2023-12-11 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 19:37 [PATCH 0/4] Staging: rtl8192e: Remove unused variables in struct cb_desc Tree Davies
2023-12-10 19:37 ` [PATCH 1/4] Staging: rtl8192e: Remove variable bFirstSeg Tree Davies
2023-12-11 8:37 ` Dan Carpenter [this message]
2023-12-11 19:22 ` Philipp Hortmann
2023-12-12 9:44 ` Dan Carpenter
2023-12-10 19:37 ` [PATCH 2/4] Staging: rtl8192e: Remove variable bLastSeg Tree Davies
2023-12-10 19:37 ` [PATCH 3/4] Staging: rtl8192e: Remove variable bEncrypt Tree Davies
2023-12-10 19:37 ` [PATCH 4/4] Staging: rtl8192e: Remove variable macId Tree Davies
2023-12-10 20:40 ` [PATCH 0/4] Staging: rtl8192e: Remove unused variables in struct cb_desc Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cdb678d-b784-411e-8913-eb7666e08ccc@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=anjan@momi.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=tdavies@darkphysics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®