From: Jens Axboe <axboe@kernel.dk>
To: Joe Perches <joe@perches.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
lee.jones@linaro.org, colin.king@canonical.com,
mchehab+huawei@kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] scsi: arcmsr: Remove the superfluous break
Date: Fri, 18 Sep 2020 11:17:46 -0600 [thread overview]
Message-ID: <2ce1124d-7f83-d9aa-f62a-519c8914ad98@kernel.dk> (raw)
In-Reply-To: <e9320543ab6e7c8bd5ceae8cfa9d0912a0e962e0.camel@perches.com>
On 9/18/20 11:13 AM, Joe Perches wrote:
> On Fri, 2020-09-18 at 09:56 -0500, Gustavo A. R. Silva wrote:
>> On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote:
>>> Remove the superfluous break, as there is a 'return' before it.
>>>
>>
>> Apparently, the change is correct. Please, just add a proper Fixes tag by
>> yourself this time.
>
> There's no need for a "Fixes:" here, it's purely cosmetic.
>
> btw:
>
> There are at least 150 instances of
> return foo(...);
> break;
> still in the kernel tree:
A lot of these are false positives, since they follow a pattern of:
if (some_condition)
return func();
break;
--
Jens Axboe
next prev parent reply other threads:[~2020-09-18 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 9:32 Jing Xiangfeng
2020-09-18 14:56 ` Gustavo A. R. Silva
2020-09-18 17:13 ` Joe Perches
2020-09-18 17:17 ` Jens Axboe [this message]
2020-09-18 19:07 ` Joe Perches
2020-09-18 18:00 ` Dan Carpenter
2020-09-18 18:03 ` Colin Ian King
2020-09-19 1:52 ` Jing Xiangfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ce1124d-7f83-d9aa-f62a-519c8914ad98@kernel.dk \
--to=axboe@kernel.dk \
--cc=colin.king@canonical.com \
--cc=gustavoars@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jingxiangfeng@huawei.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®