From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2FAD37AA7E for ; Sun, 29 Mar 2026 19:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774811444; cv=none; b=Oji9kxLdCGF8vnJyVfbIi4X459CNMIsEmi4cgf06UUbdRvlMAxaD0yTccsKkzfMs8GMsFVlP2a2mNx1rnWgx/gxPZ4sY4fRJoJzJbkt+4qsydviKhTRad8G6C2g3WnaOtKzibCkNsxdzqo5LsQ0Chi5IQrNsC39tEvqsdjOynAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774811444; c=relaxed/simple; bh=zGldTs5fsGuuz7jAf5l/tWje7BqB4EnVpX18Q2GZmDo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iweQSqgoH+xwbWOFT/SplTLzP30lHrehNpqGjuOLOydt5A65j/HUBzXneuQ4ldhwW0O2Xz0hDAqtHGYzF3h6DQZYO2yrGvL/avuwiYC1UPdGmictFN+5FDv9FFKn+uSxbgY60Gl/67CyBgR0r4XwkM1S8b35632/xR4swH1VtX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KN/SEyH2; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KN/SEyH2" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2b042533de1so20705725ad.0 for ; Sun, 29 Mar 2026 12:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774811442; x=1775416242; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=/IEDG0KImXI5R+9pUHBh7bB4VygAWQhG2Ky+eYI3fiI=; b=KN/SEyH2z5M0qvtgcEOVeA7lPkNmBw1QBOgNyYPYri4Uay6/J3NAe46dgliErRGmRD LWeocBPpA+wOYaZgOA9bNKp3qbtumyIOjdTYh8K2kRjWeWtamnvNK9E4CYeDg09PIvzA vZiAQdzkHEjIVu8Oi8DOX79PbK0JvyPrEHIbdDHzmkhBt4gX94zm8MUy5LVRTuoxx/85 2qxuWbk55QelMQ5m2THo1pVN6qJTHYwgV9+WsObTNIlAiwU+wj8e2s0PDjBinK/coGnZ 81/8tcL/IiL/U95Sic3AxR2Ij4XyqySwLjkP8htzxtGBgpbVl5syKxNY7PfIrlkb1V5i 35OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774811442; x=1775416242; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/IEDG0KImXI5R+9pUHBh7bB4VygAWQhG2Ky+eYI3fiI=; b=jHKPOkbB3g1E3ikmx+DRexj+284hpHL3iqBwFs6G26TOla0P+I2DiyFVpusGWFx+So /laTIFJkiSVEJgq9bG+7i+gFB7C1cbbe7XU+Vvm6u/Cw54myv1o/rrlpWnaneqZUV0VT ECuZyoCMDJYfKvbHKd8rHoOVwOHeWY0fkF+tVRQnfKON/K22rakvNh8VDdA7ZICAmBnU xJmlIdlD089l9JanL38fBpE3dl0yceoyfcLC4yYyHv0zeXoSqPjIUt+j70sIRTfN95JA 9Hn+rWmtrCNb67K0N6Er6hW2VmyvXEmFMO6Siha1A+mX2IS3hpfDYVfyyrPNMFX1ZyGp 8DgQ== X-Forwarded-Encrypted: i=1; AJvYcCXz89xAqwgtKJxlmH59jEieJmKCkxB3mKMaShlrSwrqjHnnygLAQxYSl9Prf9QK+k2dHakmPn5d206bpkY=@vger.kernel.org X-Gm-Message-State: AOJu0YwULAS1HnYHsdo5pMPTMgjHO3staDxh5mN7XLnAbE+Tt/XCFdtt bm8f+5Oyeg57ZRbx7X9oyc+/EFNWkjY6Bp+vzBrkBwUvszm59Sq/UsE9 X-Gm-Gg: ATEYQzwcQWN0Vw0413rAXxwUwGh6ErjnsVHgehWKXuNsvu1tPqPbNJpxMN6IjmcfrWz A2Tkk4JuGFEgYWFSahMY+8VvKAax31Lkt73VZG2ECYrmrPBmYZoIgtqVpTKaktBhADGFDoPLjYf jIBS0bf47kV1iyOborhmbudx6r7miBk3vQ9Oj7CtjeibjvxMt+etodihtpSN1J65aSVvT0N+Owb 0cYBcxT3JFR8Ay78qiB++JAHeVCulXbYf1/EzKi2zH6W6ftgQUMJmCk/f8IZEpdX/IMT/JK+VGA tlg9YqWOLBdjAvaTy8a4/5F8ij8hHV9X0M7w9mgxdf4CRtSMKq4rjFv1bzdRuaR2c54UENzJAiI XaX1XS+1sKJXrD8U/rJw8nxExvYpubMwCE0oLpDfwcbjc4ZVov6GstMAJJPlojmcG5rqWTPtdk6 w7JuZ2oogKY62S6Tu+srNpI2ftG/3K3pbnLOO7 X-Received: by 2002:a17:903:3d0f:b0:2b0:49e6:9622 with SMTP id d9443c01a7336-2b0cdcde5ecmr98326255ad.37.1774811442176; Sun, 29 Mar 2026 12:10:42 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24277fb3asm58534395ad.57.2026.03.29.12.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 12:10:41 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 29 Mar 2026 12:10:40 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "Delphine_CC_Chiu@Wiwynn.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan Subject: Re: [PATCH 1/4] hwmon: (tps53679) Fix array access with zero-length block read Message-ID: <2ce7caad-512a-40cd-ac2d-c2abd7198a80@roeck-us.net> References: <20260329170925.34581-1-sanman.pradhan@hpe.com> <20260329170925.34581-2-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260329170925.34581-2-sanman.pradhan@hpe.com> On Sun, Mar 29, 2026 at 05:09:40PM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > i2c_smbus_read_block_data() can return 0, indicating a zero-length > read. When this happens, tps53679_identify_chip() accesses buf[ret - 1] > which is buf[-1], reading one byte before the buffer on the stack. > > Fix by changing the check from "ret < 0" to "ret <= 0", treating a > zero-length read as an error (-EIO), which prevents the out-of-bounds > array access. > > Also fix a typo in the adjacent comment: "if present" instead of > duplicate "if". > > Fixes: 75ca1e5875fe ("hwmon: (pmbus/tps53679) Add support for TPS53685") > Signed-off-by: Sanman Pradhan Applied. Thanks, Guenter