From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C3DA927 for ; Fri, 6 Jun 2025 14:43:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749220985; cv=none; b=QkjrKq65zBMz2JcOdeiuLwhz3KJEMcPm7nVqQc4K1yyFt1d8EofqGl8pOeoG0mo/L/dXsZmCzOWhQGqkWOUUyv8nUoRLypREzcj45GIRrsLHHbPSrHUsXLDg0bNQfqEJQNQfPcSKhSc9yNH8C8jgqDozHWelr/p+srf5Z/0ZgKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749220985; c=relaxed/simple; bh=MRHAloECyV7awIn1pBF28oHNT8VJoNKSlHgGIP6nbFQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bIwlDKRKIbNPldE7Z2EpRJqdR8YjJrX1b7MrkX+GEYYhFD7qpFxOYlyvUWjRR4NVQpU3wGcZ6IeTLerYMJpvMz2opiF6dmcGGTcRB/A4sbtFjqinz7q4KeorM3aIpTxWu42zr+kpp7qkPPtHHee5AISo6CuhtLB21M2Fctz5FOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cwoObaS4; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cwoObaS4" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a5123c1533so1239534f8f.2 for ; Fri, 06 Jun 2025 07:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749220982; x=1749825782; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jkwyvK78VqUgKCW7wfISBRdrqwzf1Kodzs7ruamvtIU=; b=cwoObaS4BzQehWQumYqgocJlbTJAEpXMJa53n5GnofXR4emR1zCbH6SNhnT0hPNZUS 11Xw1kw0Tp6Gr7RTHif21ygLkuzP8K4YWE611IrJi2JRnwP5buDhj+4lEz4i0oYXsK0J vhgnRzRLZ+4yLjz6MYVTF2ClHoxMiNWb2dfq8HRq/r+CMty9v3jLMOsc9/0Tq6tny9e4 MYBAUb5vfUQtFwVl5LmmWpMof0SmVv4Eq872qTePhyyGS4YSPiZ16bYSUuhUMe9/U/rF pR1+enHWoRRsBpeHomOZmCLFlo7hRx+iuhInNWtcO2+4ismsXKNCjHi5w8xaW+g/II7M cW8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749220982; x=1749825782; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jkwyvK78VqUgKCW7wfISBRdrqwzf1Kodzs7ruamvtIU=; b=D5Ru9hGyjhBS53B37ljXqrmWLaB3v5X3SVhg2x4ETeouBF6YS+/h1URaZHx2uFVCiE 6/mfOdeYNgRNJPt0vl4lbE2gdQ3oafFb/zQ7HDvq1RriB74XHkvOqer7lZmk/d0vAkh0 ak3h/jr6gOh12ONpCjkxX7bYIg7ktmoGI1RPql1SkVdkj1AFxfbK9ms8mDvul67SwnbI lJVwuDQtSX8kGwSVBMODwniS0GA+lxQWOmfXZrSEtxcGO6eRNgfVG/gdGFpRy6xOP6YJ 44xG+8AgSf10V8GaJ0BDkIat2ftmYt3zqNH365Vv1mm5AS/Mu2KtVGlwlp6+sQMDh9oN gC0g== X-Forwarded-Encrypted: i=1; AJvYcCXqYn+svvLGbWy1qDeVzpBk9RPEf/LAsmdN/rzIqzt/+QL2UntJ/WeZyQkrip0WlBo+54IF0hIguCJbVXU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9qwOLi8Z9umR81rFYXY77YmmKEGw25aQSxPJsaafp9MgXLHay pBWvehtZywUZ3SddxkfCodrxLyIQIHhPTtjnbMjZcDuVZRirp7j2NENzLKgch1vifCQ= X-Gm-Gg: ASbGncuwu1/V8PhdLXkuqe8ftC5ZKAWfms4ruAsCQ3DIE1j/9fktXdSl5z3yFgEAi/b 0BKGMzArSu2mGZ61E9FXIOcajvrbUmUxPRbhBVQd7Kqvw3Auk/Ml1706BXrPzN0Ju0p9WZsjo7H sKMlYaOd+tgoPKO04ZTQ8kSsoCbKzGtWbv4uAm66Vf06oHOkUMP7qLyOheYvrjGIw4YKM9gFZN9 X/lx1EG4xsRLh963k7nxex9KTbfwwpKAjpSxMAa0OYVTDIAPnrr8eIan2+BrHu9hXV0OsKBuIeB nkku/FDgUofXcEGS4Ij6SRtn5s1VmEl45MT5UXTZbsRpG5y36FbspCRTKDvOqcB/i/4TPN8aD+w vlSzoHDC3oSrYBq7rure7yjXlNi46m68HzfMrCw== X-Google-Smtp-Source: AGHT+IGS7Wybf+10qczHDb+s/ZW1EOGQH6Fn273BtwmHQS/UKM1PO+aqhbN+skEAkwby7IIV0ZcOkw== X-Received: by 2002:a05:6000:26cc:b0:3a5:2ec5:35b8 with SMTP id ffacd0b85a97d-3a5319ba427mr2457378f8f.11.1749220982107; Fri, 06 Jun 2025 07:43:02 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229df09sm2085274f8f.6.2025.06.06.07.43.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 07:43:01 -0700 (PDT) Message-ID: <2ce9f14e-b0cf-41f4-84f0-6e80749b9504@linaro.org> Date: Fri, 6 Jun 2025 15:43:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2] media: venus: protect against spurious interrupts during probe To: Jorge Ramirez-Ortiz , quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250606123334.4114123-1-jorge.ramirez@oss.qualcomm.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250606123334.4114123-1-jorge.ramirez@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/06/2025 13:33, Jorge Ramirez-Ortiz wrote: > Make sure the interrupt handler is initialized before the interrupt is > registered. > > If the IRQ is registered before hfi_create(), it's possible that an > interrupt fires before the handler setup is complete, leading to a NULL > dereference. > > This error condition has been observed during system boot on Rb3Gen2. > > Signed-off-by: Jorge Ramirez-Ortiz > --- > v2: fix authorship > fix spelling mistake > > drivers/media/platform/qcom/venus/core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > index d305d74bb152..5bd99d0aafe4 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -424,13 +424,13 @@ static int venus_probe(struct platform_device *pdev) > INIT_DELAYED_WORK(&core->work, venus_sys_error_handler); > init_waitqueue_head(&core->sys_err_done); > > - ret = devm_request_threaded_irq(dev, core->irq, hfi_isr, venus_isr_thread, > - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, > - "venus", core); > + ret = hfi_create(core, &venus_core_ops); > if (ret) > goto err_core_put; > > - ret = hfi_create(core, &venus_core_ops); > + ret = devm_request_threaded_irq(dev, core->irq, hfi_isr, venus_isr_thread, > + IRQF_TRIGGER_HIGH | IRQF_ONESHOT, > + "venus", core); > if (ret) > goto err_core_put; > Please add a Fixes: tag. --- bod