From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933832AbdBQMpv (ORCPT ); Fri, 17 Feb 2017 07:45:51 -0500 Received: from smtp.math.uni-bielefeld.de ([129.70.45.10]:39131 "EHLO smtp.math.uni-bielefeld.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755620AbdBQMpt (ORCPT ); Fri, 17 Feb 2017 07:45:49 -0500 Subject: Re: [PATCH 0/8] ARM: sun8i: a33: Mali improvements To: Maxime Ripard Cc: ML dri-devel , Rob Herring , Mark Rutland , wens@csie.org, Greg Kroah-Hartman , thomas.petazzoni@free-electrons.com, devicetree@vger.kernel.org, linux-kernel , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org References: <10fd28cb-269a-ec38-ecfb-b7c86be3e716@math.uni-bielefeld.de> <20170216184524.cxcy2ux37yrwutla@lukather> From: Tobias Jakobi Message-ID: <2cecfc48-576f-3888-08aa-1fe2edc3c752@math.uni-bielefeld.de> Date: Fri, 17 Feb 2017 13:45:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46 MIME-Version: 1.0 In-Reply-To: <20170216184524.cxcy2ux37yrwutla@lukather> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Maxime, Maxime Ripard wrote: > Hi, > > On Thu, Feb 16, 2017 at 01:43:06PM +0100, Tobias Jakobi wrote: >> I was wondering about the following. Wasn't there some strict >> requirement about code going upstream, which also included that there >> was a full open-source driver stack for it? >> >> I don't see how this is the case for Mali, neither in the kernel, nor in >> userspace. I'm aware that the Mali kernel driver is open-source. But it >> is not upstream, maintained out of tree, and won't land upstream in its >> current form (no resemblence to a DRM driver at all). And let's not talk >> about the userspace part. >> >> So, why should this be here? > > The device tree is a representation of the hardware itself. The state > of the driver support doesn't change the hardware you're running on, > just like your BIOS/UEFI on x86 won't change the device it reports to > Linux based on whether it has a driver for it. Like Emil already said, the new bindings and the DT entries are solely introduced to support a proprietary out-of-tree module. The current workflow when introducing new DT entries is the following: - upstream a driver that uses the entries - THEN add the new entries I'm against adding such entries without having any upstream "consumer". With best wishes, Tobias > So yes, unfortunately, we don't have a driver upstream at the > moment. But that doesn't prevent us from describing the hardware > accurately. > > Maxime >