Re:[PATCH 09/13] drm/rockchip: dsi2: add support rk3576

["Andy Yan" <andyshrk@163.com>]

Hello Heiko,

At 2025-07-08 00:49:02, "Heiko Stuebner" <heiko@sntech.de> wrote:
>From: Guochun Huang <hero.huang@rock-chips.com>
>
>Add the necessary specific bits to support the rk3576-variant of the
>DW-DSI2 controller.
>
>Signed-off-by: Guochun Huang <hero.huang@rock-chips.com>
>[adapted from the vendor-kernel for mainline]
>Signed-off-by: Heiko Stuebner <heiko@sntech.de>


Reviewed-by: Andy Yan <andy.yan@rock-chips.com>


Thanks.

>---
> .../gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c  | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
>diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c
>index cdd490778756..0aea764e29b2 100644
>--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c
>+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c
>@@ -437,6 +437,15 @@ static void dw_mipi_dsi2_rockchip_remove(struct platform_device *pdev)
> 	dw_mipi_dsi2_remove(dsi2->dmd);
> }
> 
>+static const struct dsigrf_reg rk3576_dsi_grf_reg_fields[MAX_FIELDS] = {
>+	[TXREQCLKHS_EN]		= { 0x0028, 1,  1 },
>+	[GATING_EN]		= { 0x0028, 0,  0 },
>+	[IPI_SHUTDN]		= { 0x0028, 3,  3 },
>+	[IPI_COLORM]		= { 0x0028, 2,  2 },
>+	[IPI_COLOR_DEPTH]	= { 0x0028, 8, 11 },
>+	[IPI_FORMAT]		= { 0x0028, 4,  7 },
>+};
>+
> static const struct dsigrf_reg rk3588_dsi0_grf_reg_fields[MAX_FIELDS] = {
> 	[TXREQCLKHS_EN]		= { 0x0000, 11, 11 },
> 	[GATING_EN]		= { 0x0000, 10, 10 },
>@@ -455,6 +464,15 @@ static const struct dsigrf_reg rk3588_dsi1_grf_reg_fields[MAX_FIELDS] = {
> 	[IPI_FORMAT]		= { 0x0004,  0,  3 },
> };
> 
>+static const struct rockchip_dw_dsi2_chip_data rk3576_chip_data[] = {
>+	{
>+		.reg = 0x27d80000,
>+		.grf_regs = rk3576_dsi_grf_reg_fields,
>+		.max_bit_rate_per_lane = 2500000ULL,
>+	},
>+	{ /* sentinel */ }
>+};
>+
> static const struct rockchip_dw_dsi2_chip_data rk3588_chip_data[] = {
> 	{
> 		.reg = 0xfde20000,
>@@ -470,6 +488,9 @@ static const struct rockchip_dw_dsi2_chip_data rk3588_chip_data[] = {
> 
> static const struct of_device_id dw_mipi_dsi2_rockchip_dt_ids[] = {
> 	{
>+		.compatible = "rockchip,rk3576-mipi-dsi2",
>+		.data = &rk3576_chip_data,
>+	}, {
> 		.compatible = "rockchip,rk3588-mipi-dsi2",
> 		.data = &rk3588_chip_data,
> 	},
>-- 
>2.47.2