From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E49031619D for ; Mon, 8 Dec 2025 15:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765209416; cv=none; b=JN6onbWk3t6kywhq+ypwjXqGnBlHcJm9Yp5CGSaRzhQpJXpPs1KOfXe9es5GWlRhbKtsK5mHUKP7CTj7M5JY3jHKkKb3GPNJAm3QnOLAjJMZZKgXiPgjGmMrkxrw5hV1ZNTMnFvmCBROHPiKIngHJae2/bFww+5EjtiO8+Nu/G4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765209416; c=relaxed/simple; bh=B3ewkttHlUBU+PVS64xoM5O/gdT+zFTJecZrW6+HjH0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IYJznPWYJBWqrzrT5rwijeSqr0z5B0RPabJisw/u3NhyJ1pxPESBW/O0gonWtwKkpEWjetwEOPWqyMzkFedGlTAgIQPcYMG+Nwm7kS/646GV7HXM/YF3x5vns518/uCmXib8PGLsYG1Oec1BHSAGIShCp1o9zWkFMtUPOvmrNN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QuGYpO3s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cldhIJDR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QuGYpO3s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cldhIJDR" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B8ChleT850839 for ; Mon, 8 Dec 2025 15:56:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nmNVqKn1yKV+cg/ifGZvWwc5eUpensOq3hRgfoublXM=; b=QuGYpO3ssDKxKemx QdxitZxHqNdHxMLsM7OVBURhdDKboFx17BG/ukgqIv3zLxo9PFjpItYS1MEvSp35 tK+y+jUKubvQRu8TxJioHL3uSxZ8v8qpHOBGrPVApRqMNQAC6fAUzhvx01v5uR+Z YaJ3kvo1Vv2kSyITHC0CI4u2Q6A766DxaElkRO4s08/oqlpjr7DVJJCAq6Kb//k1 rKO8iZ+uAalYPURo24ks+07sdi9GMRK/mjDabdXntt76znV8aut6bGGv1SLmMJE+ 7iwSgWa22TfjkJcwJTlfxz7TqrI9hryWNhHtTZtU03GqoPFl1D+dlyydvzstuHrD Pl8chw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4awxxc0j3w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Dec 2025 15:56:53 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ed767bf637so2908521cf.1 for ; Mon, 08 Dec 2025 07:56:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765209412; x=1765814212; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nmNVqKn1yKV+cg/ifGZvWwc5eUpensOq3hRgfoublXM=; b=cldhIJDR9Ef1IvlgPv3zAiXGDV7gJsMAc568QDpkoeTukAEEtCFzy51CKl6wpv7pYT 6UXgzW/WHsC8sguQXFZoIzwWqkst+K7+gkZfEdCOPYGK9oz4Bfj4jX/fu+Ez+JkSXTeh R1SKpy9YRB8RzZsNThStwVPUBSIUE349fNGip6Nl9SDrEPDhS8PaXjwAPtnEG+ZSYKHK 3TyJ+wV6BNebMj+3p0x6/oc4XQE2ZbgUutvGEX0awET6onN67a9yfhFkDW9nscr1pglY HyS+R2NRqQ8M/USjzGVdEoEaPtzxCjHkmM7tcV0x1tYbnI7gVov3SrVA9RXd9lqHJ7f/ jA0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765209412; x=1765814212; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nmNVqKn1yKV+cg/ifGZvWwc5eUpensOq3hRgfoublXM=; b=kn6ZAwq4bqp0t4ilOgEvDMDEDTQSKNYIK/bEqWVSMw1mpsVNXoM8s3ScA6fGz0PDl+ I7bvqvHlQWE+4Ga0oHrlobTLho01LIOYF/ZR8DMpcfsX6bTQsyjJSk2YyKn2CJ9FOjmC aLUfc751ecxQgPUt2uqHWPvn5g+zt5FVftFX9QgZKmogJQ80BcZs9Cjn7jkMBLrRHFGT jx+su7M6WKK5k8bRUVgrh90wq06g+TFQVvCoIDfvi2dQs03EDGwBFL/rWiPUXSYI4X3N toGdzsLJJY8Xbdv8abSODrMi3G6xcQLEkTUIdl1iXEazOHVqYEXyKhnI7Zzm4KJcREYO ro4g== X-Forwarded-Encrypted: i=1; AJvYcCVFKsoef60s2pQLi4l2zqkuqaRrrlol75e2kSt3MvAI85PwQLRmdLN/uwEQeQZmGaSWGNyp88xjQse1ERQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyAXmJgaT12hw8Szgm8uHJY5/wg6/TOAIZzkXhpjpWEtJQWZpR5 IXzWNYM3whtFXi9E1EdOePskW14WALhf48l4pMRqeogntpnROblp1cfvmXVj3eZOqeiptXIFfi4 TIhLYl0XdSxgpYtHBBTygqLGcRZzwsVElrjWaXhA0Y9CktPH4hP616eegBazcb8b3828= X-Gm-Gg: ASbGncuCLDKYiR0Cwd5cjcygCo5Df6NCMafWzXvXh/F8Nn3zJE/K/xKmRpINoOMJgeC lfkrwO93Kp+2nfOSDzx2S1A0trXMZsD4UdPHR5QlEbqeSujgD3nLfbolnVIkwxznbnsHoBqwwtp jQeyiediUy1SvKkmx5wafrMH4F8d8nQ2k0fhEHJPqWIr/rlgORnX4PQ2VQ/V6he9zC2iiWKpiN0 rUzgABnT2i4z6Iy0VdCZuQSjDALwCfedMI0JZWk0K565e83um29mjWsa/t/smuoIaQsSNyy7u0g fjPhBoNiLEarjkPzdEUyCiCAnTT3uYE1OQVbsdJ6kEpPVON0oyqZ8zqiw8RNm1Cz3UqWK4HoQvn 7dobh4Jqruvjs/obwri7G7LQc/9DCi2GDb0m6k9c4hIxaDSduF/15Y3gk2pxTlq2JaQ== X-Received: by 2002:a05:622a:188a:b0:4ee:1c71:71e1 with SMTP id d75a77b69052e-4f03fea6010mr85159321cf.6.1765209412455; Mon, 08 Dec 2025 07:56:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/MhiREKtDNGvh9NmEtfBer4t1W4ElwFVJmK2dUCg/qDDPq12BZEpCpvof8t9/DxZAthncVA== X-Received: by 2002:a05:622a:188a:b0:4ee:1c71:71e1 with SMTP id d75a77b69052e-4f03fea6010mr85159131cf.6.1765209412012; Mon, 08 Dec 2025 07:56:52 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f44595ecsm1142187366b.2.2025.12.08.07.56.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 07:56:51 -0800 (PST) Message-ID: <2cf32f08-99e9-48c2-ad0f-2e579d50f7a9@oss.qualcomm.com> Date: Mon, 8 Dec 2025 16:56:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] arm64: dts: qcom: x1e80100: Add crypto engine To: Harshal Dev , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Val Packett , Stephan Gerhold , Abel Vesa , Udit Tiwari , Neeraj Soni References: <20251208-crypto_dt_node_x1e80100-v4-1-f5d03bb2c501@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251208-crypto_dt_node_x1e80100-v4-1-f5d03bb2c501@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: mU-XRwi8CstLGyLX1AcxKkUpifn6eYXv X-Proofpoint-ORIG-GUID: mU-XRwi8CstLGyLX1AcxKkUpifn6eYXv X-Authority-Analysis: v=2.4 cv=AKf9OaRj c=1 sm=1 tr=0 ts=6936f545 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=9v3PK4M2jcTnJOkuZv0A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDEzNSBTYWx0ZWRfX+/9COWvncHFC aaVgCBAgQ+bmOnXXlVdwicQe59x2HukZ7y7uP2y6trZxwhFeR03VP3OqQkAGyC/zzqAxUEoI1xw KYLMG6yiQl88NeXwL74cTknrfTNwi+X1mkVFcA7GAtc2dMhmYJNaAGxm3rDXWYV65L2xMQ4uvkN GY/Im1OQyjAsN5rE7VrHQBSlnXt5jtXr8GfERL2g49k77on6H0ZrSWVgake5kWScjsYlYm/Ssm6 GmMsIPl6H97CkQWHTmH3yG1A1kSLZVHIhJcuC2zoROOo1RwAMQettu02ZhTPSnUBU3fe2xAjX83 lz9maKSTsQvJI+oaR0LD/crjdNT6Gve5HrWnspDjpT+0eMegnuwbOqq2nWd1nNpJE92GUlgGRjT tRWWT0T7TpOK5vs/ljYLG+O8Lp5s9A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080135 On 12/8/25 1:32 PM, Harshal Dev wrote: > On X Elite, there is a crypto engine IP block similar to ones found on > SM8x50 platforms. > > Describe the crypto engine and its BAM. > > Signed-off-by: Harshal Dev > --- > The dt-binding schema update for the x1e80100 compatible is here > (already merged): > > https://lore.kernel.org/all/20250213-dt-bindings-qcom-qce-x1e80100-v1-1-d17ef73a1c12@linaro.org/ > --- > + cryptobam: dma-controller@1dc4000 { > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > + reg = <0x0 0x01dc4000 0x0 0x28000>; > + interrupts = ; > + #dma-cells = <1>; > + iommus = <&apps_smmu 0x480 0x0>, > + <&apps_smmu 0x481 0x0>; > + qcom,ee = <0>; > + qcom,controlled-remotely; > + num-channels = <20>; > + qcom,num-ees = <4>; > + }; > + > + crypto: crypto@1dfa000 { > + compatible = "qcom,x1e80100-qce", "qcom,sm8150-qce", "qcom,qce"; > + reg = <0x0 0x01dfa000 0x0 0x6000>; > + dmas = <&cryptobam 4>, <&cryptobam 5>; > + dma-names = "rx", > + "tx"; > + iommus = <&apps_smmu 0x480 0x0>, > + <&apps_smmu 0x481 0x0>; > + interconnects = <&aggre2_noc MASTER_CRYPTO QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > + interconnect-names = "memory"; > + }; > + > cnoc_main: interconnect@1500000 { Right as I hit enter for the rb message, I noticed the nodes you're adding are not sorted - please sort them wrt the unit address (@foo) and retain my tag then Konrad