mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francesco Fusco <ffusco@redhat.com>
To: acme@infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] tools: perf: util: fix include for non x86 architectures
Date: Mon, 27 Jan 2014 14:39:13 +0100	[thread overview]
Message-ID: <2cf8143aad65a6aa6fe30325ef8a65847141afa2.1390829373.git.ffusco@redhat.com> (raw)
In-Reply-To: <cover.1390829373.git.ffusco@redhat.com>

Commit 71ae8aac ("lib: introduce arch optimized hash library")
added an include to <linux/hash.h> for setting up an architecture
specific fast hash. Since perf includes directly the non-uapi
kernel header, it cannot find <asm/hash.h> on non-x86 and thus
prevents perf to be compiled on every architecture other than
x86. The problem is the inclusion of <asm/hash.h> in hash.h
that results in the following error originating from
util/evlist.c:

  fatal error: asm/hash.h: No such file or directory

This commit simply adds an empty <asm/hash.h> stub/file to fix
the compile issue on non-x86 architectures. As perf does not use
any of these new functions, it fixes the compilation and therefore
seems to be the most appropriate solution to go with.

Signed-off-by: Francesco Fusco <ffusco@redhat.com>
---
 tools/perf/util/include/asm/hash.h | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 tools/perf/util/include/asm/hash.h

diff --git a/tools/perf/util/include/asm/hash.h b/tools/perf/util/include/asm/hash.h
new file mode 100644
index 0000000..d82b170b
--- /dev/null
+++ b/tools/perf/util/include/asm/hash.h
@@ -0,0 +1,6 @@
+#ifndef __ASM_GENERIC_HASH_H
+#define __ASM_GENERIC_HASH_H
+
+/* Stub */
+
+#endif /* __ASM_GENERIC_HASH_H */
-- 
1.8.3.1


       reply	other threads:[~2014-01-27 13:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1390829373.git.ffusco@redhat.com>
2014-01-27 13:39 ` Francesco Fusco [this message]
2014-02-02  8:54   ` [tip:perf/urgent] perf tools: Fix " tip-bot for Francesco Fusco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cf8143aad65a6aa6fe30325ef8a65847141afa2.1390829373.git.ffusco@redhat.com \
    --to=ffusco@redhat.com \
    --cc=acme@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®