From: Vasily Averin <vvs@virtuozzo.com>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] lost path_put in perf_fill_ns_link_info
Date: Wed, 8 Nov 2017 16:04:47 +0300 [thread overview]
Message-ID: <2d0707fa-7265-8b82-23a0-b3a938111767@virtuozzo.com> (raw)
In-Reply-To: <20171108120915.n7i46j2yly6fb7bj@ukko.fi.intel.com>
On 2017-11-08 15:09, Alexander Shishkin wrote:
> On Mon, Nov 06, 2017 at 09:22:18AM +0300, Vasily Averin wrote:
>> Fixes: commit e422267322cd ("perf: Add PERF_RECORD_NAMESPACES to include namespaces related info")
>> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
>
> The change description is missing. One needs to open the source code and
> look for proof of correctness for this patch.
perf_fill_ns_link_info() calls ns_get_path()
it returns ns_path with increased mnt and dentry counters.
Problem is that nodody decrement these counters.
You can call ./perf record --namespaces unshare -m
and look how grows mount counter on nsfs_mnt.
next prev parent reply other threads:[~2017-11-08 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 6:22 Vasily Averin
2017-11-06 6:34 ` Vasily Averin
2017-11-07 19:03 ` Andrei Vagin
2017-11-07 19:51 ` Andrei Vagin
[not found] ` <20171108120915.n7i46j2yly6fb7bj@ukko.fi.intel.com>
2017-11-08 13:04 ` Vasily Averin [this message]
2017-11-15 5:48 ` [PATCH] " Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d0707fa-7265-8b82-23a0-b3a938111767@virtuozzo.com \
--to=vvs@virtuozzo.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=hbathini@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®