From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 805DC35C1BA for ; Tue, 13 Jan 2026 08:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768291862; cv=none; b=dK4doQEiK+HVP80QvOdu65huwYp4xnvyGxdqC64OcDyznd0wp+7YP+vMQYUobEjRmPp/aOloRcBBhIClHI1h+4HbvJK0Re9IRs98PQ7QJf/0OXBYyGLDFJgzlUjYH66hhkFa5gytRL9h2wicZDK5BU2VH0ZzUtVYlrwFMuoF1Jo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768291862; c=relaxed/simple; bh=awFrvdugpRSWBPPFDwN9LrXRF+GIj550SIcZ6bTMTWU=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=VuThA4iW+2mtVrqSby/TKQO5YVrF9jlmw8nWkmUiC3S5sVB2KcngcCuy5La1YRif/zRfrcp1LxaIGr3aOQ39UVsRC0GANjgpLb2xiTZF6EozqZLKalFjzy+CAmeKo2Jjk5aq5vwra4HwR8JacABziW1Gf5rQTEVlgVndJq2xCx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tLFG8wjL; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tLFG8wjL" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-47d182a8c6cso42380975e9.1 for ; Tue, 13 Jan 2026 00:10:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768291858; x=1768896658; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=bwW+ygfqdK5UYdKdlacSQmA5THvQFOrd2NY1OQuLwqQ=; b=tLFG8wjL2YlzdoFl2tKoBy7Yo7dmp1RGnGvbAjeyGDpDnLxen4nD/571v+ERd7zZU6 AvGnS9BwCkFtCt3QNar4kP45SBZgD/bBj5eW/Dj9DsAzjpm3uRcmuqm7S3V7XeZ+SbnI 7EWjZpUbk9T301xs/t6AlO53Q/k9LAqkrGLls6a0WgSZHYhBsd2tJuC/QV1uznsDb6uE D+jvXGs1CaHzOTcOKYrKui3zD5OnmbgemKh2rxWEm2UyHT6TBGoVPPwmfZEc430nTN2m fyzrgQ9RL3PJ7gAl3rWtb2/h7xbT7t8AG70y/4WGlEOiDsnwwbnKkzCHkzkgdiW5kQSH gzMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768291858; x=1768896658; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bwW+ygfqdK5UYdKdlacSQmA5THvQFOrd2NY1OQuLwqQ=; b=ty4pmsrKGifQNE/BcTX4qUf9RycMu4SN6sOxk9tt037cWmM1yLVlYcyhK52Dv3zuE3 WKyzRJ5y0aJM793ZMDwkrm5PjbgjIY9wx4a/DV9oCu/EF1NZN+HmbCnF4fgsncRLG497 mTLRM7rpZ32aIGh4K4BJWkYFLFMiQJjN+2O55D6Imt8I7CFkgOZnrtUwHFd3aRle3IBv stMDms9qEOOhK6Ve8w2R7V2gdSwj4Q834U3m2OuaD1kxOXt2iKfNbZr2STeCAivQAxrs U8vnmtleEgvamCxpH418JhgCofPklw3doaXG5xlgdLXLHHVV5NdF1+Zp/xsfmQAERpY0 ynrQ== X-Forwarded-Encrypted: i=1; AJvYcCWlybS0ukRcBuY+3066P5Qj3ftFeJcUxLZ6s1BD8EmkYgYGewBkh75vDaB//ti3Q7lyBHBOweIIfdoRsCo=@vger.kernel.org X-Gm-Message-State: AOJu0YwpElhSl2bo0ZVK+GJh3x5R9B6LbFQ8oDObYQvApcqK3XcX7EZ6 b+ngOGxaY5ksguSMy14NO4WUDz4lm6HPZt1OUpOdQ0AVF/GCISNPLdYRQyt5JqD2zBU= X-Gm-Gg: AY/fxX7AbrQgx2hEtOWjuaCqRRU2BH5tJ9zhuvbStAgKwFIWWS6f0EIo2xB5PzcemM1 3pTPSZ5CZthdzih/k5i5LxFeJbdNGP+0CUhoJ/Z1x+kV1q+S7RFCGcRMv+lEu0A+2rTo+sOYKOb VM+Efs8BxCpqiWt2ZyrQzLN2/57TqlyZDyfHiw/BhjBNqqm6yCO75d3hPCDA6JdZpSMLA2Fxh/e OUlegdNUjv7e4jt8Krd9ICtUEFykSCfhyS8SO8AtC7YG58ei8R36r+9vaiSCJg68lT3iO1YHiLo McXMRzchxuiDpmIeCt/TL3G5f30w4SdbciXe3k07xjyekerCPEBx0ERpzbbYYF4cRB9ZFojZc2L ZaGo1QxQnDdvWVDhW6aQ/oon/hQ8CQafN7lDmzp8KShC7N7JEzAr10xkoWS5Hn++M5zKKfw3Bya HYt+49TrcEVa4zEzoiV6a7OSGeaTsis3P0WnuTXhg= X-Google-Smtp-Source: AGHT+IHVubdkYVXRdCYANXMR0ISA+TInCn3bu5ON04/WkSf5bxAVISHMRL30pKlB6Nx3R6Ym8XxdTQ== X-Received: by 2002:a05:600c:3484:b0:479:2a0b:180d with SMTP id 5b1f17b1804b1-47d84b20fd7mr244456025e9.11.1768291858442; Tue, 13 Jan 2026 00:10:58 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080::fa42:7768? ([2a01:e0a:3d9:2080::fa42:7768]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47edc05b267sm16025705e9.15.2026.01.13.00.10.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 00:10:57 -0800 (PST) Message-ID: <2d07b633-becc-4b79-adfa-932ae2847671@linaro.org> Date: Tue, 13 Jan 2026 09:10:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100) To: Val Packett , Vinod Koul , Abel Vesa , Dmitry Baryshkov Cc: Abel Vesa , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260111083317.604754-1-val@packett.cool> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260111083317.604754-1-val@packett.cool> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/11/26 09:25, Val Packett wrote: > For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a > stub implementation was added for the v4 of the hardware. However it > was omitted for the v6, causing a NULL pointer dereference oops on > Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub. > > Fixes: add66a6673bc ("phy: qcom: edp: Add Glymur platform support") > Reviewed-by: Abel Vesa > Signed-off-by: Val Packett > --- > v2: pull R-b, reuse v4 function as suggested by Konrad > v1: https://lore.kernel.org/all/20260109045214.5983-1-val@packett.cool/ > > drivers/phy/qualcomm/phy-qcom-edp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c > index 13feab99feec..7372de05a0b8 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -758,6 +758,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v6 = { > .com_power_on = qcom_edp_phy_power_on_v6, > .com_resetsm_cntrl = qcom_edp_phy_com_resetsm_cntrl_v6, > .com_bias_en_clkbuflr = qcom_edp_com_bias_en_clkbuflr_v6, > + .com_clk_fwd_cfg = qcom_edp_com_clk_fwd_cfg_v4, > .com_configure_pll = qcom_edp_com_configure_pll_v6, > .com_configure_ssc = qcom_edp_com_configure_ssc_v6, > }; Reviewed-by: Neil Armstrong Thanks, Neil