From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751441AbdFZKxD (ORCPT ); Mon, 26 Jun 2017 06:53:03 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:8852 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353AbdFZKw5 (ORCPT ); Mon, 26 Jun 2017 06:52:57 -0400 Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: report # of free inodes more precisely To: Jaegeuk Kim , , , References: <20170624162522.48931-1-jaegeuk@kernel.org> <20170624162522.48931-2-jaegeuk@kernel.org> From: Chao Yu Message-ID: <2d091ab2-cf3a-5185-99d1-59c606c9b9dc@huawei.com> Date: Mon, 26 Jun 2017 18:52:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170624162522.48931-2-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.5950E77F.0094,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 402c8076e82dcc87cc8dcb9edcf5bfa7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, On 2017/6/25 0:25, Jaegeuk Kim wrote: > If the partition is small, we don't need to report total # of inodes including > hidden free nodes. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/super.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 8e39b850bfc0..3da6fb276f8b 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -680,6 +680,7 @@ static int f2fs_statfs(struct dentry *dentry, struct kstatfs *buf) > struct f2fs_sb_info *sbi = F2FS_SB(sb); > u64 id = huge_encode_dev(sb->s_bdev->bd_dev); > block_t total_count, user_block_count, start_count, ovp_count; > + u64 avail_node_count; > > total_count = le64_to_cpu(sbi->raw_super->block_count); > user_block_count = sbi->user_block_count; > @@ -692,9 +693,16 @@ static int f2fs_statfs(struct dentry *dentry, struct kstatfs *buf) > buf->f_bfree = user_block_count - valid_user_blocks(sbi) + ovp_count; > buf->f_bavail = user_block_count - valid_user_blocks(sbi); > > - buf->f_files = sbi->total_node_count - F2FS_RESERVED_NODE_NUM; > - buf->f_ffree = min(buf->f_files - valid_node_count(sbi), > - buf->f_bavail); > + avail_node_count = sbi->total_node_count - F2FS_RESERVED_NODE_NUM; > + > + if (avail_node_count > user_block_count) { > + buf->f_files = user_block_count; > + buf->f_ffree = buf->f_bavail; f_ffree is limited both by remained free nid count and free block count, so it needs to change like this? if (avail_node_count > user_block_count) avail_node_count = user_block_count; buf->f_files = avail_node_count; buf->f_ffree = min(avail_node_count - valid_node_count(sbi), buf->f_bavail); Thanks, > + } else { > + buf->f_files = avail_node_count; > + buf->f_ffree = min(avail_node_count - valid_node_count(sbi), > + buf->f_bavail); > + } > > buf->f_namelen = F2FS_NAME_LEN; > buf->f_fsid.val[0] = (u32)id; >