From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B03B481640 for ; Wed, 1 Jul 2026 13:22:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782912133; cv=none; b=An/aGhZew5xUxHQVKijjav3lGqxjISqdKEznZfsRG+Aisofs5pKUej3BzUjd2BqlYp+2g5yanjUGzfeUhOYoNTh51dHvY5pEQrC3HZmKwmtGbNfKxAEV91zAIJHXx86VRlfhTMLG0SeCf1464oUFUQ3XUKxbgVhLpNVXQaJMIbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782912133; c=relaxed/simple; bh=fC6o33yVMtcIYR9TGEh2aBJOZuz3UTNnUSTzAlE4OAI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=soGN+qI7F6yKH0C1hW5XDIslQfgr7stobjkot6EOD3hcsL7QtIAxYNBKolKc/n+KRwqKEY53Q01dMt0S4K4g9fJutyARR4usALQKW1noG1yvkcKRPvhLjcL27kxV42KLv+tkG+r9W4ZlJVVQZOZqdmIRCGjkKfaftRYqDAW7IAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pb8ZsrfQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Mb3MRnSS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pb8ZsrfQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Mb3MRnSS" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 661DL8X21080339 for ; Wed, 1 Jul 2026 13:22:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4EtLGdtoQuRHwGrQtERVgenV97LkHCFN0PODLn7CO1Q=; b=pb8ZsrfQ4g1e5br5 /GWLrG34NMoDh8m7JyLzyPmPcO0D641l3uzdS9TZCUuIWVSv9bdJ0m6VrDZbv946 FwF0J2RiXr1BrptUz0SNmKELGXRPX18v2k6Xb6lXp6SBhaxuHo3V67bey+B/tTEq +1egNH66jSwUyxPkmgnBA+mQ9mC76/3MXID/rRREh+c9NJVEu57FzT075wcOxIk+ t5x6TQfQKzG2ytsfHVV7+J9xMZtkJM/uR2KV2CrR0084UmNOcHiWgyAH/PsdqyrQ /vrQKRCKL11Ixxvoken/SIDiP2w+XQyBlBBqDyHHhXQxSR8B+LnX/Q9YSGvnpxDu q5zPRA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f53q0806v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 13:22:11 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51bf9df2eabso840401cf.0 for ; Wed, 01 Jul 2026 06:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782912130; x=1783516930; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4EtLGdtoQuRHwGrQtERVgenV97LkHCFN0PODLn7CO1Q=; b=Mb3MRnSSZnyANNeis4SfC3lWlMaX3YVdLC1vedItZEK4ILlMjPyaXVNUveKl2o3x7d H8SRnHhcOS+N9Bsd1NNKqUtqi0+y4euQ1hQpXUy4e469nB/bp3N3gBtYPc7jVHnvElwO hzyAYzyxWvsqY9bqo5H5kUZ1I5Ii+9zwO+qPRmOKTx6mEDGv0a/PiHdHJAE4DzzgWmus JNbs8o+ChRG+//UrxNetnYmOEBFciz8Ix0cHQESTgioUXDfxLHKVVIgBsgd2X6iRywG6 G+GvMX6DBnhhC2vnalCWEq671IGvYn4H1teYg7iBTc7tzLW0pCJrLJsHsmiJdD6g0TB7 DCig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782912130; x=1783516930; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4EtLGdtoQuRHwGrQtERVgenV97LkHCFN0PODLn7CO1Q=; b=byBrZNRmQdTvEIgcEtzMEaTqUZLlJBrgjqin57FjiEp8mlRIsdeqJkb8gMbp5RnEqf 3YL48dKYiy0JsslxNtRpIwOcUNbk5ngv/VFnxBzNx0YEIwrCFxLW6Fvm8n8FYVQsYAZh TMrPtesUKbrLkKM9ZI8iRLa5JSMYV2kVw5N+PGqQNxvR4qpiKjXCOCPExt8EIXsB00hz AX4H4hwTS6xsqI82gXvaad3512JPzC0CQgY6U9MqjujVr/HGJbshlQAtlaWbo6T1SsOp R2PAkoa6V/PraQDKRZW72P9s8//ez0dCsd5GD58mq+nkI1r00MY+hdDxgmztz563rsy5 rAtA== X-Forwarded-Encrypted: i=1; AFNElJ+qwIgvpVwiXJm10rQoSgrdtrAeIBjsWSpp5QMfP7zhZkqSjmx92CHehFKik6Awsz8sV74MVviX1gu+Lwk=@vger.kernel.org X-Gm-Message-State: AOJu0YyCc3LumK10a6MQJuPug6T3MxvajqI6pfNV+6dHb1EQCiHvefAr Asw/2W0WXv//pDOBuIdxFwb2QQISl2MJE01WMfGGmWki2UWHiclgxWyTa4whnNFPcQ3d7OnutET TNregG4RNRkcgp9Ap4OZ1zAIvIWGPMWj1dU+pPeOnIKIbS/utX9BiihHpgDgs1qdR0ow= X-Gm-Gg: AfdE7ckMf2GnDb2IH2irnlAWWIWYV6XtsFLIbPdr/9wtKmfiUPmPwJaabphtJdlS4T6 sGyQiJubm7u3DnP8FmiWEPSdh6SBj0h4guLzkOSj3SscQq6wlJN6G8sCIkRJfJceNHw7BmQT9cL xKRqCxzM0KbNixkURE9RU9HwUl+3FcbqYlgeqz2Kg8pGknrZ+f4gNjIz4NyK+36ybsXyEX1Vkhb 2aDqL6utmeMTAeMK9rS+G31glwmx3fTaNVkC3eEmqy9YrE4YkIrtcjlOT0nUKHBHrywkwBkdjDt LWUwvKCavEidUWHN/WeCdDM3RBdx2+b9OtlyX5NoMrHvJIXZ4A0QndUrbIsAYxXv4quzRja6UI7 5tFWg1T41N/JVfZnxylsgXMsz5i2cWgNquRo= X-Received: by 2002:a05:622a:58b:b0:51c:d8f:d77a with SMTP id d75a77b69052e-51c26a560f2mr13435971cf.1.1782912130333; Wed, 01 Jul 2026 06:22:10 -0700 (PDT) X-Received: by 2002:a05:622a:58b:b0:51c:d8f:d77a with SMTP id d75a77b69052e-51c26a560f2mr13435061cf.1.1782912129446; Wed, 01 Jul 2026 06:22:09 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288dbf4b4sm274203066b.28.2026.07.01.06.22.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 06:22:08 -0700 (PDT) Message-ID: <2d0d3df1-31ae-439e-9970-f7d3f589754b@oss.qualcomm.com> Date: Wed, 1 Jul 2026 15:22:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] clk: qcom: gcc-nord: mark PCIe link clocks as critical To: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Shawn Guo , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Konrad Dybcio Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260623-nords_mm_v1-v1-0-860c84539804@oss.qualcomm.com> <20260623-nords_mm_v1-v1-1-860c84539804@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260623-nords_mm_v1-v1-1-860c84539804@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dtnrzVg4 c=1 sm=1 tr=0 ts=6a451483 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=te8iVueUN0VzZH6eLK0A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: rbQu7x8Vt_kqbIDM9hVd9wU3GcuAu62I X-Proofpoint-GUID: rbQu7x8Vt_kqbIDM9hVd9wU3GcuAu62I X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDEzOSBTYWx0ZWRfX/M3pDVyVqmNB Rla8DsNBKf7G+RDHGD67Sze+EvcinPhW72jj5xkTjiSdHU1cKfYHvhbnyRWsQqwcl1it8phO7ZE CDS0XCtc3HJU+dDF+o2+77Dl0UKZLTBOdqdPAkP/jV7zX76BKzlGiHdK7mfH4+O2B6M32E2rzcK /Oa631lwBp+W5Z7Nc3f7pnh9Ei3TYxRsNeV+3A/nId5kIE9zH+hpdGMj0VQ7Csm19eYBt/jHgC6 n5u1jk70sHPebOysm0ZCTaHd2QcAJbICiD5mpfvje2FN4hdbsZwOnsqJhcM8rw3Je6fLw1QU3qM DK33JjR5rjAiDF2BU2JMmU3GFGebo5SRZyf9pL8dJpcocVg37dicCiz6zrSO12Liq6Cs5riIQnT jEZlqcOZejUtISIrK2GJaFfzjcCHcMNItn+dG+3IV2Z74nlmMZMlc/w/R9boy0Dqo8eV7+/SYi5 Jha7CwImFLWWv5K233w== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDEzOSBTYWx0ZWRfX0ZQf8b20+t2A p+DFZMTDaL6LcqZySGYmo38V/CWAMcnbGwdibBAZ5mJjaJi+XZziJt6L9D4ssbGZlfKVMJiUPD8 GlKhXOx6HKfwbioUj6VS3rBd4syMDrs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010139 On 6/23/26 12:54 PM, Taniya Das wrote: > The PCIe link AHB and XO clocks must remain enabled for proper > operation. Representing them as clk_branch instances allows them > to be gated, which is undesirable. > > Remove their clk_branch definitions and register their CBCRs as > critical clocks instead so they remain enabled. > > This matches the handling of similar always-on clocks in other > Qualcomm clock drivers. > > Fixes: a4f780cd5c7a ("clk: qcom: gcc: Add multiple global clock controller driver for Nord SoC") > Signed-off-by: Taniya Das > --- Reviewed-by: Konrad Dybcio Konrad