From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27A941DC9AE for ; Mon, 6 Jan 2025 11:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736161358; cv=none; b=G3rMGNJ/5XFher/huO1lARl37alcPkCuUvZmzzbV7Udg7iOvYFeJJq7JuEmYgJy8vdeeFwHzYhBsXQ/BhxYv+eWnolnZKUCruD01KeYumCkr+4JcD+BRA69v5LOAMcCwezvp+hf8t80vK8RiPl2BXiMfh7OIqkris2q5xPJbQUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736161358; c=relaxed/simple; bh=30+xZQfb9yDuTIOe+TrzSZCg5DGlryILzZEnHJoiL0s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HotLhuJ++OluDy8eyetOYgD5mfTBxR8n7ZuS1tefOQkWy8/tAAToFZ7UUSP/OdfmvyWcdBaz0aMd0egKNhotRD635NA2yoaiBK7sykQnsVE21bzo4I+N08LZo+Tw7kp5s986e38n8f4Cpijv3wjzpQAVtp6G31Jw1wNG2tn6Z9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=e9BO8x11; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="e9BO8x11" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-216401de828so190698105ad.3 for ; Mon, 06 Jan 2025 03:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736161353; x=1736766153; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PtS7kKDFbbWBE6dlgb91yolih02/BD7li/VWMu2pf+Q=; b=e9BO8x11AH1QgI2kujJM472/6w1404H4PqWRzvoLs6Ix6ioP/bqjGrP8Z5j3y4WpXp P+oA+YYEpj2Hc1pKU2uZ2W5b49ym4KW7g5+BPwd9hw/NoDEQRiLgyFFaTBYmPtz/IqVm ACUrR3yo7UfwChTyck1sE6Mul1LfbGfDLU4l2cDJuHc08hZof/pXPnaWZ27o5ZTHJwZq CW5/tXH/s0eQNmiBJp9TunpWGl+11v2xKlWpJriisZ1p/weaU+bt1YkNllR+0Zlbb0Ng 6hfA8PzCu+YbpoKwd7eyy+IlKqLTOCS+0Lnu+7obXPAgPYLbU6nq8WxJnpcdlHTKX5YE S33g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736161353; x=1736766153; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PtS7kKDFbbWBE6dlgb91yolih02/BD7li/VWMu2pf+Q=; b=TVE8Lt3Sc81RGipE+5L77Ll1FV5kv3zT2jL0Q2Dr1kTQSBQvBETPfkLYAc292uztZ1 EIYOuQTegNQy0354MjRhCFWlLoTMe5ZfEeZDmA9ur8Lm+A+V5VgS58bpdXCSTyqy69Jw eIVBO7RH5XTTYsIIH+tGoHzvgYnD5l3/Ro7lEVXTUndnOTZA2yeqql+ryH/7DMWEZFjT 27p75bmpMoHrxUjezchu0n+AVIhuzhraQmwOrq/bZinAPSHCt0tgrhjwRpAwZFKTHY+l iFjL5qzb3Zg0KQ+Q6eCvp2Xg5OQbIVIxPxWoClWa6VTy5/3/pCiVKgIR8YIlgmTHBs7K tz6w== X-Forwarded-Encrypted: i=1; AJvYcCXQlNcWpaCsYmqFKFebZ52U3a4mq9JcL40MR3XVDRmS9Ezc6x3ooC3CtPb83xuK4KqPQJpJ9Ml25TdLks0=@vger.kernel.org X-Gm-Message-State: AOJu0YyBntzBRchSHSNwFGPZHKBtf9vtjmoYoOf5iKEbEnc+s7Jajmoj S6n/rF20jjLTbpMMCMXq+xQNiBJh7oijXu/wyOEq9F7wt+nINBlgD2ZNx5QO6w4= X-Gm-Gg: ASbGnctGTjl7lTwupXQJfoFX93MPDI9HVq+/racKgH5b2wYBy0yAVuE56VVQsvnbEga h+L3qUOaGhAygwbTf2CbOyIgSNtgV01uLVvbH5NplxZ70RAnuNABzYec/NUC17SO46f7kEHyfMk RpkmzwbLp+d3p0QAoSN1+DVSEuOCtwSvuboZpLHfp2aYl7KQQyTUZOc1zSOlBORI1jaMGO+O2Gs uwjEYQ2vYTn9aOJO7JQFcj4Pkdg5WPnzgUSHoRShLReXg/ButiuGzPOcs2ejklK7zcQmjfJKdiE 7r1IEQ== X-Google-Smtp-Source: AGHT+IFCeOw2arXEHpOUWAGun1CKXf9/XTpPQ1dFbIMLlKInW35U2LjXZ6DtTEzjdru/7w1/tbEHpw== X-Received: by 2002:a05:6a00:4644:b0:725:b347:c3cc with SMTP id d2e1a72fcca58-72abdeb9c33mr83929136b3a.23.1736161353534; Mon, 06 Jan 2025 03:02:33 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.150]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad816464sm31123318b3a.40.2025.01.06.03.02.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 03:02:33 -0800 (PST) Message-ID: <2d16f0fe-9c7f-4229-b7b5-ffa3ab1b1143@bytedance.com> Date: Mon, 6 Jan 2025 19:02:17 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table() Content-Language: en-US To: Alexander Gordeev Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/1/6 18:36, Alexander Gordeev wrote: > On Mon, Dec 30, 2024 at 05:07:47PM +0800, Qi Zheng wrote: >> To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of >> PMD|PUD|P4D to __tlb_remove_table(). > > The above and Subject are still incorrect: pagetable_dtor() is > called from pagetable_dtor_free(), not from __tlb_remove_table(). Hmm, __tlb_remove_table() calls pagetable_dtor_free(), so moving to pagetable_dtor_free() means moving to __tlb_remove_table(). Right? And the main purpose of this patch is also to move pagetable_dtor() to __tlb_remove_table(). So I think this description makes sense? > > ... >> diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c >> index 569de24d33761..c73b89811a264 100644 >> --- a/arch/s390/mm/pgalloc.c >> +++ b/arch/s390/mm/pgalloc.c >> @@ -180,7 +180,7 @@ unsigned long *page_table_alloc(struct mm_struct *mm) >> return table; >> } >> >> -static void pagetable_pte_dtor_free(struct ptdesc *ptdesc) >> +static void pagetable_dtor_free(struct ptdesc *ptdesc) >> { >> pagetable_dtor(ptdesc); >> pagetable_free(ptdesc); >> @@ -190,20 +190,14 @@ void page_table_free(struct mm_struct *mm, unsigned long *table) >> { >> struct ptdesc *ptdesc = virt_to_ptdesc(table); >> >> - pagetable_pte_dtor_free(ptdesc); >> + pagetable_dtor_free(ptdesc); >> } >> >> void __tlb_remove_table(void *table) >> { >> struct ptdesc *ptdesc = virt_to_ptdesc(table); >> - struct page *page = ptdesc_page(ptdesc); >> >> - if (compound_order(page) == CRST_ALLOC_ORDER) { >> - /* pmd, pud, or p4d */ >> - pagetable_free(ptdesc); >> - return; >> - } >> - pagetable_pte_dtor_free(ptdesc); >> + pagetable_dtor_free(ptdesc); >> }