From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F31B39C00C for ; Tue, 7 Apr 2026 11:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775561854; cv=none; b=Itpk+0e9lP5Mr4R37cn7u7fk+bF6wEpwebdL92wnKd5KM6qyB1tLYFJt0zuapLcUTa7GZz3YJE8UHINDVIGnSQMQ0KIdHaAeO4oZ3NUTEsOC5+bh08VuNuBQ+mhkOhjgPktAt+rRMFjLo2QPGTdIUcUhfiAeUtVwL33uAC7iBls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775561854; c=relaxed/simple; bh=f7UJQkkG+/fsSZcV3S5WdK7zwrMcxYvVIRINClEe4V0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i1G7Zg9heNd/BVo+Kyk2HNyRw2/pa/CzHXmixI+e53yfYOmic1pPk/FYcjKk3CI1GQdFQ/V2IJmvgErFEemMaUt/7nEPdZz1I4QEU8tnb+21EdHm5GKg95YSAuXLrP3cz1xS7ia/Cfqw6I4KL2njngsuxuyQLutShSyOXGobxko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hW6JDQ8C; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HhqTFnPC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hW6JDQ8C"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HhqTFnPC" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6376aGBt3815231 for ; Tue, 7 Apr 2026 11:37:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f7UJQkkG+/fsSZcV3S5WdK7zwrMcxYvVIRINClEe4V0=; b=hW6JDQ8CE4xQnYxT qqy31TKUnwhwrXoLkAMm2bSXgIXhPPvHRnBnx6oKcvUpBDB2uCOQQWAeZvAubsDM JdGEeDzz142dCXAoL3xA8QxIigULTLuKpiNHlfOC4QmLIcmfqcbOXg858MdVXJ2h 6GUmGqTKki6pAg77R1kfVZXG6KNDwMRxGRtJ3p3XWBvZT/fYL2uq0Ilk3g+Q5ah8 NbQ6XwvSDH6CvqPfLv3VVs5iurC6wdxOoyLL9aaAr+a6Cl6qN5GZHaSkJyLWl++/ ibBtv2UrvXvWpGAUh7SjTLPcDE/cbT5WUEOwZazQooXJf94hKYsRCfioBaJ6cfEn vFC31A== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmr4thp7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 11:37:32 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b2471321dcso140082915ad.1 for ; Tue, 07 Apr 2026 04:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775561851; x=1776166651; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f7UJQkkG+/fsSZcV3S5WdK7zwrMcxYvVIRINClEe4V0=; b=HhqTFnPCWS6glRxCVXObmpKDYF4L+BnAya8056tfEbgOtbui/pTI+ky/2YCCGJIG4H R4CCpntfi4tbLY8/WCOwriL+m6IlAfyhkZUKqMAitADpwaFmV5S4VvZvB+mUS5mErrhh fTB4ZbmkRg5Xdwt+f4JlV02ruHK7dgIltjiR9KPYQS86Vw/KqlWPVDt/bgnNVCKFNVyP SlDe3dq/FteiS9fApQvED28Qzesbw6bhFMJEMzAmRA8o29UoSrexjRvnZbEfllhsTCTG mCiaAaXrWgwKpbGxjnfCo5CU/TpSGJH3axrKuOh2TY8XwD5re9SmQJhTiknqan+ptXCX kFLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775561851; x=1776166651; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f7UJQkkG+/fsSZcV3S5WdK7zwrMcxYvVIRINClEe4V0=; b=ROwxnSc2s2ZWCY73nVwUKSA0tGF4qI/cRTWw9/lf0cmZTdHkSOAJFnWksI8a616hNc H7t51hOXG7llAxzpaUN4/UPEGxFIgMdFS2nN9hAoqEWwIEfEuzRJn1o0K6T+DKtCn9CQ +kGwz9Qt3VvIAX73loCRztoyfrauHAnaLV2WGqVEPvwEGuBek40unstwb/A+NFuJzSsd NrnHe4V0xnPWgwxHqH39GF0/I9zHFHzslqcEK09p1AkxqJbhqfOzP8ylfsnyAWl3p9WW D1ikP3F9hpUWsW5clFxPzGHO+TIuQjoepnaGubFmMnux7/UzQYWDYx+5LJlQVAPYpLkP 1I6w== X-Forwarded-Encrypted: i=1; AJvYcCXvFsa8WpRyD/JKaoieXDappKzQe938igDvS1uVUN3uCTBI2FH3IDhchv7oxE/JMx3F+qqPT1trkB3ggrg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy27aHnj7WDs781aVE2Iat2l2tjYXttWWhddUmJ4NuCyzmPM5X2 KJ0nPzzcxlC+dbCIEuoCXDqv/fqtvR5xb4GH4kC3Zo8eLx1uzD2daJrDRFNKdqitFfVRnJmKCt/ aIAQOMr6hHUMHfsexr8QS55NUc2CZdLKqp5s8wav115GVhgZbJQlQr7UBwTuCPeQPc/U= X-Gm-Gg: AeBDievGwgQaAdaHHJyDoNoP4vJ+dj0ftGL/NcEdZN90xy3FlPqo3dUACs3Qn5EKjBx 9utbwZrXqwIxplt/W8Nj8qNTU/ColaFxxHVFLZQOfieWYf/A7CqvrvR1D9yPMMV6QUU9O9MGoBs 3yFIYbxy076zBaLwiXG6wajdb6MeFtFEsjUxfi77nNEi5okxJSymcwlsoeX5/wDFyzNKivDJUUk rRdLyUO2AVfOu/Z5pMXF9WwW3vt85IbHIoLkpMAsfcsQPmthtX/IUmVO3BRCQU/XNrPMqUSbpXx xqUKeNMOTtOmwBHKeBpAvyTfDmzOI84CpDyQFkVxHkP6a+B+uKrg3RbhIbNjOEaMgLkHDnhr/Za NkBAlv/F/Y5THN6b2AGw+AMAMWKxdaEqMqi5fZOx/6u0NksmNxxcs3g== X-Received: by 2002:a17:903:2c05:b0:2b2:5840:809c with SMTP id d9443c01a7336-2b281828136mr176408925ad.1.1775561851316; Tue, 07 Apr 2026 04:37:31 -0700 (PDT) X-Received: by 2002:a17:903:2c05:b0:2b2:5840:809c with SMTP id d9443c01a7336-2b281828136mr176408545ad.1.1775561850792; Tue, 07 Apr 2026 04:37:30 -0700 (PDT) Received: from [10.218.35.45] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2af067a59sm22227085ad.10.2026.04.07.04.37.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 04:37:30 -0700 (PDT) Message-ID: <2d193ac6-619c-4cd7-b0f1-39f5aa1ec02b@oss.qualcomm.com> Date: Tue, 7 Apr 2026 17:07:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] PCI: qcom: Add D3cold support To: Konrad Dybcio , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Will Deacon Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jonathanh@nvidia.com, bjorn.andersson@oss.qualcomm.com References: <20260311-d3cold-v3-0-4d85dc7c2695@oss.qualcomm.com> <20260311-d3cold-v3-5-4d85dc7c2695@oss.qualcomm.com> <4a18abf4-32b0-40c0-bdd1-81ea819c4089@oss.qualcomm.com> <38f51e0a-fef4-46b5-84e3-0138cc5f79c5@oss.qualcomm.com> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: <38f51e0a-fef4-46b5-84e3-0138cc5f79c5@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=dO6WXuZb c=1 sm=1 tr=0 ts=69d4ec7c cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=MaFP3Q4kykvwS0bM9pgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: U4YqpeRrDCIupT6V9k8dGkpu5S7khq7W X-Proofpoint-ORIG-GUID: U4YqpeRrDCIupT6V9k8dGkpu5S7khq7W X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDEwOSBTYWx0ZWRfX1JQs9TOuSB8h q5SuycQbIGXDpAp8DqHtybBqRlCaGTBRM8XmPXPToh2DZs/peUgxrHqRfv1vta6OTrkEdkJFk5V mx5ilRD9gXOx+j1Yf4lbRi+xr8xOg88S7jkVaRdDEsuK4IZvVsNZJkKlozaiJfhgrGOGLPadsMD rGkh3Aj8MirDKT6HnlBmu1GHCP/K8iizCvVtB+lRLolqsYBr0AjGNte78obRkSmmydF7V4ZCLKc 2DRyVPYtKFWufsICH4WrX8dOOJZM7OBgG2ccaIJcGsS77lQ7BjEvpDKxMokKniaiFJCuoSPqGg2 h7oPSVbSO6krHtsIKqnw4+MMoQdxAJHLm7McWsWYhzCSmSqPex4dWEs3U9rO6np7JmTrjhRSuFV J2WdMH2+0iG4ZDG9qr5jQx7oaXd8vwVhREGxSRyfG0TphLoux24tnsxCu5Z5idh3nQK1XMQ3+LP xezQ+HxxWqRY7nzdWeg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070109 On 4/7/2026 5:06 PM, Konrad Dybcio wrote: > On 4/6/26 11:08 AM, Krishna Chaitanya Chundru wrote: >> >> On 3/17/2026 2:45 PM, Konrad Dybcio wrote: >>> On 3/11/26 11:26 AM, Krishna Chaitanya Chundru wrote: >>>> Add support for transitioning PCIe endpoints & bridges into D3cold by >>>> integrating with the DWC core suspend/resume helpers. >>>> >>>> Implement PME_TurnOff message generation via ELBI_SYS_CTRL and hook it >>>> into the DWC host operations so the controller follows the standard >>>> PME_TurnOff-based power-down sequence before entering D3cold. >>>> >>>> When the device is suspended into D3cold, fully tear down interconnect >>>> bandwidth, OPP votes. If D3cold is not entered, retain existing behavior >>>> by keeping the required interconnect and OPP votes. >>>> >>>> Drop the qcom_pcie::suspended flag and rely on the existing >>>> dw_pcie::suspended state, which now drives both the power-management >>>> flow and the interconnect/OPP handling. >>>> >>>> Signed-off-by: Krishna Chaitanya Chundru >>>> --- >>> [...] >>> >>>>           ret = icc_disable(pcie->icc_cpu); >>>>           if (ret) >>>>               dev_err(dev, "Failed to disable CPU-PCIe interconnect path: %d\n", ret); >>>>             if (pcie->use_pm_opp) >>>>               dev_pm_opp_set_opp(pcie->pci->dev, NULL); >>> Does calling .suspend not drop the vote by itself? >> No, unlike genpd framework for power domains, opp votes will not removed as part of suspend. > Hm, I would imagine the power vote goes down.. is that the ICC vote > that's still hanging if we don't do this? yes, ICC votes are still present - Krishna Chaitanya. > Konrad