From: Johannes Berg <johannes@sipsolutions.net>
To: Eric Biggers <ebiggers@kernel.org>, linux-wireless@vger.kernel.org
Cc: syzbot <syzbot+d1008c24929007591b6b@syzkaller.appspotmail.com>,
ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com,
hpa@zytor.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com,
tglx@linutronix.de, x86@kernel.org
Subject: Re: [syzbot] [wireless] BUG: unable to handle kernel paging request in ieee80211_wep_encrypt
Date: Fri, 18 Jul 2025 17:57:27 +0200 [thread overview]
Message-ID: <2d1a41aa000c8de8f82827bd8c06459e01f10423.camel@sipsolutions.net> (raw)
In-Reply-To: <20250718145049.GA1574@quark>
On Fri, 2025-07-18 at 07:50 -0700, Eric Biggers wrote:
> >
> > BUG: unable to handle page fault for address: ffff8880bfffd000
[...]
> > Call Trace:
> > <TASK>
> > crc32_le_arch+0x56/0xa0 arch/x86/lib/crc32.c:21
> > crc32_le include/linux/crc32.h:18 [inline]
> > ieee80211_wep_encrypt_data net/mac80211/wep.c:114 [inline]
> > ieee80211_wep_encrypt+0x228/0x410 net/mac80211/wep.c:158
[...]
> > nl80211_tx_mgmt+0x9fd/0xd50 net/wireless/nl80211.c:12921
>
> syzbot assigned this to the "crypto" subsystem. However, the crash
> happened in crc32_le() which is not part of the crypto subsystem. Also,
> crc32_le() is well-tested (e.g. by crc_kunit), and the bug is unlikely
> to be there. Rather, the calling code in ieee80211_wep_encrypt_data()
> is passing an invalid data buffer to crc32_le(). So let's do:
Agree, that makes sense, looks like we never check the frame length
correctly. Since there's no reproducer (yet) I guess we won't be testing
against it with syzbot though :)
johannes
next prev parent reply other threads:[~2025-07-18 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 10:15 [syzbot] [crypto?] " syzbot
2025-07-18 14:50 ` [syzbot] [wireless] " Eric Biggers
2025-07-18 15:57 ` Johannes Berg [this message]
2025-07-18 18:03 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d1a41aa000c8de8f82827bd8c06459e01f10423.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=ebiggers@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+d1008c24929007591b6b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®