From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1049329E5E for ; Tue, 10 Feb 2026 22:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.18 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770761599; cv=fail; b=FxwD/rAx/YRn5ee3NzLBIjmTRxDdiJIeTnn/t8RhaIuRUbqm5NLkKKSq1fuIXQE9pb0jXKNbjl80iy6uBOKoxLBMbgDcx6BONTLrdMIfgufnB/cN3jCFeq1lZmqex0WQERlWCiLdpFkLwOsCMWNNaz0gTnyGt65m/ephoCTTVrQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770761599; c=relaxed/simple; bh=UFDAZXhE42uJt8ykg4wW8kYWTvmb1cwTXpjn9u0QS48=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=o9b+JPsXniMzyhAp8wXbWzi7mBp9nQVEdtUpEelOHXJKB4iKe5Dz6PJUKu/5RXySL1n0Wm6msMY2ymLLrtEeIR+r2D4QSxtmFRP28HMBiiLW1NVzQkjB4TZT2b/dW9D9Up5MkV3lnRKMKVG+uEWwjDZ1w6wgQty1pbqQ+5JdTss= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GtEd0KgZ; arc=fail smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GtEd0KgZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770761598; x=1802297598; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=UFDAZXhE42uJt8ykg4wW8kYWTvmb1cwTXpjn9u0QS48=; b=GtEd0KgZSqpsVSbP8JjOe909eNAfswS7sL9WyC/DUNExjqV+57yWPdwt udMVTKK4TXuzpFZGtyZq5W5Qqj5FQEIFuilxwjYtP1Ix6v7g8RYx1v+B0 WNayqIcDI4gFdVTapG5cLoo9zZ4FfhvyUST08fxVtSIxmKbMKfv4RAPZ4 rUeLREga3oaYyF9vAL7jnUUz3zVCyxzn9nzehO7bvpjPph+aExvdJsY/P iBEAgTFGjrf0589DIXGNCIVCZigsBnzamGmP4zZTlWszQNRGlTSdgFBpI sb7O+clqM54ITPHis15ln2yRsKLFvrl9w0WQsORAXnwhVQ9+K40+hALih w==; X-CSE-ConnectionGUID: d3Y1NMxeT7eGDqpr8ccIIw== X-CSE-MsgGUID: F4UgMDpWRQyziAjsAQUBuQ== X-IronPort-AV: E=McAfee;i="6800,10657,11697"; a="71945834" X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="71945834" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2026 14:13:18 -0800 X-CSE-ConnectionGUID: GhjCpWLaSuK449dqkAmORA== X-CSE-MsgGUID: Xw0uJ7y2RL6Ot2Fu23EMgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="216584218" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2026 14:13:18 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Tue, 10 Feb 2026 14:13:17 -0800 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35 via Frontend Transport; Tue, 10 Feb 2026 14:13:17 -0800 Received: from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.25) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Tue, 10 Feb 2026 14:13:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GyEidC6YAFDosvpSqoAo8McavPsNEwMwMaqQnzolw6Bxg8lbLRXrIBHgUtNKnKruiQXPEZLCGIH6kDoF7JvJ8xG/1E/6ipoOMuYzkJRRONRgP9CCqQM1ORm0xGVZkO9ylSVMnM0/21tRVbERzqB/uG7OwDOaWPjnBptCW1QehUCex2t5N87KgACmliXIgDvOGAdhuQtB0irgHXJHX+A2JJVn8D/8rA0wgd4jLZtQ77F7BQu/tguPvarqsci/nEvh04cfZj7wm4xEmBjxzBCt8EMCfXY/FFRHzBoW2OaFBax80RrQqRjTLcHShRkLxFh12jyZT8qy7ALgggKouHxGOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q4GJkevoYn6DJsRRAr00lCqoRp4rBBHPDbkZXdHvTr0=; b=fhzkXlUO4rtDm5V/MCnJnAILqyFDBwk3wW5SvZWK9w0Jn68Ng1QH6F/IUHZ+7f+kc7HdRS2OfiSkVItG8tW9MRvSUVpt6EZKNx7cUD/qKqP2J/vtlrpeRzZjJfj9XHRijqUt2Ucc3v3g+SSdJFVwTASTEmAMTRKsojalFfD2ASQmCK/Svt0o7vSB8wYbuyaI1iwW6GjzqeTlr6tJLL1LOmKEGwbhETav+XgY86q0WtD23ql2P+O+txjGeAwBbvzMz6sfi/7loP0uVORtUgeYY306I+5e2sV9h7C5dtf5G1IIz5ziSdoI2KRR/wcjEbRu13YfAN/eeXUbHL4yTaaVaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) by PH8PR11MB8108.namprd11.prod.outlook.com (2603:10b6:510:257::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.19; Tue, 10 Feb 2026 22:13:13 +0000 Received: from DS0PR11MB7997.namprd11.prod.outlook.com ([fe80::24fa:827f:6c5b:6246]) by DS0PR11MB7997.namprd11.prod.outlook.com ([fe80::24fa:827f:6c5b:6246%4]) with mapi id 15.20.9611.006; Tue, 10 Feb 2026 22:13:13 +0000 Message-ID: <2d1cd1a3-4447-41e7-9af8-6cf80876247d@intel.com> Date: Tue, 10 Feb 2026 14:13:10 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header Content-Language: en-US To: Dave Hansen CC: , Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Jon Kohler , Pawan Gupta , "Peter Zijlstra (Intel)" , Thomas Gleixner , Tony Luck , , Iwona Winiarska , LKML References: <20260206231438.720FF4E3@davehans-spike.ostc.intel.com> <20260206231440.C35AD1C5@davehans-spike.ostc.intel.com> From: Sohil Mehta In-Reply-To: <20260206231440.C35AD1C5@davehans-spike.ostc.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY1P220CA0017.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5c3::6) To DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7997:EE_|PH8PR11MB8108:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bbcc31f-7536-47c9-5a5b-08de68f1954e X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dkRZOXR6Y1E1bDZDZkR5RHQ2ZzRTN2pXVkp3d0lCTGk1VjhVTHA5VHJoZHls?= =?utf-8?B?cDlLeDNKOFJKUTNHUC9NWTBvQWhkeDJJNUNaNXdqaDZlOXRGNTA1RC9VRDdz?= =?utf-8?B?TFgvbVQ4K2RRbDc1d0Q4N3JhMmY3Rml2NWh3dU5sSEFxS3Y1MFIxeHd2T3Z0?= =?utf-8?B?TUNPVFI5RzZHaXhiaERWUittdGhsbFFpbVJXUWZRYnA5czhCZXZla0tHNVRE?= =?utf-8?B?RGllV2JjM1hUUEhvSXFuNkhtMCtLR2d5WFZKL0N1WmFnSHlIbmljNS9nT09X?= =?utf-8?B?ZFV2N1k4Y2JPMzFqcWV6eUJQbmpzTEZpN3pqeEJ1cFRITXpjQ05aeXhFdDda?= =?utf-8?B?Sk90OW9mdzAvRWsxSlprRDIrMmUrekJ1VFRFTjEyZ052ZmpXZGN6bU14Wm14?= =?utf-8?B?V0cxTUY3NlZ3RFlPN1VxSWdyYjA3MldkUlU0YlRiaytOd21BWXJoT0w0NDF4?= =?utf-8?B?YnFUOTd3dnQveWpNY29uMlhOb3Azb2VaeWNDZk04ZUdhdEFWT3IxVTlLNFc4?= =?utf-8?B?UndibnRKakVHMEk5RXhaZWZLbEt2NUh2S1ZMVitEOFl1VTJzcGVFM0srYUJv?= =?utf-8?B?am1Ia0tqZGN1WEZucDVlZWdFL2xQODF4Sjl1MExKakZ5ZnpPckYvM1BnejFZ?= =?utf-8?B?UXREV2szTWVRcHdHaWVqdnM0Q2RndkJLZ2pqRXdtUjlYZlBVMTdnaWxIK090?= =?utf-8?B?TGhSRjAvRTFtQXZRZGt2VnYzNjhydEJEL2ZiVXhhZFRBM0VnTDdlU2RMWldj?= =?utf-8?B?M0g2S2ErMGRPYS9vclJnTmxMUEtSVERURzRodFo3R3NtRHZQWHlNNVR1K2Fk?= =?utf-8?B?Tk9PdGhJM1pCT0ZGYUpLeFRnTU5OTTNpMHA5N3ZCcEFuRlNOYWkvSEQyeVJl?= =?utf-8?B?Uks1TkRKUWVHYnhUUXU2TUdKWTR6L01RNVB6bmZCdUdhMFExM2RwK3phdUpT?= =?utf-8?B?cmd5bnY1QWdlNmNqTE56SWVjcmhCWW4yZW8rZ2lNRnFQSU41N1IyaUtINWhM?= =?utf-8?B?TXEzYlkwUWFMRlZITjFEOUpsbFZsZ3BOTWNzWVhIVzRmZzE0REk1L1V5dElT?= =?utf-8?B?R29Xcmw3UWV0b2FSak5LOHpIOStVL1Y2TVphT0ZVbGVXVytibVhLQmFQTUlY?= =?utf-8?B?dzNUd1krQjRkUnltYnVlVWd2MGRGVU5KcE94Wjd4Z2dZdnMvN3ZqVk5GeUQ3?= =?utf-8?B?V3BsU0hxQmp3bnZqWXN3bEt5bzc2SDQzeVRiOTBUM0YxOGFEb3VpdkNNSkF1?= =?utf-8?B?WXV2cW9ET1kwQ0xhekUyYnIrY2hNTGZvWmFyc0NVeC9DalpyTG5kckRYWndI?= =?utf-8?B?N2d0WVNZbmVyd0xwdjV3eGFyZjUybnhUQTRaTjB3Q2RZclowRGxmeXpoQWM4?= =?utf-8?B?b056YXYzVFRFVkZ0T0hOTm9vMURFODdsU0k5eTB2WDBYOUpUNFJ4dnRja3Zw?= =?utf-8?B?V0c0TEk1V3ZZelJzQytKdkZKQS9JOGYvWTRoaVBieVVva3UwcXRwekhkVzZr?= =?utf-8?B?Mjdva25UYU9yMnpvWjdRZ1lQNTlrRDBkREV2M0hrN2plYlRKNXBmRFlXS3ow?= =?utf-8?B?TjNXSW16S01zQnFGVis2STZSRmhtVUMyQWNuRW9USHovZ3JxUTM4dmphRGRU?= =?utf-8?B?M1J1M3VTenlZcUY3Z0p3RUtLYlE4aVpXVE9XaUd3cUhLbTZkLzNSSWcxZWVQ?= =?utf-8?B?eVAva2pzMThpRnNwSDVvdzc0K1prRVhGcmpjdGM1UXEzUGh1Yk8vZXI0NXNC?= =?utf-8?B?QnNjWHJsSTVCUDRuOU1NRjF6VzV3MHVRRmxtY2pjZ01sdjZmem5YWVlCSXBj?= =?utf-8?B?aEZFeWNUcG1TWDY5WFdaNXEvUVUyeGlWditXNHNDRmFiS0VYWkNjVDRtb2lx?= =?utf-8?B?KzhyNGk5Q01Ub0VhSld2Vk53TXAwQU9xcTQvazR4WW4vb1RQWDFMdTFCUG9D?= =?utf-8?B?aEMwcnVEWWNrMysrS1NtTzRJK0tBWnUxc0liSGtTZzl1Y2FzN2FsdWFNdW82?= =?utf-8?B?bEduUDlEY2NZMjZTV25PbThDd3NvNXdFaWZFZkRvM1JEb08yN3Q3OFJ2bFUr?= =?utf-8?B?ZTJ4Umpjb0RBcXNWSlpLRXFDcWY5L0JrMHY4YUZFVUo1cHFVZDJGODM4TkNs?= =?utf-8?Q?sq2g1I5VWE6VXdqhjOPVgPnhz?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB7997.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFQrRjNpaHpWSE4xOGxhRXp6T1RlV2RxdEFZUTZ1OHVrZzA4a3paRFgvSkJy?= =?utf-8?B?b096STNyaUxReVQ2ZmloU3AzUXVNRkZtTTY0NEhlaHAyenJCdEJvdWcxQ3B0?= =?utf-8?B?cllUZUplVy82ZDNyWVVoM0FJaXZaOU94bVJXc1VhWWpTdEdPRVJRWnFMbzM3?= =?utf-8?B?OGpTb3hwdkx6djlpa0tKVmlMYWZLY0JTZnhJaGVUcjJ0WG1sSVVBYmlZUk5z?= =?utf-8?B?YnRwOEpxcVo5ZzNCU0E0UklDNkt6WEdKMU5zTDBpOXo1dXUvNzJ5MVVxQUFF?= =?utf-8?B?UkY0YjA3M1lvczRPc3o1a2E2NGdwcHdjeWdwRW0vU3ZzN0h5Wmh4Ui9EMG9o?= =?utf-8?B?OGROd3BYdjA1N0RPVkNGMGRKcVNrb0FHVS9uNk5vNmFyUVJGSXNNOFB1UVpV?= =?utf-8?B?V2dBdTVzRzJFSTY2NUZad3dsdkNTUzhKcExJNnB2dmpObjRqZHJ4UGhkUnVZ?= =?utf-8?B?RTZMWmlRNmhGcVlmSG9HM0FEcTJ6UmRYaVhGWitjOWY4U3AxUHJxbFEwUzBn?= =?utf-8?B?VllYc3BXbXZiMGlvczZqZUlhSlcwQ3Z0UWlFVkk5aEo4WGhRVmpxclhscDA2?= =?utf-8?B?dEc4R0lzcy9kWjVwWkVEYXVWSWxqdVFOdDNtOFVWTDIwWU1rdkxGMVZ1NnlE?= =?utf-8?B?bVpLS2hwbW9xMzhDY3VPWk9PMmhSbGJldk05RnlEejdBbUphdEF0N0paRWM3?= =?utf-8?B?YVhmTldNM1lxWHVpbUNYaEhEQ3lvNFYxZFd0VVRDUTN6Zy9EMmhHS01TVy8x?= =?utf-8?B?L05Jd3MwL1JHSDJ5dU53b3U2aTQwZnlWakU3QVR4Mmx0NS9UN0FXbyttd0g1?= =?utf-8?B?b1dIVjJPUVNSd1kxQzBOYWR6VFIzdnlTOGdCWUtsL1pLTUpKaXpzak1Nck14?= =?utf-8?B?azh3MmgrU2paaEJsZHFXY1JBcHJpMTlFNGtoNFZrczN5YkpLd1BIVkQ2WjZz?= =?utf-8?B?ZFlBank1UnAxdmovTk9QTWU5a0RZMW1FRjZXSC9yWUw3bEJDWDlMVDRDeVRx?= =?utf-8?B?ZWxJWFFnVExISkdOVkF1NnRMZUY1RG5WQ21KZVhGZUVuZHkwNEhQSjlLWVFF?= =?utf-8?B?eDVGUHMyMldra3l2SWtuem41NWxCUzhMc0tGNWlUWEtvbVN4VDVzbExZdzZk?= =?utf-8?B?YnZ2Q2luRUZnWGVqanV6ZnpUT0U1dXNmQVpUWXRLWWhLcXhCQzIyaWEyc1NC?= =?utf-8?B?RE41S1p1STlQS2JaYXUyeHR1UFJFQ29SbmNaZVNuaStxWVAxdEFTTkl5M245?= =?utf-8?B?QkMvckk3RlRxMm16a0JzcjJ1S2dBMW5YeFM4K1E1YlU3NlpSYWptR2FGODQ4?= =?utf-8?B?SjhDMzhQUXBYVFhobVh2TWpnQXZyT0lSSXdUdjQ4dzlQV2NEWThyTEtXaUhS?= =?utf-8?B?WlNBT1FteGZzMzh5cDYweHVrQzc0UXRrOGt4aFY3eDFlMlhUTmZZbUo5dUpX?= =?utf-8?B?c3c4UzdlSjNhbm1yZ2ZObkRBY1JQY0h2emdNaFhpOXd2TmdkZVdYSkV0UFRu?= =?utf-8?B?blJiMVVoemhQZ20zeGNGT2VDaUwwRmRyb3V5MmFiVWgyL2xuVWp6Y2xHRGQx?= =?utf-8?B?ZXBkbS82Z0xiK09UU09EeHVYYnUwak03Wi9xRFh2QWtPTXJ1UFpxZXhQak93?= =?utf-8?B?RzAvVUhjQzdmTFVxMWdrM01ITThwVUNmdS9CZWRmSEMxSWpObm1EZ0ZOcmow?= =?utf-8?B?VDVraFFWTTFLM2x3dlJvTjZuczZhOUM1alZnT0JwVmtCRGpSZnZjMTd0TmJ0?= =?utf-8?B?cy9lZWpFN0V2eEtIRVJjR0FoSVU4RXI0N29Zb01OSFhEYUVwMENMQWxUUXVJ?= =?utf-8?B?eCttZW9ja1BES3FiOG13Zlo5aDFpaFluR3hqN21Db21pcGNFa2VaVjRlZ0dE?= =?utf-8?B?Q1RrcHI2QlVTaEFkZzhUNUtIaG5JcG9PVlR4UHNOVk5oTG54T1AzTjZub2RR?= =?utf-8?B?WUJkdFAyVnBaZWdQZUpYamUxTitUNHhSdzhxQTZobFZ2RmNURFRodTJmb282?= =?utf-8?B?aVFVTkE2YUl1dmlhNlFRcmZSUGl3STFmekdXZDhMdXZTa1J4aFhtVXdvRnh4?= =?utf-8?B?c084WFRUMXh3VlpseS9jb2hJa3dXR0NUSTRWekJHVUY3MUl6NGRnWVltK1BK?= =?utf-8?B?Y0V0QkNmOTIzRmYzS1R4S0g2TlV3Y0xtNzBLV0k3REM1QlFJYnJ4dWl5RVIr?= =?utf-8?B?U0lYR2ZId3hQUWZCbHVVWk5INWtJak1JVnJwbU5aNXUyY20xbCtDQ0ljRWV0?= =?utf-8?B?MW5wdUR5Z0NLR3VzcWJrZ2RBcWNaUzVPOG5VYzlnbE9uSjBEaGlMS0xFUXF6?= =?utf-8?B?R09NdldRaU5xUEpSVTRPdGt1bjgwWUhabWwzL1NKTGZoNWo1MHdqdz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0bbcc31f-7536-47c9-5a5b-08de68f1954e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2026 22:13:13.6058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p4ngwIrZ2pwbkA05eIQPr/dMhO1rISJQYRdLu5TmJ3YK+aqzL9Qghr0z/VTo6QfviUeopf6dx15araq2WkswzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8108 X-OriginatorOrg: intel.com On 2/6/2026 3:14 PM, Dave Hansen wrote: > > From: Dave Hansen > > The intel-family.h header uses Vendor/Family/Model macros but it does not > #include the header where they are defined. If that header is included, > the build blows up in #include hell. > Is the cause of the #include hell the single line in peci-cpu.h? #include "../../arch/x86/include/asm/intel-family.h" intel-family.h also uses the X86_VENDOR_INTEL from asm/processor.h without including that header. At some point would we want to fix that as well? However, that would contradict the comment you add in patch 2, "Do not use any x86-specific headers.." in intel-family.h. Any solution for this would also run into the same issues. Therefore, the PECI driver currently does: /* Copied from x86 */ #define X86_VENDOR_INTEL 0 /* End of copied code */ So, anytime intel-family.h needs to use something x86 specific, the PECI driver needs to either copy it or we would need to move it to generic code. > Luckily, these macros are completely independent and do not themselves > have any dependencies on other code. > > Break the VFM_*() macros out into their own header. > > Note that the new header is in asm-generic. Believe it or not, the > intel-family.h header is included from a driver in arch-generic code: > > #include "../../arch/x86/include/asm/intel-family.h" > > Putting the header in generic code will move in the right direction > of reducing the amount of code that the "peci" driver needs to copy. > AFAIU, the PECI driver is the only user of this VFM stuff in non-x86 code. Are we expecting other generic usages for it? The VFM macros and the VFM model defines usually go hand-in-hand. Is there a reason for keeping intel-family header in arch/x86 but the VFM one in asm-generic/? I wonder if it would more consistent to move the VFM macros into arch/x86/include/asm/vfm.h? And then let the PECI driver do: #include "../../arch/x86/include/asm/vfm.h" Though, intel-family.h would probably need: #ifdef CONFIG_X86 #include #endif This isn't ideal but at least the ugliness is limited to a few lines in one specific driver. This avoids the need to add x86-specific includes to the otherwise tidy asm-generic folder. However, this wouldn't solve the X86_VENDOR_INTEL issue or any future dependencies in intel-family.h. Maybe it is time to revisit the reasoning that led to the current PECI driver implementation :) https://lore.kernel.org/lkml/67f2cfda-c78b-6282-f5a3-2f345f8e2849@intel.com/